Re: [linux-dvb] [Fwd: Mantis gpio_set_bits() fix]
Hi Michel, Great that the fix helped you. The last problem might well be with the card, because those channels don't work under Windows either. Do you have any clue that how those channels differ from the ones that you find with a scan? Astra might have details of their channels in their Website. Here in Finland on some cards DVB text works under Linux, but not under Windows. Extracting text from TS is done in software. Regards, Marko Ristola Michel Verbraak kirjoitti: Marko Ristola schreef: Onderwerp: Mantis gpio_set_bits() fix Van: Marko Ristola [EMAIL PROTECTED] Datum: Sat, 17 Mar 2007 11:14:08 +0200 Aan: Manu Abraham [EMAIL PROTECTED] Aan: Manu Abraham [EMAIL PROTECTED] Hi Manu, Here is a bugfix for gpio_set_bits(). What do you think about this bugfix? The bug is that the function is only able to turn the given bit on, but it can never turn a bit off. My patch fixes that issue. With my patched version gpio_set_bits is able to turn a single bit on or off. I haven't verified that it actually does turn the device's power off when requested. I tested only rmmod and insmod. It seems to work with this version: I haven't seen a lost frontend. Regards, Marko Ristola This patch solves also the modulation change problem (18v or 13v). I can now receive and scan the same channels as the Windows driver is capable of. I still have the problem that the driver cannot tune to all available channels on a satellite. The windows driver has the same problem. Could this be a problem of the card? Regards, Michel. ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] [Fwd: Mantis gpio_set_bits() fix]
Marko, Did not have time yet to find out. Next weekend I will have a look into it and report back. Regards, Michel. Marko Ristola schreef: Hi Michel, Great that the fix helped you. The last problem might well be with the card, because those channels don't work under Windows either. Do you have any clue that how those channels differ from the ones that you find with a scan? Astra might have details of their channels in their Website. Here in Finland on some cards DVB text works under Linux, but not under Windows. Extracting text from TS is done in software. Regards, Marko Ristola Michel Verbraak kirjoitti: Marko Ristola schreef: Onderwerp: Mantis gpio_set_bits() fix Van: Marko Ristola [EMAIL PROTECTED] Datum: Sat, 17 Mar 2007 11:14:08 +0200 Aan: Manu Abraham [EMAIL PROTECTED] Aan: Manu Abraham [EMAIL PROTECTED] Hi Manu, Here is a bugfix for gpio_set_bits(). What do you think about this bugfix? The bug is that the function is only able to turn the given bit on, but it can never turn a bit off. My patch fixes that issue. With my patched version gpio_set_bits is able to turn a single bit on or off. I haven't verified that it actually does turn the device's power off when requested. I tested only rmmod and insmod. It seems to work with this version: I haven't seen a lost frontend. Regards, Marko Ristola This patch solves also the modulation change problem (18v or 13v). I can now receive and scan the same channels as the Windows driver is capable of. I still have the problem that the driver cannot tune to all available channels on a satellite. The windows driver has the same problem. Could this be a problem of the card? Regards, Michel. ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] [Fwd: Mantis gpio_set_bits() fix]
Marko Ristola schreef: Onderwerp: Mantis gpio_set_bits() fix Van: Marko Ristola [EMAIL PROTECTED] Datum: Sat, 17 Mar 2007 11:14:08 +0200 Aan: Manu Abraham [EMAIL PROTECTED] Aan: Manu Abraham [EMAIL PROTECTED] Hi Manu, Here is a bugfix for gpio_set_bits(). What do you think about this bugfix? The bug is that the function is only able to turn the given bit on, but it can never turn a bit off. My patch fixes that issue. With my patched version gpio_set_bits is able to turn a single bit on or off. I haven't verified that it actually does turn the device's power off when requested. I tested only rmmod and insmod. It seems to work with this version: I haven't seen a lost frontend. Regards, Marko Ristola This patch solves also the modulation change problem (18v or 13v). I can now receive and scan the same channels as the Windows driver is capable of. I still have the problem that the driver cannot tune to all available channels on a satellite. The windows driver has the same problem. Could this be a problem of the card? Regards, Michel. ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
[linux-dvb] [Fwd: Mantis gpio_set_bits() fix]
---BeginMessage---
Hi Manu,
Here is a bugfix for gpio_set_bits().
What do you think about this bugfix?
The bug is that the function is only able to turn the given
bit on, but it can never turn a bit off.
My patch fixes that issue.
With my patched version gpio_set_bits is able to turn a single bit
on or off.
I haven't verified that it actually does turn the device's power off
when requested.
I tested only rmmod and insmod. It seems to work with this version:
I haven't seen a lost frontend.
Regards,
Marko Ristola
Index: linux/drivers/media/dvb/mantis/mantis_core.c
===
RCS file: /var/cvs/mantis/linux/drivers/media/dvb/mantis/mantis_core.c,v
retrieving revision 1.2.2.2
retrieving revision 1.2.2.2.2.1
diff -u -p -r1.2.2.2 -r1.2.2.2.2.1
--- linux/drivers/media/dvb/mantis/mantis_core.c 15 Feb 2007 17:25:59 - 1.2.2.2
+++ linux/drivers/media/dvb/mantis/mantis_core.c 24 Feb 2007 17:54:25 - 1.2.2.2.2.1
@@ -194,22 +194,22 @@ int mantis_core_exit(struct mantis_pci *
return 0;
}
+// Turn the given bit on or off.
void gpio_set_bits(struct mantis_pci *mantis, u32 bitpos, u8 value)
{
- u32 reg;
+ u32 currVal;
+ u32 newVal;
- if (value)
- reg = 0x;
+ currVal = mmread(MANTIS_GPIF_ADDR);
+
+ if ( value )
+ newVal = currVal | ( 1 bitpos );
else
- reg = 0x;
-
- reg = (value bitpos);
+ newVal = currVal ( ~ ( 1 bitpos ) );
- mmwrite(mmread(MANTIS_GPIF_ADDR) | reg, MANTIS_GPIF_ADDR);
+ mmwrite( newVal, MANTIS_GPIF_ADDR);
mmwrite(0x00, MANTIS_GPIF_DOUT);
udelay(100);
- mmwrite(mmread(MANTIS_GPIF_ADDR) | reg, MANTIS_GPIF_ADDR);
- mmwrite(0x00, MANTIS_GPIF_DOUT);
}
---End Message---
___
linux-dvb mailing list
linux-dvb@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
Re: [linux-dvb] [Fwd: Mantis gpio_set_bits() fix]
On 3/17/07, Marko Ristola [EMAIL PROTECTED] wrote: -- Forwarded message -- From: Marko Ristola [EMAIL PROTECTED] To: Manu Abraham [EMAIL PROTECTED] Date: Sat, 17 Mar 2007 11:14:08 +0200 Subject: Mantis gpio_set_bits() fix Hi Manu, Here is a bugfix for gpio_set_bits(). What do you think about this bugfix? The bug is that the function is only able to turn the given bit on, but it can never turn a bit off. Ah, i saw that bug a day back, but didn't care to fix it. My patch fixes that issue. Cool, Thanks. With my patched version gpio_set_bits is able to turn a single bit on or off. I haven't verified that it actually does turn the device's power off when requested. thanks, manu ___ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
