Re: [PATCH v3] efivars,efi-pstore: Hold off deletion of sysfs entry until, the scan is completed

2013-10-16 Thread Madper Xie
Howdy Seiji, I failed appily this patch to both 3.12-rc2 and 3.12-rc4. Could you please let me know which is the right tree for this patch? Thanks, Madper. seiji.agu...@hds.com writes: > Change from v2: > - Move dynamic memory allocation to efi_pstore_read() before holding > efivars->lo

RE: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-16 Thread Seiji Aguchi
> There's also an "either/or" choice between using efi-capsule with pstore, and > the > traditional kexec/kdump method for getting a memory dump from a crash. We > have to go through a reset to save the capsule - but we don't want a reset for > kexec. Perhaps we can pass the reset parameters th

RE: [PATCH 2/5] efi: Introduce a Runtime Services lock

2013-10-16 Thread Seiji Aguchi
> +#define efi_call_reset_virt(f, args...) > \ > +({ \ > + unsigned long __flags; \ > + bool __nmi = in_nmi();

Re: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-16 Thread Andi Kleen
> + It should be noted that enabling this opton will pass a capsule > + to the firmware on every boot. Some firmware will not allow a > + user to enter the BIOS setup when a capsule has been registered > + on the previous boot. That sounds like a problem. Can this be fixed

RE: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-16 Thread Luck, Tony
> Where by "May not function correctly" you mean "May crash the system"? > I'm a little uneasy having this run by default if enabled, even if it's > disabled by default in the config. There's also an "either/or" choice between using efi-capsule with pstore, and the traditional kexec/kdump metho

Re: [PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-16 Thread Matthew Garrett
On Wed, Oct 16, 2013 at 02:51:00PM +0100, Matt Fleming wrote: > + Many EFI machines have buggy implementations of the UpdateCapsule() > + runtime service. This option will enable code that may not function > + correctly with your firmware. Where by "May not function correctly" y

[PATCH 2/5] efi: Introduce a Runtime Services lock

2013-10-16 Thread Matt Fleming
From: Matt Fleming Section 7.1 Runtime Services Rules and Restrictions of the UEFI spec describes how many of the runtime services are not reentrant. We need a method of prohibiting functions from being called concurrently. We've managed to get away without requiring a runtime services lock unti

[PATCH 0/5] EFI capsule pstore support

2013-10-16 Thread Matt Fleming
From: Matt Fleming The UEFI spec describes a capsule mechanism that allows data blobs to be handed to the firmware at runtime. If the firmware doesn't recognise the guid of the capsule and if certain flags are set in the capsule header, the firmware will preserve the memory region containing the

[PATCH 5/5] efi: Capsule update support and pstore backend

2013-10-16 Thread Matt Fleming
From: Matt Fleming The EFI capsule mechanism allows data blobs to be passed to the EFI firmware. By setting the EFI_CAPSULE_POPULATE_SYSTEM_TABLE and the EFI_CAPSULE_PERSIST_ACROSS_REBOOT flags, the firmware will place a pointer to our data blob in the EFI System Table on the next boot. We can ge

[PATCH 4/5] efi: Move efi_status_to_err() to efi.h

2013-10-16 Thread Matt Fleming
From: Matt Fleming Move efi_status_to_err() into the efi.h header as it's generally useful in all bits of EFI code where there is a need to convert an efi_status_t to a kernel error value. Signed-off-by: Matt Fleming --- drivers/firmware/efi/vars.c | 33 - inclu

[PATCH 3/5] efi: Add common efi_reboot() implementation

2013-10-16 Thread Matt Fleming
From: Matt Fleming The reboot functionality is the same for all EFI implementations, so provide a wrapper that is useable by all architectures. Cc: Leif Lindholm Cc: Tony Luck Signed-off-by: Matt Fleming --- arch/ia64/kernel/process.c| 2 +- arch/x86/kernel/reboot.c | 14 +-

[PATCH 1/5] pstore/ftrace: Don't increment initial data offset

2013-10-16 Thread Matt Fleming
From: Matt Fleming Delete the following expression, data->off = ps->size % REC_SIZE; as it is not reasonable to expect users to allocate an exact multiple of REC_SIZE because that constant isn't exported outside of fs/pstore. There are already checks in the ftrace code to ensure that no

Re: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support

2013-10-16 Thread Ingo Molnar
* Matt Fleming wrote: > On Mon, 14 Oct, at 09:57:26AM, Ingo Molnar wrote: > > > > * H. Peter Anvin wrote: > > > > > On 10/12/2013 10:49 AM, Ingo Molnar wrote: > > > > > > > +static void early_efi_write_char(void *dst, char c, int h) > > > +{ > > > +const u8 *src; > > > >>>

Re: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support

2013-10-16 Thread Matt Fleming
On Mon, 14 Oct, at 09:57:26AM, Ingo Molnar wrote: > > * H. Peter Anvin wrote: > > > On 10/12/2013 10:49 AM, Ingo Molnar wrote: > > > > > +static void early_efi_write_char(void *dst, char c, int h) > > +{ > > + const u8 *src; > > + u32 fgcolor = 0xaa; > > >>> >

Re: [PATCH] x86 efi: efi reverve boot service fix

2013-10-16 Thread Maarten Lankhorst
op 16-10-13 10:07, Matt Fleming schreef: > Also better include Maarten on Cc as the author of the code. > > On Wed, 16 Oct, at 03:11:22PM, Dave Young wrote: >> typo, fix hpa's mail address.. >> >> On 10/16/13 at 03:03pm, Dave Young wrote: >>> Current code check boot service region with kernel text

Re: [PATCH] x86 efi: efi reverve boot service fix

2013-10-16 Thread Dave Young
On 10/16/13 at 09:07am, Matt Fleming wrote: > Also better include Maarten on Cc as the author of the code. Will do in next version -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

[PATCH v2] x86 efi: efi reverve boot service fix

2013-10-16 Thread Dave Young
Current code check boot service region with kernel text region by: start+size >= __pa_symbol(_text) The end of the above region should be start + size - 1 instead. I see this problem in ovmf + Fedora 19 grub boot: text start: 100 md start: 80 md size: 80 Signed-off-by: Dave Young --

Re: [PATCH] x86 efi: efi reverve boot service fix

2013-10-16 Thread Dave Young
On 10/16/13 at 12:29am, H. Peter Anvin wrote: > On 10/16/2013 12:11 AM, Dave Young wrote: > >> > >> --- linux-2.6.orig/arch/x86/platform/efi/efi.c > >> +++ linux-2.6/arch/x86/platform/efi/efi.c > >> @@ -440,7 +440,7 @@ void __init efi_reserve_boot_services(vo > >> * - Not within any par

Re: [PATCH] x86 efi: efi reverve boot service fix

2013-10-16 Thread Matt Fleming
Also better include Maarten on Cc as the author of the code. On Wed, 16 Oct, at 03:11:22PM, Dave Young wrote: > typo, fix hpa's mail address.. > > On 10/16/13 at 03:03pm, Dave Young wrote: > > > > Current code check boot service region with kernel text region by: > > start+size >= __pa_symbol(_

Re: [PATCH] x86 efi: efi reverve boot service fix

2013-10-16 Thread H. Peter Anvin
On 10/16/2013 12:11 AM, Dave Young wrote: >> >> --- linux-2.6.orig/arch/x86/platform/efi/efi.c >> +++ linux-2.6/arch/x86/platform/efi/efi.c >> @@ -440,7 +440,7 @@ void __init efi_reserve_boot_services(vo >> * - Not within any part of the kernel >> * - Not the bios reserv

Re: [PATCH] x86 efi: efi reverve boot service fix

2013-10-16 Thread Dave Young
typo, fix hpa's mail address.. On 10/16/13 at 03:03pm, Dave Young wrote: > > Current code check boot service region with kernel text region by: > start+size >= __pa_symbol(_text) > The end of the above region should be start + size - 1 instead. > > I see this problem in ovmf + Fedora 19 grub bo

[PATCH] x86 efi: efi reverve boot service fix

2013-10-16 Thread Dave Young
Current code check boot service region with kernel text region by: start+size >= __pa_symbol(_text) The end of the above region should be start + size - 1 instead. I see this problem in ovmf + Fedora 19 grub boot: text start: 100 md start: 80 md size: 80 Signed-off-by: Dave Young -