Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable

2014-01-13 Thread Borislav Petkov
On Mon, Jan 13, 2014 at 01:32:40PM +0800, Dave Young wrote: pr_info? This is for debug purpose, maybe pr_debug is better? I hate pr_debug as it depends on other defines I have to have defined properly in order just so I get output. How about do not limit to only if (pgd) case, instead do

Re: [PATCH 4/4] efi: Make efi virtual runtime map passing more robust

2014-01-13 Thread Borislav Petkov
On Mon, Jan 13, 2014 at 01:40:39PM +0800, Dave Young wrote: Adding a safeguard check for desc_size is better though currently it's impossible for the desc_size PAGE_SIZE? Huh, what? sizeof(efi_memory_desc_t) is only 40 bytes AFAICT. -- Regards/Gruss, Boris. Sent from a fat crate under

Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable

2014-01-13 Thread Dave Young
How about do not limit to only if (pgd) case, instead do something like below: set dump_to_dmesg as a module parameter X86_PTDUMP is not a module. Hmm, I just see the module macros in the code, since it's a bool Kconfig I think the dump_pagetables.c need a cleanup, remove the #include

Re: [PATCH 1/2] efi: Fix krealloc defect

2014-01-13 Thread Matt Fleming
On Fri, 03 Jan, at 04:08:47PM, Joe Perches wrote: krealloc should use a temporary pointer for allocations and check the temporary pointer returned against NULL too. Signed-off-by: Joe Perches j...@perches.com cc: Matthew Garrett matthew.garr...@nebula.com --- arch/x86/platform/efi/efi.c |

Re: [PATCH 2/2] efi: style neatening

2014-01-13 Thread Matt Fleming
On Fri, 03 Jan, at 04:08:48PM, Joe Perches wrote: Coalesce formats and remove spaces before tabs. Move __initdata after the variable declaration. Signed-off-by: Joe Perches j...@perches.com --- arch/x86/platform/efi/efi.c | 30 +- 1 file changed, 13

Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable

2014-01-13 Thread Borislav Petkov
On Mon, Jan 13, 2014 at 06:48:10AM -0800, Arjan van de Ven wrote: MODULE_LICENSE(GPL); MODULE_AUTHOR(Arjan van de Ven ar...@linux.intel.com); MODULE_DESCRIPTION(Kernel debugging helper that dumps pagetables); personally I consider it good form to always have this kind of information in .c

Re: [PATCH V6 3/8] Add helper function to get and convert EFI command line

2014-01-13 Thread Matt Fleming
On Fri, 10 Jan, at 08:30:12AM, Roy Franz wrote: Add an EFI stub helper function to retrieve the EFI command line using the LOADED_IMAGE_PROTOCOL, and convert it to ASCII. This function will be shared by the various EFI stub implementations. Signed-off-by: Roy Franz roy.fr...@linaro.org ---

Re: [PATCH 1/6] efi: create memory map iteration helper

2014-01-13 Thread Matt Fleming
On Fri, 10 Jan, at 05:29:05PM, Mark Salter wrote: There are a lot of places in the kernel which iterate through an EFI memory map. Most of these places use essentially the same for-loop code. This patch adds a for_each_efi_memory_desc() helper to clean up all of the existing duplicate code and

Re: [PATCH 1/4] x86, ptdump: Add the functionality to dump an arbitrary pagetable

2014-01-13 Thread Matt Fleming
On Sat, 11 Jan, at 09:49:27PM, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de With reusing the -trampoline_pgd page table for mapping EFI regions in order to use them after having switched to EFI virtual mode, it is very useful to be able to dump aforementioned page table in

Re: [PATCH 2/4] efi: Dump the EFI page table

2014-01-13 Thread Matt Fleming
On Sat, 11 Jan, at 09:49:28PM, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de This is very useful for debugging issues with the recently added pagetable switching code for EFI virtual mode. Signed-off-by: Borislav Petkov b...@suse.de --- arch/x86/platform/efi/efi.c | 11

Re: [PATCH 0/4] EFI memmap fix v2

2014-01-13 Thread Toshi Kani
On Sat, 2014-01-11 at 21:49 +0100, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de Ok, here's v2 rebased and rediffed against tip (which has the relevant efi branches). Toshi, I'm pushing it to: git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git#efi-fixes so that you

Re: [PATCH 1/6] efi: create memory map iteration helper

2014-01-13 Thread Mark Salter
On Mon, 2014-01-13 at 15:17 +, Matt Fleming wrote: On Fri, 10 Jan, at 05:29:05PM, Mark Salter wrote: There are a lot of places in the kernel which iterate through an EFI memory map. Most of these places use essentially the same for-loop code. This patch adds a for_each_efi_memory_desc()

Re: [PATCH v4 4/5] arm: Add [U]EFI runtime services support

2014-01-13 Thread Arnd Bergmann
On Saturday 11 January 2014, Leif Lindholm wrote: This patch implements basic support for UEFI runtime services in the ARM architecture - a requirement for using efibootmgr to read and update the system boot configuration. It uses the generic configuration table scanning to populate ACPI and

Re: [PATCH v4 5/5] init: efi: arm: enable (U)EFI runtime services on arm

2014-01-13 Thread Leif Lindholm
On Mon, Jan 13, 2014 at 07:29:06PM +0100, Arnd Bergmann wrote: On Saturday 11 January 2014, Leif Lindholm wrote: diff --git a/init/main.c b/init/main.c index febc511..1331829 100644 --- a/init/main.c +++ b/init/main.c @@ -905,6 +905,10 @@ static noinline void __init

Re: [PATCH v4 4/5] arm: Add [U]EFI runtime services support

2014-01-13 Thread Leif Lindholm
On Mon, Jan 13, 2014 at 07:43:09PM +0100, Arnd Bergmann wrote: This patch implements basic support for UEFI runtime services in the ARM architecture - a requirement for using efibootmgr to read and update the system boot configuration. It uses the generic configuration table scanning to

Re: [PATCH 2/4] efi: Dump the EFI page table

2014-01-13 Thread Dave Young
On 01/13/14 at 04:00pm, Matt Fleming wrote: On Sat, 11 Jan, at 09:49:28PM, Borislav Petkov wrote: From: Borislav Petkov b...@suse.de This is very useful for debugging issues with the recently added pagetable switching code for EFI virtual mode. Signed-off-by: Borislav Petkov

Re: [RFT][PATCH] ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode() (was: Re: [RFC PATCH 00/14] Support timezone of ACPI TAD and EFI TIME)

2014-01-13 Thread Toshi Kani
On Sun, 2014-01-12 at 10:06 +0100, Borislav Petkov wrote: On Sun, Jan 12, 2014 at 01:30:23AM +0100, Rafael J. Wysocki wrote: I don't see any adverse effects of the patch below on a couple of my test boxes, but (a) they are Intel-based and (b) they are non-EFI, so it would be good to give it