Re: [PATCH v7 00/10] xen: Add EFI support

2014-07-01 Thread David Vrabel
On 30/06/14 18:52, Daniel Kiper wrote: Hey, This patch series adds EFI support for Xen dom0 guests. It is based on Jan Beulich and Tang Liang work. I was trying to take into account all previous comments, however, if I missed something sorry for that. What's changed in this version? David

Re: [PATCH v7 00/10] xen: Add EFI support

2014-07-01 Thread Daniel Kiper
On Tue, Jul 01, 2014 at 02:13:10PM +0100, David Vrabel wrote: On 30/06/14 18:52, Daniel Kiper wrote: Hey, This patch series adds EFI support for Xen dom0 guests. It is based on Jan Beulich and Tang Liang work. I was trying to take into account all previous comments, however, if I

Re: [PATCH v2 0/2] efi: preserve NEON registers on UEFI services calls

2014-07-01 Thread Matt Fleming
On Thu, 26 Jun, at 12:09:04PM, Ard Biesheuvel wrote: The current UEFI implementation for arm64 fails to preserve/restore the contents of the NEON register file, which may result in data corruption, especially now that those contents are lazily restored for user processes. This series

Re: [PATCH v2 1/2] efi/x86: move UEFI Runtime Services wrappers to generic code

2014-07-01 Thread Matt Fleming
On Thu, 26 Jun, at 12:09:05PM, Ard Biesheuvel wrote: In order for other archs (such as arm64) to be able to reuse the virtual mode function call wrappers, move them to drivers/firmware/efi/runtime-wrappers.c. Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org [...] @@ -54,6 +54,13 @@

Re: [PATCH v2 1/2] efi/x86: move UEFI Runtime Services wrappers to generic code

2014-07-01 Thread Ard Biesheuvel
On 1 July 2014 15:30, Matt Fleming m...@console-pimps.org wrote: On Thu, 26 Jun, at 12:09:05PM, Ard Biesheuvel wrote: In order for other archs (such as arm64) to be able to reuse the virtual mode function call wrappers, move them to drivers/firmware/efi/runtime-wrappers.c. Signed-off-by: Ard

Re: [PATCH v2 0/2] efi: preserve NEON registers on UEFI services calls

2014-07-01 Thread Ard Biesheuvel
On 1 July 2014 15:26, Matt Fleming m...@console-pimps.org wrote: On Thu, 26 Jun, at 12:09:04PM, Ard Biesheuvel wrote: The current UEFI implementation for arm64 fails to preserve/restore the contents of the NEON register file, which may result in data corruption, especially now that those

Re: [PATCH v2 1/2] efi/x86: move UEFI Runtime Services wrappers to generic code

2014-07-01 Thread Matt Fleming
On Tue, 01 Jul, at 03:35:09PM, Ard Biesheuvel wrote: I agree, but I kind of followed the example of the Kconfig symbols in the vicinity. So sure, rip it out. Or would you like me to do a v(n+1)? Thanks. Nah, no need for another version, I'ved fixed this up in 'next', but please do check the

Re: [PATCH v2 4/5] efi: efistub: refactor stub components

2014-07-01 Thread Ard Biesheuvel
On 1 July 2014 17:11, Matt Fleming m...@console-pimps.org wrote: On Thu, 26 Jun, at 04:23:36PM, Ard Biesheuvel wrote: In order to move from the #include ../../../x.c anti-pattern used by both the x86 and arm64 versions of the stub to a static library linked into either the kernel proper

Re: [PATCH v2 0/5] efistub: convert into static library

2014-07-01 Thread Matt Fleming
On Thu, 26 Jun, at 04:23:32PM, Ard Biesheuvel wrote: This is v2 of the series to change the #include ../../../../xxx.c pattern into a static library linked into either the kernel (arm64) or a separate boot decompressor (x86, ARM). Changes since v1: - added patch #1 to change EFI_ERROR, it

Re: [PATCH v2 0/5] efistub: convert into static library

2014-07-01 Thread Matt Fleming
On Tue, 01 Jul, at 08:55:20PM, Ard Biesheuvel wrote: OK, thanks. One tiny snag that I would like to fix up once we have some Acks to add: I just noticed that i removed the 'static' from handle_kernel_image()'s definition from arm64 in 4/5, but removed it from the forward declaration in 5/5,

Re: [PATCH 15/15] kexec: Support kexec/kdump on EFI systems

2014-07-01 Thread Matt Fleming
On Thu, 26 Jun, at 04:33:44PM, Vivek Goyal wrote: This patch does two thigns. It passes EFI run time mappings to second kernel in bootparams efi_info. Second kernel parse this info and create new mappings in second kernel. That means mappings in first and second kernel will be same. This paves

[PATCH 17/15] kexec-bzimage: Change EFI helper function names

2014-07-01 Thread Vivek Goyal
Matt suggested to change helper function names newly introduced functions and prefix these with efi_. Signed-off-by: Vivek Goyal vgo...@redhat.com CC: Matt Fleming m...@console-pimps.org CC: linux-efi@vger.kernel.org --- arch/x86/kernel/kexec-bzimage64.c |4 ++--

Re: [PATCH 15/15] kexec: Support kexec/kdump on EFI systems

2014-07-01 Thread Andrew Morton
On Tue, 1 Jul 2014 20:46:05 +0100 Matt Fleming m...@console-pimps.org wrote: +int get_efi_runtime_map_size(void) +{ + return nr_efi_runtime_map * efi_memdesc_size; +} + +int get_efi_runtime_map_desc_size(void) +{ + return efi_memdesc_size; +} + +int

Re: [PATCH 15/15] kexec: Support kexec/kdump on EFI systems

2014-07-01 Thread Vivek Goyal
On Tue, Jul 01, 2014 at 01:14:19PM -0700, Andrew Morton wrote: On Tue, 1 Jul 2014 20:46:05 +0100 Matt Fleming m...@console-pimps.org wrote: +int get_efi_runtime_map_size(void) +{ + return nr_efi_runtime_map * efi_memdesc_size; +} + +int get_efi_runtime_map_desc_size(void)

Re: [PATCH 15/15] kexec: Support kexec/kdump on EFI systems

2014-07-01 Thread Matt Fleming
On Tue, 01 Jul, at 01:14:19PM, Andrew Morton wrote: This? From: Andrew Morton a...@linux-foundation.org Subject: kexec-support-kexec-kdump-on-efi-systems-fix s/get_efi/efi_get/g, per Matt Cc: Vivek Goyal vgo...@redhat.com Cc: Matt Fleming m...@console-pimps.org Signed-off-by: Andrew