Re: [PATCH v8 1/3] x86/boot: Add acpitb.c to parse acpi tables

2018-10-15 Thread Chao Fan
On Thu, Oct 11, 2018 at 12:57:08PM +0200, Borislav Petkov wrote: >On Wed, Oct 10, 2018 at 04:41:17PM +0800, Chao Fan wrote: [...] >> +#ifdef CONFIG_KEXEC >> +static bool get_acpi_rsdp(acpi_physical_address *rsdp_addr) >> +{ >> +char *args = (char *)get_cmd_line_ptr(); >> +size_t len =

Re: [PATCH v8 1/3] x86/boot: Add acpitb.c to parse acpi tables

2018-10-15 Thread Chao Fan
On Mon, Oct 15, 2018 at 04:26:09PM -0400, Masayoshi Mizuma wrote: >Hi Chao, > >Let me add some suggestions. Thanks for your review and suggestion. I will change them in next version. Thanks, Chao Fan > >On Wed, Oct 10, 2018 at 04:41:17PM +0800, Chao Fan wrote: >> There is a bug that kaslr may

Re: [PATCH v8 1/3] x86/boot: Add acpitb.c to parse acpi tables

2018-10-15 Thread Masayoshi Mizuma
Hi Chao, Let me add some suggestions. On Wed, Oct 10, 2018 at 04:41:17PM +0800, Chao Fan wrote: > There is a bug that kaslr may randomly chooses some positions > which are located in movable memory regions. This will break memory > hotplug feature and make the movable memory chosen by KASLR

Re: [PATCH] efi/libstub: Disable some warnings for x86{,_64}

2018-10-15 Thread Nick Desaulniers
On Mon, Oct 15, 2018 at 12:46 PM Nathan Chancellor wrote: > > On Mon, Oct 15, 2018 at 12:40:36PM -0700, Nick Desaulniers wrote: > > On Fri, Oct 12, 2018 at 6:06 PM Nathan Chancellor > > wrote: > > > > > > When building the kernel with Clang, some disabled warnings appear > > > because this

Re: [PATCH] efi/libstub: Disable some warnings for x86{,_64}

2018-10-15 Thread Nathan Chancellor
On Mon, Oct 15, 2018 at 12:40:36PM -0700, Nick Desaulniers wrote: > On Fri, Oct 12, 2018 at 6:06 PM Nathan Chancellor > wrote: > > > > When building the kernel with Clang, some disabled warnings appear > > because this Makefile overrides KBUILD_CFLAGS for x86{,_64}. Add them to > > this list so

Re: [PATCH] efi/libstub: Disable some warnings for x86{,_64}

2018-10-15 Thread Nick Desaulniers
On Fri, Oct 12, 2018 at 6:06 PM Nathan Chancellor wrote: > > When building the kernel with Clang, some disabled warnings appear > because this Makefile overrides KBUILD_CFLAGS for x86{,_64}. Add them to > this list so that the build is clean again. > > -Wpointer-sign was disabled for the whole