Re: [PATCH 2/2] efi/cper: Avoid possible OOB when checking generic data block

2019-01-23 Thread Borislav Petkov
On Tue, Jan 22, 2019 at 04:09:12PM +, Ross Lagerwall wrote: > When checking a generic status block, we iterate over all the generic > data blocks. The loop condition only checks that the start of the > generic data block is valid (within estatus->data_length) but not the > whole block. Because

Re: [PATCH] acpi: bgrt: parse BGRT to obtain BMP address before it gets clobbered

2019-01-23 Thread Ard Biesheuvel
On Wed, 23 Jan 2019 at 06:31, Dave Young wrote: > > Hi, > > On 01/22/19 at 04:06pm, Ard Biesheuvel wrote: > > The bitmap left in the framebuffer by the firmware is described by an > > ACPI table called "BGRT", which describes the size, pixel format and > > the address of a BMP image in memory.

Re: [PATCH v9 11/26] efi: Let architectures decide the flags that should be saved/restored

2019-01-23 Thread Julien Thierry
On 21/01/2019 15:42, Ard Biesheuvel wrote: > On Mon, 21 Jan 2019 at 16:34, Julien Thierry wrote: >> >> Currently, irqflags are saved before calling runtime services and >> checked for mismatch on return. >> >> Provide a pair of overridable macros to save and restore (if needed) the >> state