Re: [Patch v2 1/4] efi/x86: turn EFI runtime semaphore into a global lock

2019-02-12 Thread Hedi Berriche
On Tue, Feb 12, 2019 at 17:25 Hedi Berriche wrote: On Thu, Feb 07, 2019 at 17:38 Hedi Berriche wrote: On Thu, Feb 07, 2019 at 16:05 Ard Biesheuvel wrote: On Thu, 7 Feb 2019 at 05:23, Hedi Berriche wrote: Make efi_runtime_lock semaphore global so that it can be used by EFI runtime callers

Re: [Patch v2 1/4] efi/x86: turn EFI runtime semaphore into a global lock

2019-02-12 Thread Ard Biesheuvel
On Tue, 12 Feb 2019 at 18:25, Hedi Berriche wrote: > > On Thu, Feb 07, 2019 at 17:38 Hedi Berriche wrote: > >On Thu, Feb 07, 2019 at 16:05 Ard Biesheuvel wrote: > >>On Thu, 7 Feb 2019 at 05:23, Hedi Berriche wrote: > >>> > >>>Make efi_runtime_lock semaphore global so that it can be used by EFI >

Re: [Patch v2 1/4] efi/x86: turn EFI runtime semaphore into a global lock

2019-02-12 Thread Hedi Berriche
On Thu, Feb 07, 2019 at 17:38 Hedi Berriche wrote: On Thu, Feb 07, 2019 at 16:05 Ard Biesheuvel wrote: On Thu, 7 Feb 2019 at 05:23, Hedi Berriche wrote: Make efi_runtime_lock semaphore global so that it can be used by EFI runtime callers that may be defined outside efi/runtime-wrappers.c.

[PATCH v2 2/2] efi: fix build error redeclaration of enumerator

2019-02-12 Thread Anders Roxell
Commit a893ea15d764 ("tpm: move tpm_chip definition to include/linux/tpm.h") introduced a build error when both ima and efi is enabled. What happens is that both headers (ima.h and efi.h) defines the same 'NONE' constant, and it broke when they started getting included from the same file. In file

[PATCH v2 1/2] ima: fix build error redeclaration of enumerator

2019-02-12 Thread Anders Roxell
Commit a893ea15d764 ("tpm: move tpm_chip definition to include/linux/tpm.h") introduced a build error when both ima and efi is enabled. What happens is that both headers (ima.h and efi.h) defines the same 'NONE' constant, and it broke when they started getting included from the same file. In file

Re: [PATCH 1/2] ima: fix build error redeclaration of enumerator

2019-02-12 Thread Anders Roxell
On Tue, 12 Feb 2019 at 11:23, Andy Shevchenko wrote: > > On Tue, Feb 12, 2019 at 12:21 PM Andy Shevchenko > wrote: > > > > On Tue, Feb 12, 2019 at 12:15 PM Anders Roxell > > wrote: > > > > > > Commit a893ea15d764 ("tpm: move tpm_chip definition to > > > include/linux/tpm.h") introduced a build

Re: [PATCH 1/2] ima: fix build error redeclaration of enumerator

2019-02-12 Thread Andy Shevchenko
On Tue, Feb 12, 2019 at 12:21 PM Andy Shevchenko wrote: > > On Tue, Feb 12, 2019 at 12:15 PM Anders Roxell > wrote: > > > > Commit a893ea15d764 ("tpm: move tpm_chip definition to > > include/linux/tpm.h") introduced a build error when both ima and efi is > > enabled. What happens is that both

Re: [PATCH 1/2] ima: fix build error redeclaration of enumerator

2019-02-12 Thread Andy Shevchenko
On Tue, Feb 12, 2019 at 12:15 PM Anders Roxell wrote: > > Commit a893ea15d764 ("tpm: move tpm_chip definition to > include/linux/tpm.h") introduced a build error when both ima and efi is > enabled. What happens is that both headers (ima.h and efi.h) defines the > same 'NONE' constant, and it

Re: [PATCH 2/2] efi: fix build error redeclaration of enumerator

2019-02-12 Thread Andy Shevchenko
On Tue, Feb 12, 2019 at 12:16 PM Ard Biesheuvel wrote: > On Tue, 12 Feb 2019 at 11:09, Anders Roxell wrote: > > > > Commit a893ea15d764 ("tpm: move tpm_chip definition to > > include/linux/tpm.h") introduced a build error when both ima and efi is > > enabled. What happens is that both headers

Re: [PATCH 2/2] efi: fix build error redeclaration of enumerator

2019-02-12 Thread Ard Biesheuvel
On Tue, 12 Feb 2019 at 11:09, Anders Roxell wrote: > > Commit a893ea15d764 ("tpm: move tpm_chip definition to > include/linux/tpm.h") introduced a build error when both ima and efi is > enabled. What happens is that both headers (ima.h and efi.h) defines the > same 'NONE' constant, and it broke

[PATCH 2/2] efi: fix build error redeclaration of enumerator

2019-02-12 Thread Anders Roxell
Commit a893ea15d764 ("tpm: move tpm_chip definition to include/linux/tpm.h") introduced a build error when both ima and efi is enabled. What happens is that both headers (ima.h and efi.h) defines the same 'NONE' constant, and it broke when they started getting included from the same file. In file

[PATCH 1/2] ima: fix build error redeclaration of enumerator

2019-02-12 Thread Anders Roxell
Commit a893ea15d764 ("tpm: move tpm_chip definition to include/linux/tpm.h") introduced a build error when both ima and efi is enabled. What happens is that both headers (ima.h and efi.h) defines the same 'NONE' constant, and it broke when they started getting included from the same file. In file