Re: [PATCH] efi/libstub: refactor cmd_stubcopy

2019-02-14 Thread Masahiro Yamada
On Tue, Feb 12, 2019 at 4:26 PM Ard Biesheuvel wrote: > > On Tue, 12 Feb 2019 at 04:45, Masahiro Yamada > wrote: > > > > It took me a while to understand what is going on in the nested > > if-blocks. > > > > Simplify it by removing unneeded code. > > > > - if_changed automatically adds 'set

Re: [PATCH v3 1/2] ima: fix build error redeclaration of enumerator

2019-02-14 Thread Mimi Zohar
On Thu, 2019-02-14 at 12:28 -0500, Mimi Zohar wrote: > On Wed, 2019-02-13 at 23:16 +0100, Anders Roxell wrote: > > Commit a893ea15d764 ("tpm: move tpm_chip definition to > > include/linux/tpm.h") introduced a build error when both ima and efi is > > enabled. What happens is that both headers

Re: [Patch v3 0/4] Protect against concurrent calls into UV BIOS

2019-02-14 Thread Mike Travis
On 2/14/2019 1:21 PM, Dimitri Sivanich wrote: For the series: Reviewed-by: Dimitri Sivanich As well as I: Reviewed-by: Mike Travis On Wed, Feb 13, 2019 at 07:34:09PM +, Hedi Berriche wrote: - Changes since v2 Addressed comments from Ard Biesheuvel: * expose efi_runtime_lock

Re: [Patch v3 0/4] Protect against concurrent calls into UV BIOS

2019-02-14 Thread Dimitri Sivanich
For the series: Reviewed-by: Dimitri Sivanich On Wed, Feb 13, 2019 at 07:34:09PM +, Hedi Berriche wrote: > - Changes since v2 > Addressed comments from Ard Biesheuvel: > * expose efi_runtime_lock to UV platform only instead of globally > * remove unnecessary #ifdef CONFIG_EFI from

Re: [Patch v3 0/4] Protect against concurrent calls into UV BIOS

2019-02-14 Thread Russ Anderson
On Thu, Feb 14, 2019 at 09:17:37AM +0100, Ard Biesheuvel wrote: > On Wed, 13 Feb 2019 at 20:34, Hedi Berriche wrote: > > > > - Changes since v2 > > Addressed comments from Ard Biesheuvel: > > * expose efi_runtime_lock to UV platform only instead of globally > > * remove unnecessary #ifdef

Re: [PATCH v3 1/2] ima: fix build error redeclaration of enumerator

2019-02-14 Thread Mimi Zohar
On Wed, 2019-02-13 at 23:16 +0100, Anders Roxell wrote: > Commit a893ea15d764 ("tpm: move tpm_chip definition to > include/linux/tpm.h") introduced a build error when both ima and efi is > enabled. What happens is that both headers (ima.h and efi.h) defines the > same 'NONE' constant, and it broke

Re: [PATCH 1/2] arm64: account for GICv3 LPI tables in static memblock reserve table

2019-02-14 Thread Ard Biesheuvel
On Thu, 14 Feb 2019 at 16:48, Marc Zyngier wrote: > > Hi Ard, > > On 13/02/2019 13:27, Ard Biesheuvel wrote: > > In the irqchip and EFI code, we have what basically amounts to a quirk > > to work around a peculiarity in the GICv3 architecture, which permits > > the system memory address of LPI

Re: [PATCH 1/2] arm64: account for GICv3 LPI tables in static memblock reserve table

2019-02-14 Thread Marc Zyngier
Hi Ard, On 13/02/2019 13:27, Ard Biesheuvel wrote: > In the irqchip and EFI code, we have what basically amounts to a quirk > to work around a peculiarity in the GICv3 architecture, which permits > the system memory address of LPI tables to be programmable only once > after a CPU reset. This

Re: [PATCH 1/2] arm64: account for GICv3 LPI tables in static memblock reserve table

2019-02-14 Thread Mike Rapoport
On Thu, Feb 14, 2019 at 03:57:35PM +0100, Ard Biesheuvel wrote: > On Thu, 14 Feb 2019 at 09:34, Mike Rapoport wrote: > > > > On Wed, Feb 13, 2019 at 02:27:37PM +0100, Ard Biesheuvel wrote: > > > In the irqchip and EFI code, we have what basically amounts to a quirk > > > to work around a

Re: [PATCH 1/2] arm64: account for GICv3 LPI tables in static memblock reserve table

2019-02-14 Thread Ard Biesheuvel
On Thu, 14 Feb 2019 at 09:34, Mike Rapoport wrote: > > On Wed, Feb 13, 2019 at 02:27:37PM +0100, Ard Biesheuvel wrote: > > In the irqchip and EFI code, we have what basically amounts to a quirk > > to work around a peculiarity in the GICv3 architecture, which permits > > the system memory address

Re: [PATCH 1/2] arm64: account for GICv3 LPI tables in static memblock reserve table

2019-02-14 Thread Will Deacon
On Wed, Feb 13, 2019 at 02:27:37PM +0100, Ard Biesheuvel wrote: > In the irqchip and EFI code, we have what basically amounts to a quirk > to work around a peculiarity in the GICv3 architecture, which permits > the system memory address of LPI tables to be programmable only once > after a CPU

Re: [PATCH 1/2] arm64: account for GICv3 LPI tables in static memblock reserve table

2019-02-14 Thread Mike Rapoport
On Wed, Feb 13, 2019 at 02:27:37PM +0100, Ard Biesheuvel wrote: > In the irqchip and EFI code, we have what basically amounts to a quirk > to work around a peculiarity in the GICv3 architecture, which permits > the system memory address of LPI tables to be programmable only once > after a CPU

Re: [Patch v3 0/4] Protect against concurrent calls into UV BIOS

2019-02-14 Thread Ard Biesheuvel
On Wed, 13 Feb 2019 at 20:34, Hedi Berriche wrote: > > - Changes since v2 > Addressed comments from Ard Biesheuvel: > * expose efi_runtime_lock to UV platform only instead of globally > * remove unnecessary #ifdef CONFIG_EFI from bios_uv.c > > - Changes since v1: > Addressed comments from