Re: [PATCH] TCG2 log support build fixes for non-x86_64

2019-04-04 Thread Matthew Garrett
On Thu, Apr 4, 2019 at 5:41 AM Jarkko Sakkinen wrote: > > On Tue, Apr 02, 2019 at 02:55:54PM -0700, Matthew Garrett wrote: > > Couple of patches to fix ktest reported issues with the crypto-agile log > > format support. > > I guess I squash these to your earlier commits? Works for me.

Re: [PATCH 1/2] efi: Fix cast to pointer from integer of different size in TPM log code

2019-04-04 Thread Matthew Garrett
On Thu, Apr 4, 2019 at 5:54 AM Ard Biesheuvel wrote: > > On Wed, 3 Apr 2019 at 04:56, Matthew Garrett > wrote: > > > > 8bfcff4a6a1d9d7226bb63a7da758b82d9ab4373 > > Which tree is this commit in? Sorry, these are in the tpmdd-next tree.

Re: [PATCH] efi: Check the number of EFI configuration tables entries

2019-04-04 Thread Ard Biesheuvel
On Thu, 4 Apr 2019 at 18:24, Rob Bradford wrote: > > Only try and access the EFI configuration tables if there there are any > reported. This allows EFI to be continued to used on systems where there > are no configuration table entries. > > Signed-off-by: Rob Bradford > --- >

Re: [PATCH 1/2] efi: Fix cast to pointer from integer of different size in TPM log code

2019-04-04 Thread Ard Biesheuvel
On Wed, 3 Apr 2019 at 04:56, Matthew Garrett wrote: > > 8bfcff4a6a1d9d7226bb63a7da758b82d9ab4373 Which tree is this commit in? > introduced a cast from > efi_physical_address_t to (void *), which are different sizes on 32-bit. > Fix that. Caught by the 0-day test bot. > > Signed-off-by: Matthew

Re: [PATCH] efi: Include tpm_eventlog.h after asm/efi.h to avoid memcpy breakage

2019-04-04 Thread Ard Biesheuvel
On Wed, 3 Apr 2019 at 21:32, Matthew Garrett wrote: > > 769a8089c1fd2 (x86, efi, kasan: #undef memset/memcpy/memmove per arch) > disables the KASAN version of certain memory calls in the EFI boot stub. > tpm_eventlog.h references memcpy, so must be included after asm/efi.h in > order to allow

Re: [PATCH] efi: Include tpm_eventlog.h after asm/efi.h to avoid memcpy breakage

2019-04-04 Thread Jarkko Sakkinen
On Wed, Apr 03, 2019 at 12:32:37PM -0700, Matthew Garrett wrote: > 769a8089c1fd2 (x86, efi, kasan: #undef memset/memcpy/memmove per arch) > disables the KASAN version of certain memory calls in the EFI boot stub. > tpm_eventlog.h references memcpy, so must be included after asm/efi.h in > order to

Re: [PATCH] TCG2 log support build fixes for non-x86_64

2019-04-04 Thread Jarkko Sakkinen
On Tue, Apr 02, 2019 at 02:55:54PM -0700, Matthew Garrett wrote: > Couple of patches to fix ktest reported issues with the crypto-agile log > format support. I guess I squash these to your earlier commits? /Jarkko

Re: [PATCH 2/2] tpm: Fix builds on platforms that lack early_memremap()

2019-04-04 Thread Jarkko Sakkinen
On Tue, Apr 02, 2019 at 02:55:56PM -0700, Matthew Garrett wrote: > On EFI systems, __calc_tpm2_event_size() needs to be able to map tables > at early boot time in order to extract information from them. > Unfortunately this interacts badly with other architectures that don't > provide the

Re: [PATCH 1/2] efi: Fix cast to pointer from integer of different size in TPM log code

2019-04-04 Thread Jarkko Sakkinen
On Tue, Apr 02, 2019 at 02:55:55PM -0700, Matthew Garrett wrote: > 8bfcff4a6a1d9d7226bb63a7da758b82d9ab4373 introduced a cast from > efi_physical_address_t to (void *), which are different sizes on 32-bit. > Fix that. Caught by the 0-day test bot. > > Signed-off-by: Matthew Garrett Reviewed-by:

[PATCH] efi: Check the number of EFI configuration tables entries

2019-04-04 Thread Rob Bradford
Only try and access the EFI configuration tables if there there are any reported. This allows EFI to be continued to used on systems where there are no configuration table entries. Signed-off-by: Rob Bradford --- arch/x86/platform/efi/quirks.c | 3 +++ drivers/firmware/efi/efi.c | 3 +++ 2

[PATCH 4.9 67/91] efi/memattr: Dont bail on zero VA if it equals the regions PA

2019-04-04 Thread Greg Kroah-Hartman
4.9-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 5de0fef0230f3c8d75cff450a71740a7bf2db866 ] The EFI memory attributes code cross-references the EFI memory map with the more granular EFI memory attributes table to ensure that they

[PATCH 4.14 087/121] efi/memattr: Dont bail on zero VA if it equals the regions PA

2019-04-04 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 5de0fef0230f3c8d75cff450a71740a7bf2db866 ] The EFI memory attributes code cross-references the EFI memory map with the more granular EFI memory attributes table to ensure that they

[PATCH 4.14 089/121] efi/arm/arm64: Allow SetVirtualAddressMap() to be omitted

2019-04-04 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 4e46c2a956215482418d7b315749fb1b6c6bc224 ] The UEFI spec revision 2.7 errata A section 8.4 has the following to say about the virtual memory runtime services: "This section

[PATCH 4.19 137/187] efi/arm/arm64: Allow SetVirtualAddressMap() to be omitted

2019-04-04 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 4e46c2a956215482418d7b315749fb1b6c6bc224 ] The UEFI spec revision 2.7 errata A section 8.4 has the following to say about the virtual memory runtime services: "This section

[PATCH 5.0 126/246] efi: Fix build error due to enum collision between efi.h and ima.h

2019-04-04 Thread Greg Kroah-Hartman
5.0-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 5c418dc789a3898717ebf2caa5716ba91a7150b2 ] The following commit: a893ea15d764 ("tpm: move tpm_chip definition to include/linux/tpm.h") introduced a build error when both IMA and

[PATCH 5.0 175/246] efi/memattr: Dont bail on zero VA if it equals the regions PA

2019-04-04 Thread Greg Kroah-Hartman
5.0-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 5de0fef0230f3c8d75cff450a71740a7bf2db866 ] The EFI memory attributes code cross-references the EFI memory map with the more granular EFI memory attributes table to ensure that they

[PATCH 5.0 180/246] efi/arm/arm64: Allow SetVirtualAddressMap() to be omitted

2019-04-04 Thread Greg Kroah-Hartman
5.0-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 4e46c2a956215482418d7b315749fb1b6c6bc224 ] The UEFI spec revision 2.7 errata A section 8.4 has the following to say about the virtual memory runtime services: "This section

[PATCH 4.19 133/187] efi/memattr: Dont bail on zero VA if it equals the regions PA

2019-04-04 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 5de0fef0230f3c8d75cff450a71740a7bf2db866 ] The EFI memory attributes code cross-references the EFI memory map with the more granular EFI memory attributes table to ensure that they