Re: [PATCH 00/18] xfrm: Add compat layer

2018-07-30 Thread Florian Westphal
Dmitry Safonov wrote: > On Sat, 2018-07-28 at 14:18 -0700, David Miller wrote: > > From: Dmitry Safonov > > Date: Sat, 28 Jul 2018 17:26:55 +0100 > > > > > Well, I think, I'll rework my patches set according to critics and > > > separate compat xfrm layer. I've already a selftest to check that

Re: [PATCH 00/18] xfrm: Add compat layer

2018-07-27 Thread Florian Westphal
Dmitry Safonov wrote: > 1. It will double copy netlink messages, making it O(n) instead of > O(1), where n - is number of bind()s.. Probably we don't care much. About those bind() patches, I don't understand why they are needed. Why can't you just add the compat skb to the native skb when doing

Re: [PATCH 00/18] xfrm: Add compat layer

2018-07-26 Thread Florian Westphal
Dmitry Safonov wrote: > So, here I add a compatible layer to xfrm. > As xfrm uses netlink notifications, kernel should send them in ABI > format that an application will parse. The proposed solution is > to save the ABI of bind() syscall. The realization detail is > to create kernel-hidden, non