Re: [PATCH] arm64/efi: fix variable 'si' set but not used

2019-07-31 Thread Will Deacon
as 'hidden' so the compiler will generate relative references */ > extern struct screen_info screen_info > __attribute__((__visibility__("hidden"))); > -- > 1.8.3.1 Acked-by: Will Deacon Will

Re: "arm64: Silence gcc warnings about arch ABI drift" breaks clang

2019-06-07 Thread Will Deacon
On Fri, Jun 07, 2019 at 08:40:10AM -0700, Nathan Chancellor wrote: > On Fri, Jun 07, 2019 at 11:26:11AM -0400, Qian Cai wrote: > > On Fri, 2019-06-07 at 16:25 +0100, Will Deacon wrote: > > > On Fri, Jun 07, 2019 at 11:22:45AM -0400, Qian Cai wrote: > > > > The linux-n

Re: "arm64: Silence gcc warnings about arch ABI drift" breaks clang

2019-06-07 Thread Will Deacon
On Fri, Jun 07, 2019 at 11:22:45AM -0400, Qian Cai wrote: > The linux-next commit "arm64: Silence gcc warnings about arch ABI drift" [1] > breaks clang build where it screams that unknown option "-Wno-psabi" and > generates errors below, So that can be easily fixed with cc-option... > [1] >

Re: [PATCH 1/2] arm64: account for GICv3 LPI tables in static memblock reserve table

2019-02-14 Thread Will Deacon
rced to reuse the same memory after kexec (and thus > + * reserve it persistently with EFI beforehand) > + */ > +#if defined(CONFIG_EFI) && defined(CONFIG_ARM_GIC_V3_ITS) > +#define INIT_MEMBLOCK_RESERVED_REGIONS (INIT_MEMBLOCK_REGIONS + 2 * > NR_CPUS) > +#endif Assuming this "ought to be enough for anybody", then: Acked-by: Will Deacon Will

Re: [PATCH] efi/arm: Don't expect a return value of ptdump_debugfs_register

2019-02-04 Thread Will Deacon
On Fri, Feb 01, 2019 at 11:18:22PM +0100, Ard Biesheuvel wrote: > On Fri, 1 Feb 2019 at 20:21, Nathan Chancellor > wrote: > > > > As of commit e2a2e56e4082 ("arm64: dump: no need to check return value > > of debugfs_create functions") in the arm64 for-next/core branch, > >

Re: [PATCH] efi: arm/arm64: allow SetVirtualAddressMap() to be omitted

2019-01-30 Thread Will Deacon
Hi Ard, On Sat, Jan 26, 2019 at 11:22:07AM +0100, Ard Biesheuvel wrote: > The UEFI spec revision 2.7 errata A section 8.4 has the following to > say about the virtual memory runtime services: > > "This section contains function definitions for the virtual memory > support that may be

Re: [PATCH 0/4] arm/efi: fix memblock reallocation crash due to persistent reservations

2018-11-06 Thread Will Deacon
On Tue, Nov 06, 2018 at 10:39:47PM +0100, Ard Biesheuvel wrote: > On 6 November 2018 at 22:34, Will Deacon wrote: > > On Tue, Nov 06, 2018 at 12:37:28PM +0100, Ard Biesheuvel wrote: > >> This series addresses the kexec/kdump crash on arm64 system with many CPUs > >> t

Re: [PATCH 0/4] arm/efi: fix memblock reallocation crash due to persistent reservations

2018-11-06 Thread Will Deacon
tent memreserve infrastructure so that fewer memblock reservations > are required. I acked the arm64 part and patches 3 and 4 look good afaict, so: Acked-by: Will Deacon for those as well. The only thing I was wondering is whether or not exhausting the page-sized array in the first list entry is rare en

Re: [PATCH 1/4] arm64: memblock: don't permit memblock resizing until linear mapping is up

2018-11-06 Thread Will Deacon
erring to > call to memblock_allow_resize() to after the linear mapping has been > created. > > Reported-by: Bhupesh Sharma > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/mm/init.c | 2 -- > arch/arm64/mm/mmu.c | 2 ++ > 2 files changed, 2 insertions(+), 2 deletions(

Re: [Bug Report] kdump crashes after latest EFI memblock changes on arm64 machines with large number of CPUs

2018-11-05 Thread Will Deacon
On Fri, Nov 02, 2018 at 02:44:10AM +0530, Bhupesh Sharma wrote: > With the latest EFI changes for memblock reservation across kdump > kernel from Ard (Commit 71e0940d52e107748b270213a01d3b1546657d74 > ["efi: honour memory reservations passed via a linux specific config > table"]), we hit a panic

Re: [PATCH 0/8] add generic builtin command line

2018-10-29 Thread Will Deacon
On Wed, Oct 24, 2018 at 10:07:32AM +0100, Russell King - ARM Linux wrote: > On Wed, Oct 24, 2018 at 11:57:44AM +0300, Maksym Kokhan wrote: > > Do you mean, that you haven't seen patch for ARM, which I sent on > > September 27 along with cover and patch 1? It is strange, because > > you was the one

Re: [RFC PATCH 0/2] efi: add contents of LinuxExtraArgs EFI var to command line

2018-07-13 Thread Will Deacon
On Fri, Jul 13, 2018 at 08:15:26AM +0200, Ard Biesheuvel wrote: > On 13 July 2018 at 00:22, Geoff Levand wrote: > > Hi Ard, > > > > On 07/04/2018 08:49 AM, Ard Biesheuvel wrote: > >> efi/libstub: taken contents of LinuxExtraArgs UEFI variable into > >> account > > > > To me this seems an

Re: [RFC PATCH 0/2] efi: add contents of LinuxExtraArgs EFI var to command line

2018-07-12 Thread Will Deacon
Hi Ard, On Wed, Jul 04, 2018 at 05:49:17PM +0200, Ard Biesheuvel wrote: > As noted by Ian, many DMI based quirks for x86 ACPI machines disable > features that can also be disabled via the kernel command line. Similarly, > a quirk is under discussion for a arm64 ACPI machine [0] that explodes >

Re: [PATCH 4/4] efi/arm64: unmap the kernel while executing UEFI services

2018-01-26 Thread Will Deacon
On Fri, Jan 26, 2018 at 05:06:42PM +, Ard Biesheuvel wrote: > On 26 January 2018 at 17:05, Will Deacon <will.dea...@arm.com> wrote: > > On Thu, Jan 25, 2018 at 10:31:31AM +, Ard Biesheuvel wrote: > >> Now that all UEFI runtime service wrappers ensure that byref

Re: [PATCH 2/4] efi/arm64: map the stack and entry wrapper into the UEFI page tables

2018-01-26 Thread Will Deacon
On Fri, Jan 26, 2018 at 05:03:29PM +, Ard Biesheuvel wrote: > On 26 January 2018 at 16:57, Will Deacon <will.dea...@arm.com> wrote: > > On Thu, Jan 25, 2018 at 10:31:29AM +, Ard Biesheuvel wrote: > >> As a preparatory step towards unmapping the kernel entirely w

Re: [PATCH 4/4] efi/arm64: unmap the kernel while executing UEFI services

2018-01-26 Thread Will Deacon
On Thu, Jan 25, 2018 at 10:31:31AM +, Ard Biesheuvel wrote: > Now that all UEFI runtime service wrappers ensure that byref > arguments are moved into the UEFI marshalling buffer (which > is not part of the kernel mapping), we can proceed and unmap > the kernel while UEFI runtime service calls

Re: [PATCH 2/4] efi/arm64: map the stack and entry wrapper into the UEFI page tables

2018-01-26 Thread Will Deacon
Hi Ard, On Thu, Jan 25, 2018 at 10:31:29AM +, Ard Biesheuvel wrote: > As a preparatory step towards unmapping the kernel entirely while > executing UEFI runtime services, move the stack and the entry > wrapper routine mappings into the EFI page tables. Also, create a > vector table that

Re: [PATCH 1/4] efi: arm64: Check whether x18 is preserved by runtime services calls

2018-01-26 Thread Will Deacon
> 4 files changed, 52 insertions(+), 2 deletions(-) Looks good to me: Acked-by: Will Deacon <will.dea...@arm.com> Will > diff --git a/arch/arm64/include/asm/efi.h b/arch/arm64/include/asm/efi.h > index 8389050328bb..192d791f1103 100644 > --- a/arch/arm64/include/asm/efi.h > +

Re: [PATCH] efi/arm*: Only register page tables when they exist

2018-01-17 Thread Will Deacon
to dump the efi page > tables results in a NULL pointer dereference in the ptdump code: Acked-by: Will Deacon <will.dea...@arm.com> Ard -- please can you pick this one up? Cheers, Will -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a me

Re: [PATCH v4 2/2] arm64: Add software workaround for Falkor erratum 1041

2017-12-01 Thread Will Deacon
On Mon, Nov 27, 2017 at 05:18:00PM -0600, Shanker Donthineni wrote: > The ARM architecture defines the memory locations that are permitted > to be accessed as the result of a speculative instruction fetch from > an exception level for which all stages of translation are disabled. > Specifically,

Re: [PATCH] efi/libstub: arm: omit sorting of the UEFI memory map

2017-10-24 Thread Will Deacon
M64, ARM64 folk should ack > > this before I merge it - can I have an ack from that side please? > > > > Note that the patch does not touch arch/arm64, nor does it affect > arm64, given that the change is a no-op if CONFIG_ARM64=y. That said, > I welcome any acks from the ar

Re: [PATCH 3/3] x86/efi: Use efi_switch_mm() rather than manually twiddling with cr3

2017-08-16 Thread Will Deacon
On Wed, Aug 16, 2017 at 10:53:38AM +0100, Mark Rutland wrote: > On Wed, Aug 16, 2017 at 10:31:12AM +0100, Ard Biesheuvel wrote: > > (+ Mark, Will) > > > > On 15 August 2017 at 22:46, Andy Lutomirski wrote: > > > On Tue, Aug 15, 2017 at 12:18 PM, Sai Praneeth Prakhya > > >

Re: [PATCH V17 00/11] Add UEFI 2.6 and ACPI 6.1 updates for RAS on ARM64

2017-06-20 Thread Will Deacon
Hi Robert, On Tue, Jun 20, 2017 at 08:34:39AM +0200, Robert Richter wrote: > On 07.06.17 12:50:12, Will Deacon wrote: > > > Thanks, I've pushed this out as: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git > > for-next/ras-apei > > >

Re: [PATCH V17 00/11] Add UEFI 2.6 and ACPI 6.1 updates for RAS on ARM64

2017-06-07 Thread Will Deacon
On Fri, May 19, 2017 at 02:32:02PM -0600, Tyler Baicar wrote: > When a memory error, CPU error, PCIe error, or other type of hardware error > that's covered by RAS occurs, firmware should populate the shared GHES memory > location with the proper GHES structures to notify the OS of the error. >

Re: [PATCH V17 02/11] ras: acpi/apei: cper: add support for generic data v3 structure

2017-06-02 Thread Will Deacon
On Fri, May 19, 2017 at 02:32:04PM -0600, Tyler Baicar wrote: > The ACPI 6.1 spec adds a new revision of the generic error data > entry structure. Add support to handle the new structure as well > as properly verify and iterate through the generic data entries. > > Signed-off-by: Tyler Baicar

Re: [PATCH] efi: stub: define DISABLE_BRANCH_PROFILING for all architectures

2016-01-05 Thread Will Deacon
On Tue, Jan 05, 2016 at 03:39:18PM +, Matt Fleming wrote: > On Tue, 05 Jan, at 03:56:39PM, Ard Biesheuvel wrote: > > (+ Arnd) > > > > On 4 January 2016 at 13:31, Will Deacon <will.dea...@arm.com> wrote: > > > On Wed, Dec 23, 2015 at 10:29:28AM +0100, Ard

Re: [PATCH] efi: stub: define DISABLE_BRANCH_PROFILING for all architectures

2016-01-04 Thread Will Deacon
> Reported-by: Will Deacon <will.dea...@arm.com> > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > drivers/firmware/efi/libstub/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Cheers, Ard. The kernel now builds and boots as an EFI appl

Re: [PATCH v4 01/13] mm/memblock: add MEMBLOCK_NOMAP attribute to memblock memory table

2015-12-09 Thread Will Deacon
On Tue, Dec 08, 2015 at 02:23:41PM -0800, Andrew Morton wrote: > On Tue, 8 Dec 2015 12:07:44 + Will Deacon <will.dea...@arm.com> wrote: > > > > I should note that this change should not affect any memblock users > > > that never set the MEMBLOCK_NOMAP fl

Re: [PATCH v4 01/13] mm/memblock: add MEMBLOCK_NOMAP attribute to memblock memory table

2015-12-08 Thread Will Deacon
Hi Ard, On Thu, Dec 03, 2015 at 11:55:53AM +0100, Ard Biesheuvel wrote: > On 30 November 2015 at 13:28, Ard Biesheuvel > wrote: > > This introduces the MEMBLOCK_NOMAP attribute and the required plumbing > > to make it usable as an indicator that some parts of normal

Re: [PATCH v4 00/13] UEFI boot and runtime services support for 32-bit ARM

2015-12-03 Thread Will Deacon
er > side confined to the respective maintainer tree, rather then propagating all > the > way to -next. For the arm64 bits (patches 2-5): Acked-by: Will Deacon <will.dea...@arm.com> I'd really like an ack from the mm crowd on patch 1 before I queue it. Will -- To unsubscribe from this lis

Re: [PATCH v3 0/6] arm64 UEFI early FDT handling

2015-11-16 Thread Will Deacon
Hi Ard, On Tue, Sep 29, 2015 at 08:38:57AM +0100, Ard Biesheuvel wrote: > (+ Grant) > > On 22 September 2015 at 02:21, Ard Biesheuvel > wrote: > > This is a followup to the "arm64: update/clarify/relax Image and FDT > > placement > > rules" series I sent a while

Re: [PATCH] arm64: efi: make sure vmlinux load address aligned on 2MBytes

2015-10-28 Thread Will Deacon
On Wed, Oct 28, 2015 at 12:11:57PM -0500, Timur Tabi wrote: > On 10/27/2015 09:06 PM, Ard Biesheuvel wrote: > >diff --git a/arch/arm64/kernel/efi-stub.c b/arch/arm64/kernel/efi-stub.c > >index 816120ece6bc..a60ce249cfc0 100644 > >--- a/arch/arm64/kernel/efi-stub.c > >+++

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-09 Thread Will Deacon
On Fri, Oct 09, 2015 at 12:40:21PM +0300, Andrey Ryabinin wrote: > 2015-10-09 12:10 GMT+03:00 Will Deacon <will.dea...@arm.com>: > > On Fri, Oct 09, 2015 at 11:12:24AM +0300, Andrey Ryabinin wrote: > >> 2015-10-08 22:02 GMT+03:00 Ard Biesheuvel <ard.biesheu...@linaro.or

Re: [RFC PATCH] arm64/efi: isolate EFI stub from the kernel proper

2015-09-17 Thread Will Deacon
Hi Ard, On Thu, Sep 17, 2015 at 11:51:07AM +0100, Ard Biesheuvel wrote: > On 15 September 2015 at 17:24, Ard Biesheuvel <ard.biesheu...@linaro.org> > wrote: > > On 15 September 2015 at 16:46, Will Deacon <will.dea...@arm.com> wrote: > >> On Tue, Sep 15, 2015 at

Re: [PATCH v2] arm64/efi: base UEFI mapping permissions on region attributes

2015-08-27 Thread Will Deacon
Hi Ard, On Wed, Aug 26, 2015 at 02:30:02PM +0100, Ard Biesheuvel wrote: Currently, we infer the UEFI memory region mapping permissions from the memory region type (i.e., runtime services code are mapped RWX and runtime services data mapped RW-). This appears to work fine but is not entirely

Re: [PATCH 2/2] acpi, apei: use appropriate pgprot_t to map GHES memory

2015-08-13 Thread Will Deacon
On Thu, Aug 13, 2015 at 10:24:32AM +0100, Matt Fleming wrote: On Thu, 13 Aug, at 10:19:17AM, Ingo Molnar wrote: * Matt Fleming m...@codeblueprint.co.uk wrote: From: Jonathan (Zhixiong) Zhang zjzh...@codeaurora.org With ACPI APEI firmware first handling, generic hardware error

Re: [PATCH V9 0/5] map GHES memory region according to EFI memory map

2015-08-03 Thread Will Deacon
Hi Jonathan, On Thu, Jul 30, 2015 at 10:35:04PM +0100, Jonathan (Zhixiong) Zhang wrote: From: Jonathan (Zhixiong) Zhang zjzh...@codeaurora.org On a platform with APEI (ACPI Platform Error Interface) enabled, firmware updates a memory region with hardware error record using nocache

Re: [PATCH v2] arm64/efi: prefer AllocatePages() over efi_low_alloc() for vmlinux

2015-07-29 Thread Will Deacon
On Tue, Jul 28, 2015 at 10:24:23PM +0100, Ard Biesheuvel wrote: On 28 July 2015 at 23:17, Matt Fleming m...@codeblueprint.co.uk wrote: On Fri, 24 Jul, at 01:38:27PM, Ard Biesheuvel wrote: When allocating memory for the kernel image, try the AllocatePages() boot service to obtain memory at

Re: [PATCH 1/8] arm64/efi: use UEFI memory map unconditionally if available

2015-01-09 Thread Will Deacon
() results in a broken boot, so it is better to just call it unconditionally. Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org --- arch/arm64/kernel/efi.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) Acked-by: Will Deacon will.dea...@arm.com Will diff --git a/arch

Re: [PATCH 7/8] arm64: use 'physmem' memblock to improve CONFIG_STRICT_DEVMEM handling

2015-01-09 Thread Will Deacon
is ok: Acked-by: Will Deacon will.dea...@arm.com Will Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org --- arch/arm64/Kconfig | 1 + arch/arm64/mm/mmap.c | 2 +- arch/arm64/mm/mmu.c | 15 ++- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/arch/arm64

Re: [PATCH v5 8/8] arm64/efi: remove idmap manipulations from UEFI code

2015-01-09 Thread Will Deacon
files changed, 1 insertion(+), 48 deletions(-) Looks like a good cleanup! Acked-by: Will Deacon will.dea...@arm.com Will diff --git a/arch/arm64/include/asm/efi.h b/arch/arm64/include/asm/efi.h index effef3713c5a..7baf2cc04e1e 100644 --- a/arch/arm64/include/asm/efi.h +++ b/arch/arm64/include

Re: [PATCH v5 7/8] arm64/efi: remove free_boot_services() and friends

2015-01-09 Thread Will Deacon
the back of this function, thanks. Acked-by: Will Deacon will.dea...@arm.com Will -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] arm64: don't make early_*map() calls post paging_init()

2015-01-07 Thread Will Deacon
On Tue, Jan 06, 2015 at 08:35:22PM +, Mark Salter wrote: On Tue, 2015-01-06 at 13:41 +, Leif Lindholm wrote: diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c index 6fac253..e311066 100644 --- a/arch/arm64/kernel/efi.c +++ b/arch/arm64/kernel/efi.c @@ -313,17

Re: [PATCH v2 0/2] arm64: don't call early_*map() post paging_init()

2015-01-06 Thread Will Deacon
On Tue, Jan 06, 2015 at 03:54:29PM +, Ard Biesheuvel wrote: On 6 January 2015 at 15:52, Leif Lindholm leif.lindh...@linaro.org wrote: On Tue, Jan 06, 2015 at 02:04:50PM +, Ard Biesheuvel wrote: Changes since v1: - Rebased to v3.19-rc3 - Added 'Fixes:' tags - Reworked 1/2 to

Re: [PATCH v3 02/13] arm64/mm: add create_pgd_mapping() to create private page tables

2014-11-25 Thread Will Deacon
: Reviewed-by: Will Deacon will.dea...@arm.com Will diff --git a/arch/arm64/include/asm/mmu.h b/arch/arm64/include/asm/mmu.h index c2f006c48bdb..5fd40c43be80 100644 --- a/arch/arm64/include/asm/mmu.h +++ b/arch/arm64/include/asm/mmu.h @@ -33,5 +33,8 @@ extern void __iomem *early_io_map

Re: [PATCH v3 04/13] efi: split off remapping code from efi_config_init()

2014-11-25 Thread Will Deacon
On Tue, Nov 25, 2014 at 05:24:19PM +, Matt Fleming wrote: On Tue, 18 Nov, at 01:57:03PM, Ard Biesheuvel wrote: Split of the remapping code from efi_config_init() so that the caller can perform its own remapping. This is necessary to correctly handle virtually remapped UEFI memory

Re: [PATCH v2 00/10] arm64 EFI patches for 3.19

2014-11-05 Thread Will Deacon
On Wed, Nov 05, 2014 at 07:53:39AM +, Ard Biesheuvel wrote: OK, it appears we're good to go with this series. @Will: would you like me to repost one final time? Or would you prefer a pull request instead? The only changes are added acks and a single code change where an open-coded

Re: [PATCH 05/10] arm64/efi: drop redundant set_bit(EFI_CONFIG_TABLES)

2014-10-27 Thread Will Deacon
/efi.c | 2 -- 1 file changed, 2 deletions(-) Since you mentioned it, Acked-by: Will Deacon will.dea...@arm.com Will diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c index 71ea4fc0aa8a..51522ab0c6da 100644 --- a/arch/arm64/kernel/efi.c +++ b/arch/arm64/kernel/efi.c @@ -112,8

Re: [PATCH 10/10] arm64: dmi: set DMI string as dump stack arch description

2014-10-27 Thread Will Deacon
On Wed, Oct 22, 2014 at 03:21:53PM +0100, Ard Biesheuvel wrote: This sets the DMI string, containing system type, serial number, firmware version etc. as dump stack arch description, so that oopses and other kernel stack dumps automatically have this information included, if available.

Re: [PATCH] efi/arm64: store Runtime Services revision

2014-08-26 Thread Will Deacon
On Thu, Aug 14, 2014 at 03:55:22PM +0100, Semen Protsenko wrote: efi global data structure contains runtime_version field which must be assigned in order to use it later in Runtime Services virtual calls (virt_efi_* functions). Before this patch runtime_version was unassigned (0), so each

Re: [PATCH] efi/arm64: store Runtime Services revision

2014-08-26 Thread Will Deacon
On Tue, Aug 26, 2014 at 07:24:50PM +0100, Matt Fleming wrote: On Tue, 26 Aug, at 10:05:33AM, Will Deacon wrote: I doubt it makes any difference, but can we assign this before we call efi_native_runtime_setup please? This would have to be a follow up patch, v2 of this patch is already

Re: [PATCH 5/7 update] arm64/efi: do not enter virtual mode in case booting with efi=noruntime or noefi

2014-08-22 Thread Will Deacon
= (__force void *)ioremap_cache((phys_addr_t)memmap.phys_map, mapsize); memmap.map_end = memmap.map + mapsize; This looks better, thanks: Reviewed-by: Will Deacon will.dea...@arm.com Are you sending these via the efi tree as part of this series

Re: [PATCH 5/7 update] arm64/efi: do not enter virtual mode in case booting with efi=noruntime or noefi

2014-08-22 Thread Will Deacon
On Fri, Aug 22, 2014 at 04:47:19PM +0100, Matt Fleming wrote: On Fri, 22 Aug, at 04:10:07PM, Will Deacon wrote: Are you sending these via the efi tree as part of this series, or do you need me to pick anything up into the arm64 tree? I was planning on taking the entire series through

Re: [PATCH 4/7] arm64/efi: uefi_init error handling fix

2014-08-15 Thread Will Deacon
On Thu, Aug 14, 2014 at 10:15:29AM +0100, Dave Young wrote: There's one early memmap leak in uefi_init error path, fix it and slightly tune the error handling code. Signed-off-by: Dave Young dyo...@redhat.com Reported-by: Will Deacon will.dea...@arm.com Acked-by: Will Deacon will.dea

Re: [PATCH 5/7] arm64/efi: do not enter virtual mode in case booting with efi=noruntime or noefi

2014-08-15 Thread Will Deacon
On Thu, Aug 14, 2014 at 10:15:30AM +0100, Dave Young wrote: In case efi runtime disabled via noefi kernel cmdline arm64_enter_virtual_mode should error out. At the same time move early_memunmap(memmap.map, mapsize) to the beginning of the function or it will leak early mem. Signed-off-by:

Re: [RFC PATCH] arm64/efi: use id mapping for Runtime Services

2014-08-06 Thread Will Deacon
On Wed, Aug 06, 2014 at 04:15:23PM +0100, Ard Biesheuvel wrote: On 6 August 2014 16:36, Will Deacon will.dea...@arm.com wrote: On Thu, Jul 31, 2014 at 03:11:49PM +0100, Ard Biesheuvel wrote: #define efi_call_virt(f

Re: [PATCH v2 1/3] arm64: spin-table: handle unmapped cpu-release-addrs

2014-07-31 Thread Will Deacon
On Wed, Jul 30, 2014 at 08:17:02PM +0100, Ard Biesheuvel wrote: ]On 30 July 2014 13:30, Will Deacon will.dea...@arm.com wrote: On Wed, Jul 30, 2014 at 11:59:02AM +0100, Ard Biesheuvel wrote: From: Mark Rutland mark.rutl...@arm.com In certain cases the cpu-release-addr of a CPU may

Re: [PATCH v2 1/3] arm64: spin-table: handle unmapped cpu-release-addrs

2014-07-30 Thread Will Deacon
On Wed, Jul 30, 2014 at 11:59:02AM +0100, Ard Biesheuvel wrote: From: Mark Rutland mark.rutl...@arm.com In certain cases the cpu-release-addr of a CPU may not fall in the linear mapping (e.g. when the kernel is loaded above this address due to the presence of other images in memory). This is

Re: [PATCH v2 1/3] arm64: spin-table: handle unmapped cpu-release-addrs

2014-07-30 Thread Will Deacon
On Wed, Jul 30, 2014 at 01:30:29PM +0100, Mark Rutland wrote: On Wed, Jul 30, 2014 at 01:00:40PM +0100, Ard Biesheuvel wrote: On 30 July 2014 13:30, Will Deacon will.dea...@arm.com wrote: On Wed, Jul 30, 2014 at 11:59:02AM +0100, Ard Biesheuvel wrote: From: Mark Rutland mark.rutl

Re: [RFC PATCH 04/10] arm64: add EFI little endian constants to linker script

2014-07-30 Thread Will Deacon
On Wed, Jul 30, 2014 at 03:18:05PM +0100, Matt Fleming wrote: On Mon, 21 Jul, at 05:16:19PM, Ard Biesheuvel wrote: Similar to how text offset and kernel size are mangled to produce little endian constants for the Image header regardless of the endianness of the kernel, this adds a number of

Re: EFI_STUB fails to boot non-EFI on arm64

2014-05-28 Thread Will Deacon
On Fri, May 23, 2014 at 04:03:31PM +0100, Leif Lindholm wrote: On Fri, May 23, 2014 at 02:47:20PM +0100, Catalin Marinas wrote: Can we add another of detecting whether it's an EFI application and avoid calling efi_init()? I can see x86 sets some efi_loader_signature string in exit_boot()

Re: EFI_STUB fails to boot non-EFI on arm64

2014-05-28 Thread Will Deacon
On Wed, May 28, 2014 at 07:05:26PM +0100, Leif Lindholm wrote: On Wed, May 28, 2014 at 04:59:31PM +0100, Will Deacon wrote: Can we add another of detecting whether it's an EFI application and avoid calling efi_init()? I can see x86 sets some efi_loader_signature string in exit_boot

Re: [PATCH 02/22] arm: add new asm macro update_sctlr

2014-02-05 Thread Will Deacon
On Wed, Feb 05, 2014 at 05:03:53PM +, Leif Lindholm wrote: A new macro for setting/clearing bits in the SCTLR. Signed-off-by: Leif Lindholm leif.lindh...@linaro.org Suggested-by: Will Deacon will.dea...@arm.com Cc: Will Deacon will.dea...@arm.com --- arch/arm/include/asm/assembler.h

Re: [PATCH v4 2/5] arm: add new asm macro update_sctlr

2014-02-03 Thread Will Deacon
On Thu, Jan 30, 2014 at 01:12:47PM +, Leif Lindholm wrote: Oh, that's neat - thanks! Well, given that, I can think of two less horrible options: 1) .macro update_sctlr, tmp:req, set=, clear= mrc p15, 0, \tmp, c1, c0, 0 .ifnc \set, orr \tmp, \set

Re: [PATCH v4 2/5] arm: add new asm macro update_sctlr

2014-02-03 Thread Will Deacon
On Mon, Feb 03, 2014 at 03:55:42PM +, Leif Lindholm wrote: On Mon, Feb 03, 2014 at 10:34:15AM +, Will Deacon wrote: On Thu, Jan 30, 2014 at 01:12:47PM +, Leif Lindholm wrote: Oh, that's neat - thanks! Well, given that, I can think of two less horrible options: 1

Re: [PATCH v4 2/5] arm: add new asm macro update_sctlr

2014-02-03 Thread Will Deacon
On Mon, Feb 03, 2014 at 04:46:36PM +, Leif Lindholm wrote: On Mon, Feb 03, 2014 at 04:00:51PM +, Will Deacon wrote: With the two call sites in uefi_phys.S as: ldr r5, =(CR_M) update_sctlrr12, , r5 and ldr r4, =(CR_I | CR_C

Re: [PATCH v4 2/5] arm: add new asm macro update_sctlr

2014-01-29 Thread Will Deacon
Hi Leif, On Wed, Jan 29, 2014 at 06:28:05PM +, Leif Lindholm wrote: On Wed, Jan 22, 2014 at 11:20:55AM +, Will Deacon wrote: +#ifdef CONFIG_CPU_CP15 +/* Macro for setting/clearing bits in sctlr */ + .macro update_sctlr, set:req, clear:req, tmp:req, tmp2:req + mrc p15, 0

Re: [PATCH v4 1/5] arm: break part of __soft_restart out into separate function

2014-01-22 Thread Will Deacon
! With that: Acked-by: Will Deacon will.dea...@arm.com Will -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 2/5] arm: add new asm macro update_sctlr

2014-01-22 Thread Will Deacon
On Sat, Jan 11, 2014 at 01:05:21PM +, Leif Lindholm wrote: A new macro for setting/clearing bits in the SCTLR. Signed-off-by: Leif Lindholm leif.lindh...@linaro.org Suggested-by: Will Deacon will.dea...@arm.com --- arch/arm/include/asm/assembler.h | 13 + 1 file changed

Re: [PATCH v3 2/3] arm: Add [U]EFI runtime services support

2013-12-06 Thread Will Deacon
Hi Leif, Sorry it took so long to get back to you on this... On Fri, Nov 29, 2013 at 05:43:04PM +, Leif Lindholm wrote: + */ +static void __init phys_call_prologue(void) +{ + local_irq_disable(); + + /* Take out a flat memory mapping. */ +

Re: [PATCH v3 2/3] arm: Add [U]EFI runtime services support

2013-11-29 Thread Will Deacon
Hi Leif, On Thu, Nov 28, 2013 at 04:41:22PM +, Leif Lindholm wrote: This patch implements basic support for UEFI runtime services in the ARM architecture - a requirement for using efibootmgr to read and update the system boot configuration. It uses the generic configuration table

Re: arm/arm64 UEFI boot protocol

2013-11-12 Thread Will Deacon
Hi Leif, On Mon, Nov 11, 2013 at 05:43:21PM +, Leif Lindholm wrote: We currently have a few sets of patches floating around, for UEFI runtime services, UEFI stub and GRUB support for Linux/UEFI on arm/arm64. The last version of Documentation/arm/uefi.txt I sent out raised a few