Re: [PATCH] efi/arm*: Only register page tables when they exist

2018-01-23 Thread Ard Biesheuvel
On 17 January 2018 at 12:01, Ard Biesheuvel wrote: > On 17 January 2018 at 10:19, Will Deacon wrote: >> On Tue, Jan 16, 2018 at 02:08:32PM +, Mark Rutland wrote: >>> Currently the arm/arm64 runtime code registers the runtime servies >>> pagetables with ptdump regardless of whether runtime ser

Re: [PATCH] efi/arm*: Only register page tables when they exist

2018-01-17 Thread Ard Biesheuvel
On 17 January 2018 at 10:19, Will Deacon wrote: > On Tue, Jan 16, 2018 at 02:08:32PM +, Mark Rutland wrote: >> Currently the arm/arm64 runtime code registers the runtime servies >> pagetables with ptdump regardless of whether runtime services page >> tables have been created. >> >> As efi_mm.p

Re: [PATCH] efi/arm*: Only register page tables when they exist

2018-01-17 Thread Will Deacon
On Tue, Jan 16, 2018 at 02:08:32PM +, Mark Rutland wrote: > Currently the arm/arm64 runtime code registers the runtime servies > pagetables with ptdump regardless of whether runtime services page > tables have been created. > > As efi_mm.pgd is NULL in these cases, attempting to dump the efi p

[PATCH] efi/arm*: Only register page tables when they exist

2018-01-16 Thread Mark Rutland
Currently the arm/arm64 runtime code registers the runtime servies pagetables with ptdump regardless of whether runtime services page tables have been created. As efi_mm.pgd is NULL in these cases, attempting to dump the efi page tables results in a NULL pointer dereference in the ptdump code: /s