Re: [PATCH 2/2] efi/cper: Avoid possible OOB when checking generic data block

2019-01-28 Thread Ross Lagerwall
On 1/23/19 11:54 AM, Borislav Petkov wrote: On Tue, Jan 22, 2019 at 04:09:12PM +, Ross Lagerwall wrote: When checking a generic status block, we iterate over all the generic data blocks. The loop condition only checks that the start of the generic data block is valid (within

Re: [PATCH 2/2] efi/cper: Avoid possible OOB when checking generic data block

2019-01-23 Thread Borislav Petkov
On Tue, Jan 22, 2019 at 04:09:12PM +, Ross Lagerwall wrote: > When checking a generic status block, we iterate over all the generic > data blocks. The loop condition only checks that the start of the > generic data block is valid (within estatus->data_length) but not the > whole block. Because

[PATCH 2/2] efi/cper: Avoid possible OOB when checking generic data block

2019-01-22 Thread Ross Lagerwall
When checking a generic status block, we iterate over all the generic data blocks. The loop condition only checks that the start of the generic data block is valid (within estatus->data_length) but not the whole block. Because the size of data blocks (excluding error data) may vary depending on