Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-07 Thread Yinghai Lu
On Sat, Mar 7, 2015 at 1:05 PM, Borislav Petkov b...@suse.de wrote: On Fri, Mar 06, 2015 at 11:53:22AM -0800, Yinghai Lu wrote: --- Commit f47233c2d34f (x86/mm/ASLR: Propagate base load address calculation) started passing KASLR status to kernel proper, but it uses a physical address as

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-07 Thread Borislav Petkov
On Fri, Mar 06, 2015 at 11:53:22AM -0800, Yinghai Lu wrote: That will get wrong value back for kaslr_enabled in kernel stage. 1. When kaslr is not enabled at boot/choose_kernel_location, if kaslr_enabled get set wrongly in setup.c, late in module.c::get_module_load_offset will return not

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-07 Thread Borislav Petkov
On Fri, Mar 06, 2015 at 11:50:54AM -0800, Yinghai Lu wrote: On Fri, Mar 6, 2015 at 5:33 AM, Borislav Petkov b...@suse.de wrote: However, the setup_data linked list and thus the element which contains kaslr_enabled is chained together using physical addresses. At the time when we access

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-06 Thread Borislav Petkov
On Wed, Mar 04, 2015 at 01:32:53PM -0800, Yinghai Lu wrote: On Wed, Mar 4, 2015 at 12:00 PM, Ingo Molnar mi...@kernel.org wrote: It is totally unacceptable that you don't do proper analysis of the patches you submit, and that you don't bother writing proper, readable changelogs. Sorry,

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-06 Thread Yinghai Lu
On Fri, Mar 6, 2015 at 5:33 AM, Borislav Petkov b...@suse.de wrote: Please use checkpatch before submitting patches: WARNING: please, no spaces at the start of a line #71: FILE: arch/x86/kernel/setup.c:433: +unsigned char *data;$ WARNING: please, no spaces at the start of a line #72:

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-06 Thread Yinghai Lu
On Fri, Mar 6, 2015 at 11:50 AM, Yinghai Lu ying...@kernel.org wrote: On Fri, Mar 6, 2015 at 5:33 AM, Borislav Petkov b...@suse.de wrote: However, the setup_data linked list and thus the element which contains kaslr_enabled is chained together using physical addresses. At the time when we

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-06 Thread Yinghai Lu
On Fri, Mar 6, 2015 at 5:33 AM, Borislav Petkov b...@suse.de wrote: However, the setup_data linked list and thus the element which contains kaslr_enabled is chained together using physical addresses. At the time when we access it in the kernel proper, we're already running with paging

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-04 Thread Yinghai Lu
On Wed, Mar 4, 2015 at 2:16 AM, Borislav Petkov b...@alien8.de wrote: On Wed, Mar 04, 2015 at 12:00:37AM -0800, Yinghai Lu wrote: commit f47233c2d34f (x86/mm/ASLR: Propagate base load address calculation) is using address as value for kaslr_enabled. That will random kaslr_enabled get that set

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-04 Thread Yinghai Lu
On Wed, Mar 4, 2015 at 7:54 AM, Jiri Kosina jkos...@suse.cz wrote: Also this 15-patch series needs to be separated into two patchsets. The whole series is not appropriate for -rc3, but this particular one at least is a regression fix that has to go in. The first 4 should go v4.0. could

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-04 Thread Yinghai Lu
On Wed, Mar 4, 2015 at 10:06 AM, Yinghai Lu ying...@kernel.org wrote: On Wed, Mar 4, 2015 at 2:16 AM, Borislav Petkov b...@alien8.de wrote: On Wed, Mar 04, 2015 at 12:00:37AM -0800, Yinghai Lu wrote: commit f47233c2d34f (x86/mm/ASLR: Propagate base load address calculation) is using address as

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-04 Thread Yinghai Lu
On Wed, Mar 4, 2015 at 12:00 PM, Ingo Molnar mi...@kernel.org wrote: It is totally unacceptable that you don't do proper analysis of the patches you submit, and that you don't bother writing proper, readable changelogs. Sorry, please check it again: Subject: [PATCH v4] x86, kaslr: Get

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-04 Thread Ingo Molnar
* Yinghai Lu ying...@kernel.org wrote: On Wed, Mar 4, 2015 at 2:16 AM, Borislav Petkov b...@alien8.de wrote: On Wed, Mar 04, 2015 at 12:00:37AM -0800, Yinghai Lu wrote: commit f47233c2d34f (x86/mm/ASLR: Propagate base load address calculation) is using address as value for

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-04 Thread Ingo Molnar
* Yinghai Lu ying...@kernel.org wrote: On Wed, Mar 4, 2015 at 7:54 AM, Jiri Kosina jkos...@suse.cz wrote: Also this 15-patch series needs to be separated into two patchsets. The whole series is not appropriate for -rc3, but this particular one at least is a regression fix that has to

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-04 Thread joeyli
Hi Yinghai, On Wed, Mar 04, 2015 at 10:12:58AM -0800, Yinghai Lu wrote: On Wed, Mar 4, 2015 at 7:54 AM, Jiri Kosina jkos...@suse.cz wrote: Also this 15-patch series needs to be separated into two patchsets. The whole series is not appropriate for -rc3, but this particular one at least

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-04 Thread Yinghai Lu
On Wed, Mar 4, 2015 at 6:58 PM, joeyli j...@suse.com wrote: After 84c91b7ae merged to v3.17 kernel, hibernate code checks the e280 regions should not be changed when doing hibernate resume. Without your patch 8, the hibernate resume checking will randomly fail on the machines that reserved

[PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-04 Thread Yinghai Lu
commit f47233c2d34f (x86/mm/ASLR: Propagate base load address calculation) is using address as value for kaslr_enabled. That will random kaslr_enabled get that set or cleared. Will have problem for system really have kaslr enabled. -v2: update changelog. Fixes: f47233c2d34f (x86/mm/ASLR:

Re: [PATCH v2 04/15] x86, kaslr: get kaslr_enabled back correctly

2015-03-04 Thread Borislav Petkov
On Wed, Mar 04, 2015 at 12:00:37AM -0800, Yinghai Lu wrote: commit f47233c2d34f (x86/mm/ASLR: Propagate base load address calculation) is using address as value for kaslr_enabled. That will random kaslr_enabled get that set or cleared. Will have problem for system really have kaslr enabled.