Re: [PATCH v2 06/16] x86/efi: Generating random HMAC key for siging hibernate image

2015-09-12 Thread joeyli
On Wed, Sep 09, 2015 at 01:15:45PM +0100, Matt Fleming wrote: > On Thu, 27 Aug, at 05:04:52PM, joeyli wrote: > > > > The purpose of checking attribute of hibernation key variable is > > in case someone created a key variable on runtime environment _before_ > > this kernel create boot service

Re: [PATCH v2 06/16] x86/efi: Generating random HMAC key for siging hibernate image

2015-09-09 Thread Matt Fleming
On Thu, 27 Aug, at 05:04:52PM, joeyli wrote: > > The purpose of checking attribute of hibernation key variable is > in case someone created a key variable on runtime environment _before_ > this kernel create boot service variable. That causes EFI stub may load > a key that from non-secure

Re: [PATCH v2 06/16] x86/efi: Generating random HMAC key for siging hibernate image

2015-08-27 Thread joeyli
On Thu, Aug 20, 2015 at 09:40:44PM +0100, Matt Fleming wrote: On Tue, 11 Aug, at 02:16:26PM, Lee, Chun-Yi wrote: This patch adds codes in EFI stub for generating and storing the HMAC key in EFI boot service variable for signing hibernate image. Per rcf2104, the length of HMAC-SHA1 hash

Re: [PATCH v2 06/16] x86/efi: Generating random HMAC key for siging hibernate image

2015-08-20 Thread Matt Fleming
On Tue, 11 Aug, at 02:16:26PM, Lee, Chun-Yi wrote: This patch adds codes in EFI stub for generating and storing the HMAC key in EFI boot service variable for signing hibernate image. Per rcf2104, the length of HMAC-SHA1 hash result is 20 bytes, and it recommended the length of key the same

[PATCH v2 06/16] x86/efi: Generating random HMAC key for siging hibernate image

2015-08-11 Thread Lee, Chun-Yi
This patch adds codes in EFI stub for generating and storing the HMAC key in EFI boot service variable for signing hibernate image. Per rcf2104, the length of HMAC-SHA1 hash result is 20 bytes, and it recommended the length of key the same with hash rsult, means also 20 bytes. Using longer key