Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-12 Thread Nick Desaulniers
On Tue, Jun 12, 2018 at 2:31 PM H. Peter Anvin wrote: > > On 06/12/18 13:19, Nick Desaulniers wrote: > > > > Oh, by [0] __GCC_STDC_INLINE__ is indeed actually the correct symbol > > to check for. Clang does support that, so nothing to fix there. > > > >> By the way, you should check clang

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-12 Thread H. Peter Anvin
On 06/12/18 13:19, Nick Desaulniers wrote: > > Oh, by [0] __GCC_STDC_INLINE__ is indeed actually the correct symbol > to check for. Clang does support that, so nothing to fix there. > >> By the way, you should check clang against gcc's predefined macros by doing: >> >> gcc [options] -x c

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-12 Thread Nick Desaulniers
On Tue, Jun 12, 2018 at 11:51 AM H. Peter Anvin wrote: > > ,Greg KH > ,jarkko.sakki...@linux.intel.com,jgr...@suse.com,Josh > Poimboeuf ,Matthias Kaehlcke > ,thomas.lenda...@amd.com,Thiebaud Weksteen > ,mj...@google.com,j...@perches.com > From: h...@zytor.com > Message-ID:

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-12 Thread H. Peter Anvin
,Greg KH ,jarkko.sakki...@linux.intel.com,jgr...@suse.com,Josh Poimboeuf ,Matthias Kaehlcke ,thomas.lenda...@amd.com,Thiebaud Weksteen ,mj...@google.com,j...@perches.com From: h...@zytor.com Message-ID: <191e4ebe-4cb2-4c8b-ab61-689a91ffe...@zytor.com> On June 12, 2018 11:33:14 AM PDT, Nick

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-12 Thread Nick Desaulniers
On Fri, Jun 8, 2018 at 3:04 AM Sedat Dilek wrote: > > On Fri, Jun 8, 2018 at 9:59 AM, Arnd Bergmann wrote: > > On Thu, Jun 7, 2018 at 10:49 PM, Nick Desaulniers > > wrote: > >> Functions marked extern inline do not emit an externally visible > >> function when the gnu89 C standard is used. Some

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-08 Thread Sedat Dilek
On Fri, Jun 8, 2018 at 1:28 PM, Andrea Parri wrote: > On Fri, Jun 08, 2018 at 12:04:36PM +0200, Sedat Dilek wrote: >> On Fri, Jun 8, 2018 at 9:59 AM, Arnd Bergmann wrote: >> > On Thu, Jun 7, 2018 at 10:49 PM, Nick Desaulniers >> > wrote: >> >> Functions marked extern inline do not emit an

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-08 Thread Andrea Parri
On Fri, Jun 08, 2018 at 12:04:36PM +0200, Sedat Dilek wrote: > On Fri, Jun 8, 2018 at 9:59 AM, Arnd Bergmann wrote: > > On Thu, Jun 7, 2018 at 10:49 PM, Nick Desaulniers > > wrote: > >> Functions marked extern inline do not emit an externally visible > >> function when the gnu89 C standard is

Re: [PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-08 Thread Arnd Bergmann
On Thu, Jun 7, 2018 at 10:49 PM, Nick Desaulniers wrote: > Functions marked extern inline do not emit an externally visible > function when the gnu89 C standard is used. Some KBUILD Makefiles > overwrite KBUILD_CFLAGS. This is an issue for GCC 5.1+ users as without > an explicit C standard

[PATCH v4 1/3] compiler-gcc.h: add gnu_inline to all inline declarations

2018-06-07 Thread Nick Desaulniers
Functions marked extern inline do not emit an externally visible function when the gnu89 C standard is used. Some KBUILD Makefiles overwrite KBUILD_CFLAGS. This is an issue for GCC 5.1+ users as without an explicit C standard specified, the default is gnu11. Since c99, the semantics of extern