Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-11-24 Thread Robert Richter
Ard, On 08.10.15 20:02:04, Ard Biesheuvel wrote: > +quiet_cmd_stubcopy = STUBCPY $@ > + cmd_stubcopy = if $(OBJCOPY) $(STUBCOPY_FLAGS-y) $< $@; then \ > + $(OBJDUMP) -r $@ | grep $(STUBCOPY_RELOC-y)\ > + && (echo >&2 "$@: absolute symbol references

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-11-24 Thread Ard Biesheuvel
On 24 November 2015 at 10:34, Robert Richter wrote: > Ard, > > On 08.10.15 20:02:04, Ard Biesheuvel wrote: >> +quiet_cmd_stubcopy = STUBCPY $@ >> + cmd_stubcopy = if $(OBJCOPY) $(STUBCOPY_FLAGS-y) $< $@; then \ >> + $(OBJDUMP) -r $@ | grep $(STUBCOPY_RELOC-y)\ >> +

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-11-02 Thread Matt Fleming
On Tue, 27 Oct, at 11:20:51AM, Ard Biesheuvel wrote: > From 1179099f89db54294f419493d152083fb8e5af3d Mon Sep 17 00:00:00 2001 > From: Ard Biesheuvel > Date: Tue, 27 Oct 2015 11:12:51 +0900 > Subject: [PATCH] arm64/efi: fix libstub build under CONFIG_MODVERSIONS > > Now that we strictly forbid abs

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-30 Thread Catalin Marinas
On Fri, Oct 30, 2015 at 01:17:24PM +0100, Ard Biesheuvel wrote: > On 27 October 2015 at 23:44, Jeremy Linton wrote: > > On 10/26/2015 09:20 PM, Ard Biesheuvel wrote: > >> > >> Thanks for the report. The following patch should fix it > > > > > > Ard, > > > > Thanks, it does fix the build problem...

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-30 Thread Mark Rutland
[Adding Catalin to the To line] On Fri, Oct 30, 2015 at 01:17:24PM +0100, Ard Biesheuvel wrote: > On 27 October 2015 at 23:44, Jeremy Linton wrote: > > On 10/26/2015 09:20 PM, Ard Biesheuvel wrote: > >> > >> Thanks for the report. The following patch should fix it > > > > > > Ard, > > > > Thanks,

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-30 Thread Ard Biesheuvel
On 27 October 2015 at 23:44, Jeremy Linton wrote: > On 10/26/2015 09:20 PM, Ard Biesheuvel wrote: >> >> Thanks for the report. The following patch should fix it > > > Ard, > > Thanks, it does fix the build problem... > > Now to get the darn thing to boot (not related to this AFAIK). > Catalin, W

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-27 Thread Jeremy Linton
On 10/26/2015 09:20 PM, Ard Biesheuvel wrote: Thanks for the report. The following patch should fix it Ard, Thanks, it does fix the build problem... Now to get the darn thing to boot (not related to this AFAIK). -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-26 Thread Ard Biesheuvel
On 27 October 2015 at 07:33, Jeremy Linton wrote: > On 10/26/2015 05:26 PM, Jeremy Linton wrote: >> >> On 10/08/2015 02:02 PM, Ard Biesheuvel wrote: >>> >>> Since arm64 does not use a builtin decompressor, the EFI stub is built >>> into the kernel proper. So far, this has been working fine, but ac

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-26 Thread Jeremy Linton
On 10/26/2015 05:26 PM, Jeremy Linton wrote: On 10/08/2015 02:02 PM, Ard Biesheuvel wrote: Since arm64 does not use a builtin decompressor, the EFI stub is built into the kernel proper. So far, this has been working fine, but actually, since the stub is in fact a PE/COFF relocatable binary that

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-26 Thread Jeremy Linton
On 10/08/2015 02:02 PM, Ard Biesheuvel wrote: Since arm64 does not use a builtin decompressor, the EFI stub is built into the kernel proper. So far, this has been working fine, but actually, since the stub is in fact a PE/COFF relocatable binary that is executed at an unknown offset in the 1:1 ma

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-10 Thread Matt Fleming
On Thu, 08 Oct, at 08:02:04PM, Ard Biesheuvel wrote: > Since arm64 does not use a builtin decompressor, the EFI stub is built > into the kernel proper. So far, this has been working fine, but actually, > since the stub is in fact a PE/COFF relocatable binary that is executed > at an unknown offset

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-09 Thread Andrey Ryabinin
2015-10-09 12:43 GMT+03:00 Will Deacon : > On Fri, Oct 09, 2015 at 12:40:21PM +0300, Andrey Ryabinin wrote: >> 2015-10-09 12:10 GMT+03:00 Will Deacon : >> > On Fri, Oct 09, 2015 at 11:12:24AM +0300, Andrey Ryabinin wrote: >> >> 2015-10-08 22:02 GMT+03:00 Ard Biesheuvel : >> >> > --- a/arch/arm64/ke

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-09 Thread Will Deacon
On Fri, Oct 09, 2015 at 12:40:21PM +0300, Andrey Ryabinin wrote: > 2015-10-09 12:10 GMT+03:00 Will Deacon : > > On Fri, Oct 09, 2015 at 11:12:24AM +0300, Andrey Ryabinin wrote: > >> 2015-10-08 22:02 GMT+03:00 Ard Biesheuvel : > >> > --- a/arch/arm64/kernel/image.h > >> > +++ b/arch/arm64/kernel/ima

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-09 Thread Andrey Ryabinin
2015-10-09 12:10 GMT+03:00 Will Deacon : > On Fri, Oct 09, 2015 at 11:12:24AM +0300, Andrey Ryabinin wrote: >> 2015-10-08 22:02 GMT+03:00 Ard Biesheuvel : >> > --- a/arch/arm64/kernel/image.h >> > +++ b/arch/arm64/kernel/image.h >> > @@ -59,4 +59,31 @@ >> > _kernel_offset_le = DATA_LE

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-09 Thread Will Deacon
On Fri, Oct 09, 2015 at 11:12:24AM +0300, Andrey Ryabinin wrote: > 2015-10-08 22:02 GMT+03:00 Ard Biesheuvel : > > --- a/arch/arm64/kernel/image.h > > +++ b/arch/arm64/kernel/image.h > > @@ -59,4 +59,31 @@ > > _kernel_offset_le = DATA_LE64(TEXT_OFFSET); \ > > _kernel_fla

Re: [PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-09 Thread Andrey Ryabinin
2015-10-08 22:02 GMT+03:00 Ard Biesheuvel : > --- a/arch/arm64/kernel/image.h > +++ b/arch/arm64/kernel/image.h > @@ -59,4 +59,31 @@ > _kernel_offset_le = DATA_LE64(TEXT_OFFSET); \ > _kernel_flags_le= DATA_LE64(__HEAD_FLAGS); > > +#ifdef CONFIG_EFI > + > +/* > +

[PATCH v4 3/3] arm64/efi: isolate EFI stub from the kernel proper

2015-10-08 Thread Ard Biesheuvel
Since arm64 does not use a builtin decompressor, the EFI stub is built into the kernel proper. So far, this has been working fine, but actually, since the stub is in fact a PE/COFF relocatable binary that is executed at an unknown offset in the 1:1 mapping provided by the UEFI firmware, we should n