Re: [patch 1/3 v2] Add function get_bootparam

2013-11-17 Thread Dave Young
On 11/17/13 at 07:29pm, H. Peter Anvin wrote: On 11/17/2013 06:22 PM, Dave Young wrote: On 11/13/13 at 08:50am, Dave Young wrote: On 11/12/13 at 06:51pm, Greg KH wrote: On Tue, Nov 12, 2013 at 01:37:25AM -0800, H. Peter Anvin wrote: On 11/12/2013 12:30 AM, Greg KH wrote: And these

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-17 Thread H. Peter Anvin
In other words, we didn't catch that one in time. Oh well. Dave Young dyo...@redhat.com wrote: On 11/17/13 at 07:29pm, H. Peter Anvin wrote: On 11/17/2013 06:22 PM, Dave Young wrote: On 11/13/13 at 08:50am, Dave Young wrote: On 11/12/13 at 06:51pm, Greg KH wrote: On Tue, Nov 12, 2013 at

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-12 Thread Greg KH
On Tue, Nov 12, 2013 at 04:08:54PM +0800, Dave Young wrote: On 11/11/13 at 11:58pm, Greg KH wrote: kexec-tools can have a fallback to debugfs if we really need it, but making people mount debugfs to have some essential piece of functionality scares the heck out of me. I agree, that

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-12 Thread Dave Young
On 11/12/13 at 12:30am, Greg KH wrote: On Tue, Nov 12, 2013 at 04:08:54PM +0800, Dave Young wrote: On 11/11/13 at 11:58pm, Greg KH wrote: kexec-tools can have a fallback to debugfs if we really need it, but making people mount debugfs to have some essential piece of functionality

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-12 Thread H. Peter Anvin
On 11/12/2013 12:30 AM, Greg KH wrote: And these binary data blobs are a standard somewhere, and will not change per kernel version change? If so, that structure is fine with me. Correct. The structure is documented in Documentation/x86/boot.txt, and has been largely invariant (but

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-12 Thread Greg KH
On Tue, Nov 12, 2013 at 01:37:25AM -0800, H. Peter Anvin wrote: On 11/12/2013 12:30 AM, Greg KH wrote: And these binary data blobs are a standard somewhere, and will not change per kernel version change? If so, that structure is fine with me. Correct. The structure is

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-12 Thread Vivek Goyal
On Tue, Nov 12, 2013 at 04:58:50PM +1300, Matthew Garrett wrote: Well, there's one alternative - don't export this at all and only support UEFI kernels that have an in-kernel loader, then just pass the data internally. Hi Matthew, I am still writing that in-kernel support for kexec/kdump.

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-12 Thread Dave Young
On 11/12/13 at 06:51pm, Greg KH wrote: On Tue, Nov 12, 2013 at 01:37:25AM -0800, H. Peter Anvin wrote: On 11/12/2013 12:30 AM, Greg KH wrote: And these binary data blobs are a standard somewhere, and will not change per kernel version change? If so, that structure is fine with

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-11 Thread Dave Young
On 11/11/13 at 06:27pm, Toshi Kani wrote: On Tue, 2013-11-05 at 16:29 +0800, dyo...@redhat.com wrote: Not only setup_subarch will get data from debugfs file boot_params/data, later code for adding efi_info will also need do same thing. Thus add a common function here for later use.

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-11 Thread H. Peter Anvin
On 11/11/2013 05:27 PM, Toshi Kani wrote: On Tue, 2013-11-05 at 16:29 +0800, dyo...@redhat.com wrote: Not only setup_subarch will get data from debugfs file boot_params/data, later code for adding efi_info will also need do same thing. Thus add a common function here for later use.

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-11 Thread Ingo Molnar
* H. Peter Anvin h...@zytor.com wrote: On 11/11/2013 05:27 PM, Toshi Kani wrote: On Tue, 2013-11-05 at 16:29 +0800, dyo...@redhat.com wrote: Not only setup_subarch will get data from debugfs file boot_params/data, later code for adding efi_info will also need do same thing. Thus add a

[patch 1/3 v2] Add function get_bootparam

2013-11-05 Thread dyoung
Not only setup_subarch will get data from debugfs file boot_params/data, later code for adding efi_info will also need do same thing. Thus add a common function here for later use. v1-v2: make get_bootparam() static Signed-off-by: Dave Young dyo...@redhat.com ---