Re: EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)

2019-04-17 Thread Ingo Molnar
* Ard Biesheuvel wrote: > On Wed, 17 Apr 2019 at 11:23, Ingo Molnar wrote: > > > > > > * Prakhya, Sai Praneeth wrote: > > > > > I will ask around internally to check if it is a good idea to make EFI > > > reboot the default method when the machine is booted in EFI mode. > > > > Or whether the

Re: EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)

2019-04-17 Thread Ard Biesheuvel
On Wed, 17 Apr 2019 at 11:23, Ingo Molnar wrote: > > > * Prakhya, Sai Praneeth wrote: > > > I will ask around internally to check if it is a good idea to make EFI > > reboot the default method when the machine is booted in EFI mode. > > Or whether there's some robust signature that indicates "mod

Re: EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)

2019-04-17 Thread Ingo Molnar
* Prakhya, Sai Praneeth wrote: > I will ask around internally to check if it is a good idea to make EFI > reboot the default method when the machine is booted in EFI mode. Or whether there's some robust signature that indicates "modern EFI system where EFI reboot is the primary method"? Maj

RE: EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)

2019-04-17 Thread Prakhya, Sai Praneeth
> > >> That seems counter-intuitive to me: if no full ACPI hardware is > > >> implemented then we should assume reduced ACPI functionality, i.e. > > >> if > > >the > > >> EFI runtime is otherwise available we should default to it. > > > > > >It's a bit confusing, but my loose understanding is that

Re: EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)

2019-04-17 Thread hpa
On April 17, 2019 9:37:29 AM PDT, Ingo Molnar wrote: > >* h...@zytor.com wrote: > >> > Just to check, you mean: EFI reboot (and shutdown) become the >default >> > methods when the machine is booted in EFI mode, and EFI stuff has >not >> > been disabled with a kernel parameter? >> > Even when runn

Re: EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)

2019-04-17 Thread Ingo Molnar
* h...@zytor.com wrote: > > Just to check, you mean: EFI reboot (and shutdown) become the default > > methods when the machine is booted in EFI mode, and EFI stuff has not > > been disabled with a kernel parameter? > > Even when running in full hardware ACPI mode. No, I still think "early" EFI

Re: EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)

2019-04-17 Thread Ard Biesheuvel
On Wed, 17 Apr 2019 at 08:16, wrote: > > On April 17, 2019 5:38:41 AM PDT, Daniel Drake wrote: > >On Wed, Apr 17, 2019 at 2:16 PM Ingo Molnar wrote: > >> Ok, so acpi_gbl_reduced_hardware is set when the ... 'reduced > >hardware' > >> bit is set: > >> > >> acpi_gbl_reduced_hardware = FALS

Re: EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)

2019-04-17 Thread hpa
On April 17, 2019 5:38:41 AM PDT, Daniel Drake wrote: >On Wed, Apr 17, 2019 at 2:16 PM Ingo Molnar wrote: >> Ok, so acpi_gbl_reduced_hardware is set when the ... 'reduced >hardware' >> bit is set: >> >> acpi_gbl_reduced_hardware = FALSE; >> if (acpi_gbl_FADT.flags & ACPI_FADT_HW_R

Re: EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)

2019-04-17 Thread Daniel Drake
On Wed, Apr 17, 2019 at 2:16 PM Ingo Molnar wrote: > Ok, so acpi_gbl_reduced_hardware is set when the ... 'reduced hardware' > bit is set: > > acpi_gbl_reduced_hardware = FALSE; > if (acpi_gbl_FADT.flags & ACPI_FADT_HW_REDUCED) { > acpi_gbl_reduced_hardware = TRUE;

Re: EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)

2019-04-16 Thread Ingo Molnar
* Daniel Drake wrote: > On Tue, Apr 16, 2019 at 4:20 PM Ingo Molnar wrote: > > I wanted to get a second opinion from the EFI folks for this whole > > concept. On x86 we default to ACPI reboot on modern systems, and we > > default to EFI reboot on modern EFI systems, via the > > efi_reboot_requ

Re: EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)

2019-04-16 Thread Daniel Drake
On Tue, Apr 16, 2019 at 4:20 PM Ingo Molnar wrote: > I wanted to get a second opinion from the EFI folks for this whole > concept. On x86 we default to ACPI reboot on modern systems, and we > default to EFI reboot on modern EFI systems, via the > efi_reboot_required() method which keys off on acpi

EFI reboot vs. ACPI reboot (was: Re: [tip:x86/urgent] x86/reboot, efi: Use EFI reboot for Acer TravelMate X514-51T)

2019-04-16 Thread Ingo Molnar
(Cc:-ed EFI and ACPI folks.) * tip-bot for Jian-Hong Pan wrote: > Commit-ID: 0082517fa4bce073e7cf542633439f26538a14cc > Gitweb: > https://git.kernel.org/tip/0082517fa4bce073e7cf542633439f26538a14cc > Author: Jian-Hong Pan > AuthorDate: Fri, 12 Apr 2019 16:01:53 +0800 > Committer: I