Re: [PATCH] efi: get_memory_map: add sufficient slack for memory descriptors

2015-02-12 Thread Mark Rutland
On Thu, Feb 12, 2015 at 05:24:19AM +, Ard Biesheuvel wrote: As it turns out, when allocating room for the UEFI memory map using UEFI's AllocatePool (), it may result in two new memory map entries being created, for instance, when using Tianocore's preallocated region feature. For example,

Re: [PATCH] efi: get_memory_map: add sufficient slack for memory descriptors

2015-02-12 Thread Ard Biesheuvel
On 12 February 2015 at 18:22, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Feb 12, 2015 at 05:24:19AM +, Ard Biesheuvel wrote: As it turns out, when allocating room for the UEFI memory map using UEFI's AllocatePool (), it may result in two new memory map entries being created, for

Re: [PATCH] efi: get_memory_map: add sufficient slack for memory descriptors

2015-02-12 Thread Mark Rutland
On Thu, Feb 12, 2015 at 10:39:46AM +, Ard Biesheuvel wrote: On 12 February 2015 at 18:22, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Feb 12, 2015 at 05:24:19AM +, Ard Biesheuvel wrote: As it turns out, when allocating room for the UEFI memory map using UEFI's AllocatePool (),

Re: [PATCH] efi: get_memory_map: add sufficient slack for memory descriptors

2015-02-12 Thread Roy Franz
On Thu, Feb 12, 2015 at 12:24 AM, Ard Biesheuvel ard.biesheu...@linaro.org wrote: As it turns out, when allocating room for the UEFI memory map using UEFI's AllocatePool (), it may result in two new memory map entries being created, for instance, when using Tianocore's preallocated region

Re: [PATCH] efi: get_memory_map: add sufficient slack for memory descriptors

2015-02-12 Thread Matt Fleming
On Thu, 12 Feb, at 06:39:46PM, Ard Biesheuvel wrote: I don't see how doing a single allocation could result in a single free region to be split into more than 1 occupied region + 2 free regions. So no, I don't think it is ... I don't think that's a guarantee we can make, nor is it something

Re: [PATCH] efi: get_memory_map: add sufficient slack for memory descriptors

2015-02-12 Thread Ard Biesheuvel
On 12 February 2015 at 22:47, Matt Fleming m...@codeblueprint.co.uk wrote: On Thu, 12 Feb, at 06:39:46PM, Ard Biesheuvel wrote: I don't see how doing a single allocation could result in a single free region to be split into more than 1 occupied region + 2 free regions. So no, I don't think

Re: [PATCH] x86, boot: Allow 64bit EFI kernel to be loaded above 4G

2015-02-12 Thread Matt Fleming
On Wed, 11 Feb, at 11:29:58AM, Peter Jones wrote: From grub's point of view I'm not sure why we'd care - the pages kernel and initramfs land in are both from the Boot Services allocator, so if the machine doesn't support high addresses, they won't be there. It's not that some implementations

Re: [PATCH] efi: get_memory_map: add sufficient slack for memory descriptors

2015-02-12 Thread Mark Rutland
On Thu, Feb 12, 2015 at 02:56:51PM +, Ard Biesheuvel wrote: On 12 February 2015 at 22:47, Matt Fleming m...@codeblueprint.co.uk wrote: On Thu, 12 Feb, at 06:39:46PM, Ard Biesheuvel wrote: I don't see how doing a single allocation could result in a single free region to be split into

Re: [PATCH] efi: get_memory_map: add sufficient slack for memory descriptors

2015-02-12 Thread Ard Biesheuvel
On 12 February 2015 at 23:16, Mark Rutland mark.rutl...@arm.com wrote: On Thu, Feb 12, 2015 at 02:56:51PM +, Ard Biesheuvel wrote: On 12 February 2015 at 22:47, Matt Fleming m...@codeblueprint.co.uk wrote: On Thu, 12 Feb, at 06:39:46PM, Ard Biesheuvel wrote: I don't see how doing a