Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-11 Thread Matt Fleming
On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: > The original efivars_pstore_exit() is empty. I > 1) add a bufsize check statement. > 2) call pstore_unregister as it is defined now. > 3) free the memory and set bufsize to 0. > > Signed-off-by: Geliang Tang > --- >

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-11 Thread Kees Cook
On Wed, Nov 11, 2015 at 3:23 PM, Luck, Tony wrote: module_init(efivars_pstore_init); >>> >>> Looks OK to me. Kees, are you picking this up? >> >> I can, though usually it goes through Tony. > > Can I count that as "Acked-by" from both of you? Yup, sorry. I thought I'd

Re: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-11 Thread Kees Cook
On Wed, Nov 11, 2015 at 8:59 AM, Matt Fleming wrote: > On Sat, 07 Nov, at 12:43:48PM, Geliang Tang wrote: >> The original efivars_pstore_exit() is empty. I >> 1) add a bufsize check statement. >> 2) call pstore_unregister as it is defined now. >> 3) free the memory

RE: [PATCH v2 2/3] efi-pstore: implement efivars_pstore_exit()

2015-11-11 Thread Luck, Tony
>>> module_init(efivars_pstore_init); >> >> Looks OK to me. Kees, are you picking this up? > > I can, though usually it goes through Tony. Can I count that as "Acked-by" from both of you? -Tony