Re: [PATCH 08/10] efi/x86: Move EFI BGRT init code to early init code

2017-05-15 Thread Dave Young
Hi, Thanks for the report. On 05/14/17 at 01:18am, Sabrina Dubroca wrote: > 2017-01-31, 13:21:40 +, Ard Biesheuvel wrote: > > From: Dave Young > > > > Before invoking the arch specific handler, efi_mem_reserve() reserves > > the given memory region through memblock. > > > > efi_bgrt_init()

Re: [PATCH 08/10] efi/x86: Move EFI BGRT init code to early init code

2017-05-15 Thread Sabrina Dubroca
2017-05-15, 16:37:40 +0800, Dave Young wrote: > Hi, > > Thanks for the report. > On 05/14/17 at 01:18am, Sabrina Dubroca wrote: > > 2017-01-31, 13:21:40 +, Ard Biesheuvel wrote: > > > From: Dave Young > > > > > > Before invoking the arch specific handler, efi_mem_reserve() reserves > > > the

Re: [PATCH] efi: don't issue error message when booted under xen

2017-05-15 Thread Matt Fleming
On Mon, 08 May, at 02:56:33PM, Juergen Gross wrote: > When booted as Xen dom0 there won't be an EFI memmap allocated. Avoid > issuing an error message in this case: > > [0.144079] efi: Failed to allocate new EFI memmap > > Signed-off-by: Juergen Gross > --- > arch/x86/platform/efi/quirks.c

Re: [PATCH 08/10] efi/x86: Move EFI BGRT init code to early init code

2017-05-15 Thread Dave Young
On 05/15/17 at 01:10pm, Sabrina Dubroca wrote: > 2017-05-15, 16:37:40 +0800, Dave Young wrote: > > Hi, > > > > Thanks for the report. > > On 05/14/17 at 01:18am, Sabrina Dubroca wrote: > > > 2017-01-31, 13:21:40 +, Ard Biesheuvel wrote: > > > > From: Dave Young > > > > > > > > Before invokin

Re: [PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-15 Thread Matt Fleming
(Pulling in Dave, Mr. Kexec on EFI) On Mon, 08 May, at 12:25:23PM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > Booting kexec kernel with "efi=old_map" in kernel command line hits > kernel panic as shown below. > > [0.001000] BUG: unable to handle kernel paging request at 88007f

Re: [PATCH 08/10] efi/x86: Move EFI BGRT init code to early init code

2017-05-15 Thread Sabrina Dubroca
2017-05-15, 21:18:35 +0800, Dave Young wrote: > On 05/15/17 at 01:10pm, Sabrina Dubroca wrote: > > 2017-05-15, 16:37:40 +0800, Dave Young wrote: > > > diff --git a/arch/x86/platform/efi/efi-bgrt.c > > > b/arch/x86/platform/efi/efi-bgrt.c > > > index 04ca876..b986e26 100644 > > > --- a/arch/x86/pla

Re: [PATCH] efi: remove duplicate 'const' specifiers

2017-05-15 Thread Matt Fleming
On Thu, 11 May, at 01:43:17PM, Arnd Bergmann wrote: > gcc-7 shows a harmless warning: > > drivers/firmware/efi/libstub/secureboot.c:19:27: error: duplicate 'const' > declaration specifier [-Werror=duplicate-decl-specifier] > static const efi_char16_t const efi_SecureBoot_name[] = { > drivers/fir

Re: [PATCH V2] x86/efi: Add EFI_PGT_DUMP support for x86_32, kexec

2017-05-15 Thread Matt Fleming
On Thu, 11 May, at 12:20:33PM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > EFI_PGT_DUMP, as the name suggests dumps efi page tables to dmesg during > kernel boot. This feature is very useful while debugging page > faults/null pointer dereferences to efi related addresses. Presently, > th

Re: [PATCH 4.11 00/28] 4.11.1-stable review

2017-05-15 Thread Matt Fleming
On Fri, 12 May, at 10:01:41AM, Shuah Khan wrote: > > Greg/Matt, > > I started seeing this maybe since 4.11, so it isn't really a 4.11.1 > issue, however sounds like this shouldn't be an error message, since > it is showing up on an older platform. > > efi: EFI_MEMMAP is not enabled. > efi: Faile

Re: [PATCH v5 14/32] efi: Add an EFI table address match function

2017-05-15 Thread Borislav Petkov
On Tue, Apr 18, 2017 at 04:18:48PM -0500, Tom Lendacky wrote: > Add a function that will determine if a supplied physical address matches > the address of an EFI table. > > Signed-off-by: Tom Lendacky > --- > drivers/firmware/efi/efi.c | 33 + > include/linux/ef

Re: [PATCH v5 17/32] x86/mm: Add support to access boot related data in the clear

2017-05-15 Thread Borislav Petkov
On Tue, Apr 18, 2017 at 04:19:21PM -0500, Tom Lendacky wrote: > Boot data (such as EFI related data) is not encrypted when the system is > booted because UEFI/BIOS does not run with SME active. In order to access > this data properly it needs to be mapped decrypted. > > The early_memremap() suppor

[PATCH V16 00/11] Add UEFI 2.6 and ACPI 6.1 updates for RAS on ARM64

2017-05-15 Thread Tyler Baicar
When a memory error, CPU error, PCIe error, or other type of hardware error that's covered by RAS occurs, firmware should populate the shared GHES memory location with the proper GHES structures to notify the OS of the error. For example, platforms that implement firmware first handling may impleme

[PATCH V16 04/11] efi: parse ARM processor error

2017-05-15 Thread Tyler Baicar
Add support for ARM Common Platform Error Record (CPER). UEFI 2.6 specification adds support for ARM specific processor error information to be reported as part of the CPER records. This provides more detail on for processor error logs. Signed-off-by: Tyler Baicar CC: Jonathan (Zhixiong) Zhang R

[PATCH V16 11/11] arm/arm64: KVM: add guest SEA support

2017-05-15 Thread Tyler Baicar
Currently external aborts are unsupported by the guest abort handling. Add handling for SEAs so that the host kernel reports SEAs which occur in the guest kernel. When an SEA occurs in the guest kernel, the guest exits and is routed to kvm_handle_guest_abort(). Prior to this patch, a print message

[PATCH V16 09/11] ras: acpi / apei: generate trace event for unrecognized CPER section

2017-05-15 Thread Tyler Baicar
The UEFI spec includes non-standard section type support in the Common Platform Error Record. This is defined in section N.2.3 of UEFI version 2.5. Currently if the CPER section's type (UUID) does not match any section type that the kernel knows how to parse, a trace event is not generated. Gener

[PATCH V16 10/11] trace, ras: add ARM processor error trace event

2017-05-15 Thread Tyler Baicar
Currently there are trace events for the various RAS errors with the exception of ARM processor type errors. Add a new trace event for such errors so that the user will know when they occur. These trace events are consistent with the ARM processor error section type defined in UEFI 2.6 spec section

[PATCH V16 08/11] efi: print unrecognized CPER section

2017-05-15 Thread Tyler Baicar
UEFI spec allows for non-standard section in Common Platform Error Record. This is defined in section N.2.3 of UEFI version 2.5. Currently if the CPER section's type (UUID) does not match with one of the section types that the kernel knows how to parse, the section is skipped. Therefore, user is n

[PATCH V16 06/11] acpi: apei: handle SEA notification type for ARMv8

2017-05-15 Thread Tyler Baicar
ARM APEI extension proposal added SEA (Synchronous External Abort) notification type for ARMv8. Add a new GHES error source handling function for SEA. If an error source's notification type is SEA, then this function can be registered into the SEA exception handler. That way GHES will parse and rep

[PATCH V16 03/11] cper: add timestamp print to CPER status printing

2017-05-15 Thread Tyler Baicar
The ACPI 6.1 spec added a timestamp to the generic error data entry structure. Print the timestamp out when printing out the error information. Signed-off-by: Tyler Baicar CC: Jonathan (Zhixiong) Zhang --- drivers/firmware/efi/cper.c | 26 ++ 1 file changed, 26 insertion

[PATCH V16 05/11] arm64: exception: handle Synchronous External Abort

2017-05-15 Thread Tyler Baicar
SEA exceptions are often caused by an uncorrected hardware error, and are handled when data abort and instruction abort exception classes have specific values for their Fault Status Code. When SEA occurs, before killing the process, report the error in the kernel logs. Update fault_info[] with spec

[PATCH V16 07/11] acpi: apei: panic OS with fatal error status block

2017-05-15 Thread Tyler Baicar
From: "Jonathan (Zhixiong) Zhang" Even if an error status block's severity is fatal, the kernel does not honor the severity level and panic. With the firmware first model, the platform could inform the OS about a fatal hardware error through the non-NMI GHES notification type. The OS should pani

[PATCH V16 02/11] ras: acpi/apei: cper: add support for generic data v3 structure

2017-05-15 Thread Tyler Baicar
The ACPI 6.1 spec adds a new revision of the generic error data entry structure. Add support to handle the new structure as well as properly verify and iterate through the generic data entries. Signed-off-by: Tyler Baicar CC: Jonathan (Zhixiong) Zhang --- drivers/acpi/apei/ghes.c| 11 +-

[PATCH V16 01/11] acpi: apei: read ack upon ghes record consumption

2017-05-15 Thread Tyler Baicar
A RAS (Reliability, Availability, Serviceability) controller may be a separate processor running in parallel with OS execution, and may generate error records for consumption by the OS. If the RAS controller produces multiple error records, then they may be overwritten before the OS has consumed th

[PATCH] efi/bgrt: skip efi_bgrt_init in case non-efi boot

2017-05-15 Thread Dave Young
Sabrina Dubroca reported an early panic below, it was introduced by commit 7b0a911478c7 ("efi/x86: Move the EFI BGRT init code to early init code") The cause is on this machine even for legacy boot firmware still provide the ACPI BGRT table which should be EFI only. Thus the garbage bgrt data caus

Re: [PATCH] x86/efi: Fix kexec kernel panic when efi=old_map is enabled

2017-05-15 Thread Dave Young
On 05/15/17 at 02:23pm, Matt Fleming wrote: > (Pulling in Dave, Mr. Kexec on EFI) > > On Mon, 08 May, at 12:25:23PM, Sai Praneeth Prakhya wrote: > > From: Sai Praneeth > > > > Booting kexec kernel with "efi=old_map" in kernel command line hits > > kernel panic as shown below. > > > > [0.001