Re: [PATCH v2 3/8] efi: Enumerate EFI_MEMORY_SP

2019-05-31 Thread Ard Biesheuvel
On Fri, 31 May 2019 at 01:13, Dan Williams wrote: > > UEFI 2.8 defines an EFI_MEMORY_SP attribute bit to augment the > interpretation of the EFI Memory Types as "reserved for a specific > purpose". The intent of this bit is to allow the OS to identify precious > or scarce memory resources and

Re: [PATCH V7 2/4] tpm: Reserve the TPM final events table

2019-05-31 Thread Joe Richey
On Mon, May 20, 2019 at 1:55 PM Matthew Garrett wrote: > > From: Matthew Garrett > > UEFI systems provide a boot services protocol for obtaining the TPM > event log, but this is unusable after ExitBootServices() is called. > Unfortunately ExitBootServices() itself triggers additional TPM events

Re: [PATCH v2 1/8] acpi: Drop drivers/acpi/hmat/ directory

2019-05-31 Thread Rafael J. Wysocki
On Friday, May 31, 2019 12:59:27 AM CEST Dan Williams wrote: > As a single source file object there is no need for the hmat enabling to > have its own directory. Well, I asked Keith to add that directory as the code in hmat.c is more related to mm than to the rest of the ACPI subsystem. Is

Re: [Bug 203761] New: efivar_ssdt_iter is subject to stack corruption when the input name_size is 0

2019-05-31 Thread Ard Biesheuvel
On Thu, 30 May 2019 at 18:04, wrote: > > https://bugzilla.kernel.org/show_bug.cgi?id=203761 > > Bug ID: 203761 >Summary: efivar_ssdt_iter is subject to stack corruption when > the input name_size is 0 >Product: EFI >Version:

Re: [PATCH v2 4/8] x86, efi: Reserve UEFI 2.8 Specific Purpose Memory for dax

2019-05-31 Thread Ard Biesheuvel
(cc Mike for memblock) On Fri, 31 May 2019 at 01:13, Dan Williams wrote: > > UEFI 2.8 defines an EFI_MEMORY_SP attribute bit to augment the > interpretation of the EFI Memory Types as "reserved for a special > purpose". > > The proposed Linux behavior for specific purpose memory is that it is >

Re: [PATCH v2 1/8] acpi: Drop drivers/acpi/hmat/ directory

2019-05-31 Thread Dan Williams
On Fri, May 31, 2019 at 1:24 AM Rafael J. Wysocki wrote: > > On Friday, May 31, 2019 12:59:27 AM CEST Dan Williams wrote: > > As a single source file object there is no need for the hmat enabling to > > have its own directory. > > Well, I asked Keith to add that directory as the code in hmat.c is

Re: [PATCH V7 0/4] Add support for crypto agile logs

2019-05-31 Thread Joe Richey
On Mon, May 20, 2019 at 1:56 PM Matthew Garrett wrote: > > Identical to previous version except without the KSAN workaround - Ard > has a better solution for that. I just tested this on x86_64 with the systemd-boot (previously gummiboot) bootloader. For context, this bootloader is essentially

Re: [PATCH v2 4/8] x86, efi: Reserve UEFI 2.8 Specific Purpose Memory for dax

2019-05-31 Thread Ard Biesheuvel
On Fri, 31 May 2019 at 17:28, Dan Williams wrote: > > On Fri, May 31, 2019 at 1:30 AM Ard Biesheuvel > wrote: > > > > (cc Mike for memblock) > > > > On Fri, 31 May 2019 at 01:13, Dan Williams wrote: > > > > > > UEFI 2.8 defines an EFI_MEMORY_SP attribute bit to augment the > > > interpretation

Re: [PATCH v2 4/8] x86, efi: Reserve UEFI 2.8 Specific Purpose Memory for dax

2019-05-31 Thread Dan Williams
On Fri, May 31, 2019 at 1:30 AM Ard Biesheuvel wrote: > > (cc Mike for memblock) > > On Fri, 31 May 2019 at 01:13, Dan Williams wrote: > > > > UEFI 2.8 defines an EFI_MEMORY_SP attribute bit to augment the > > interpretation of the EFI Memory Types as "reserved for a special > > purpose". > > >

[PATCH] x86/efi: fix a -Wtype-limits compilation warning

2019-05-31 Thread Qian Cai
Compiling a kernel with W=1 generates this warning, arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] Signed-off-by: Qian Cai --- arch/x86/platform/efi/quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Bug 203761] New: efivar_ssdt_iter is subject to stack corruption when the input name_size is 0

2019-05-31 Thread Matthew Garrett
On Fri, May 31, 2019 at 2:03 AM Ard Biesheuvel wrote: > > The input of name_size is signed long, gets compared against an unsigned > > long > > of a fixed size, then stored as a signed int (this is mostly okay because of > > the known max size), but it then gets passed to a function takes

Re: [PATCH v2 4/8] x86, efi: Reserve UEFI 2.8 Specific Purpose Memory for dax

2019-05-31 Thread Dan Williams
On Fri, May 31, 2019 at 8:30 AM Ard Biesheuvel wrote: > > On Fri, 31 May 2019 at 17:28, Dan Williams wrote: > > > > On Fri, May 31, 2019 at 1:30 AM Ard Biesheuvel > > wrote: > > > > > > (cc Mike for memblock) > > > > > > On Fri, 31 May 2019 at 01:13, Dan Williams > > > wrote: > > > > > > > >