Re: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support

2013-10-11 Thread Ingo Molnar
* Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Oct 10, 2013 at 07:45:21PM +0200, Ingo Molnar wrote: Also, the main question would be, what is the typical value for si-lfb_depth. 32 on almost all EFI systems? All around the map? Depends on what graphics state the EFI bootloader

Re: [PATCH 12/12] EFI: Runtime services virtual mapping

2013-10-11 Thread Dave Young
On 10/10/13 at 01:34pm, Matt Fleming wrote: On Thu, 10 Oct, at 10:58:28AM, Borislav Petkov wrote: On Thu, Oct 10, 2013 at 04:14:34PM +0800, Dave Young wrote: Even though I still have no idea why kernel text overlap with efi boot region, anyway map the un-overlapped part is necessary

Re: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support

2013-10-11 Thread Geert Uytterhoeven
On Thu, Oct 10, 2013 at 8:09 PM, Peter Jones pjo...@redhat.com wrote: INTN GetPixelElementSize ( IN EFI_PIXEL_BITMASK *PixelBits ) { INTN HighestPixel = -1; INTN BluePixel; INTN RedPixel; INTN GreenPixel; INTN RsvdPixel; BluePixel =

Re: [PATCH 12/12] EFI: Runtime services virtual mapping

2013-10-11 Thread Borislav Petkov
On Fri, Oct 11, 2013 at 02:24:37PM +0800, Dave Young wrote: But for current implementation from Boris, getting same mapping between diffrent kernel depends on same md order (same start and size for each one) How about using this mapping solution but at the same time for kexec kernel we also

Re: [PATCH 12/12] EFI: Runtime services virtual mapping

2013-10-11 Thread Matt Fleming
On Fri, 11 Oct, at 02:24:37PM, Dave Young wrote: For the boot efi_reserve_boot_services code, it's mainly for the SetVirtualAddressMap callback use, so boot regions should not be reused before SetVirtualAddressMap, but the overlapping happens before the efi_reserve_boot_services, isn't it a

Re: [PATCH 12/12] EFI: Runtime services virtual mapping

2013-10-11 Thread Dave Young
Matt, The kernel I referring is the boot kernel aka the 1st kernel, the boot loader is grub2 from Fedora 19. [sorry for top reply because of using webmail] - Original Message - From: Matt Fleming m...@console-pimps.org To: Dave Young dyo...@redhat.com Cc: Borislav Petkov

Re: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support

2013-10-11 Thread Matt Fleming
On Thu, 10 Oct, at 07:28:44PM, Ingo Molnar wrote: Btw., could we perhaps remap the whole framebuffer at init time, or is it too large? If early_ioremap() fails for whatever reason then that will emit a WARN_ON(), which will recurse in a fairly nasty way ... The framebuffer memory will be

[PATCH 0/2] EFI earlyprintk support

2013-10-11 Thread Matt Fleming
From: Matt Fleming matt.flem...@intel.com These two patches cleanup the #include linux/efi.h duplication and add support for earlyprintk=efi, which is the only way users can debug early boot crashes without special hardware. Matt Fleming (2): x86/efi: Include linux/efi.h in asm/efi.h

[PATCH 1/2] x86/efi: Include linux/efi.h in asm/efi.h

2013-10-11 Thread Matt Fleming
From: Matt Fleming matt.flem...@intel.com Every file that includes asm/efi.h also includes linux/efi.h. Just include linux/efi.h directly and avoid the duplication. Cc: H. Peter Anvin h...@zytor.com Cc: Thomas Gleixner t...@linutronix.de Suggested-by: Ingo Molnar mi...@kernel.org Signed-off-by:

Re: [PATCH 1/2] x86/efi: Include linux/efi.h in asm/efi.h

2013-10-11 Thread H. Peter Anvin
The patch description doesn't match what the patch does. We do not normally have the asm file include the linux file, which is what the patch seems to do. Matt Fleming m...@console-pimps.org wrote: From: Matt Fleming matt.flem...@intel.com Every file that includes asm/efi.h also includes

Re: [PATCH 1/2] x86/efi: Include linux/efi.h in asm/efi.h

2013-10-11 Thread Matt Fleming
On Fri, 11 Oct, at 08:25:26AM, H. Peter Anvin wrote: The patch description doesn't match what the patch does. Oh, bah. I see I wrote the patch description in a weird way. It should have said something like, Every file that includes asm/efi.h also includes linux/efi.h. Move the inclusion

[PATCH v3] efivars,efi-pstore: Hold off deletion of sysfs entry until, the scan is completed

2013-10-11 Thread Seiji Aguchi
Change from v2: - Move dynamic memory allocation to efi_pstore_read() before holding efivars-lock to protect entry-var.Data. - Access to entry-scanning while holding efivars-lock. - Move a comment about a returned value from efi_pstore_read_func() to efi_pstore_read() because size 0 case may

RE: [RFC][PATCH v2] efivars,efi-pstore: Hold off deletion of sysfs entry until the scan is completed

2013-10-11 Thread Seiji Aguchi
Matt, I submitted a v3 patch based on my comment below.. Seiji -Original Message- From: linux-efi-ow...@vger.kernel.org [mailto:linux-efi-ow...@vger.kernel.org] On Behalf Of Seiji Aguchi Sent: Wednesday, October 09, 2013 12:37 PM To: Matt Fleming Cc: linux-ker...@vger.kernel.org;

Re: [PATCH 12/12] EFI: Runtime services virtual mapping

2013-10-11 Thread Dave Young
CCing Peter Jones .., Peter, any idea about the grub related problem? On 10/11/13 at 09:42am, Dave Young wrote: Matt, The kernel I referring is the boot kernel aka the 1st kernel, the boot loader is grub2 from Fedora 19. [sorry for top reply because of using webmail] - Original