Re: [BUG] pstore: failed to load 76 record(s) from 'efi'

2013-10-23 Thread Madper Xie
It seems pstore dump the messages with a same guid. But when loading them, pstore check if they are exist by id in pstore_mkfile(): list_for_each_entry(pos, allpstore, list) { if (pos-type == type pos-id == id pos-psi == psi) {

Re: [PATCH 12/12] EFI: Runtime services virtual mapping

2013-10-23 Thread Borislav Petkov
On Wed, Oct 23, 2013 at 10:17:31AM +0800, Dave Young wrote: The reason is that I only pass runtime regions from 1st kernel to kexec kernel, your efi mapping function uses the region size to determin the virtual address from top to down. Because the passed-in md ranges in kexec kernel are

Re: [PATCH 12/12] EFI: Runtime services virtual mapping

2013-10-23 Thread Matthew Garrett
On Wed, Oct 23, 2013 at 02:25:31PM +0200, Borislav Petkov wrote: Matt, didn't you question the need to keep boot services regions mapped indefinitely? What was the story there? We shouldn't need boot services regions to be mapped after SetVirtualAddressMap is called. -- Matthew Garrett |

Re: [PATCH 12/12] EFI: Runtime services virtual mapping

2013-10-23 Thread Dave Young
On 10/23/13 at 02:25pm, Borislav Petkov wrote: On Wed, Oct 23, 2013 at 10:17:31AM +0800, Dave Young wrote: The reason is that I only pass runtime regions from 1st kernel to kexec kernel, your efi mapping function uses the region size to determin the virtual address from top to down. Because

Re: [PATCH 12/12] EFI: Runtime services virtual mapping

2013-10-23 Thread Borislav Petkov
On Wed, Oct 23, 2013 at 08:51:31PM +0800, Dave Young wrote: In kexed 2nd kernel, phys_start_b need to be mapped to virt_start_b Simply use efi_map_region from your patch does not work because it will map phys_start_b to a different virt address, isn't it? Oh ok, in the second kernel we're not

[PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
pstore try to find duplicate entries by check both ID, type and psi. They are not really enough for efi backend. dumped vars always have the same type, psi and ID. like follows: dump-type0-9-1-1382511508-C-cfc8fc79-be2e-4ddc-97f0-9f98bfe298a0

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
richard.weinber...@gmail.com writes: On Wed, Oct 23, 2013 at 4:55 PM, Madper Xie c...@redhat.com wrote: pstore try to find duplicate entries by check both ID, type and psi. They are not really enough for efi backend. dumped vars always have the same type, psi and ID. like follows:

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Tony Luck
On Wed, Oct 23, 2013 at 7:55 AM, Madper Xie c...@redhat.com wrote: The duplicate entries won't appear in pstorefs. And a complain will be print -- pstore: failed to load 76 record(s) from 'efi' Maybe I don't quite get this - but it sounds like you have a whole lot of entries using up space in

Re: [PATCH] pstore: avoid incorrectly mark entry as duplicate

2013-10-23 Thread Madper Xie
tony.l...@gmail.com writes: On Wed, Oct 23, 2013 at 7:55 AM, Madper Xie c...@redhat.com wrote: The duplicate entries won't appear in pstorefs. And a complain will be print -- pstore: failed to load 76 record(s) from 'efi' Maybe I don't quite get this - but it sounds like you have a whole