On 10/29/13 at 10:40am, Borislav Petkov wrote:
On Tue, Oct 29, 2013 at 02:47:20PM +0800, Dave Young wrote:
Boris, could you update the comment? it says below: update that memory
descriptor with the virtual address obtained from ioremap().
Logiclly your patch should update it, then my
1. checking type, id, psi, count and timespec when finding duplicate entries.
2. adding count and timestamp for differentiating.
Madper Xie (2):
pstore: avoid incorrectly mark entry as duplicate
pstore: Differentiating names by adding count and timestamp
fs/pstore/inode.c | 35
From: Madper Xie bbbo...@gmail.com
pstore denominates dumped file as type-psname-id. it makes many file have
the same name if there are many entries in backend have the same id.
So adding count and timestamp to file name for differentiating.
Signed-off-by: Madper Xie c...@redhat.com
---
On Wed, Oct 30, 2013 at 05:32:27PM +0800, Dave Young wrote:
Boris, thanks for update, it's very elaborate, I have still wonder if
32 bit case should be mentioned as well.
Ah, so that's why is mfleming bugging me about it on IRC :)
Well, I left out the 32-bit case simply because I don't think
On Wed, Oct 30, 2013 at 10:03:49AM +0800, Dave Young wrote:
Will try, but please keep the posted patches in mailing list up-to-date,
Would you like me to send them to you privately?
I'm an old-fashioned person, do not tend to depend on git.
Really? You should change that - you're missing out
On Mon, 14 Oct, at 03:37:17PM, Geyslan G. Bem wrote:
This reorganization:
Adds 'attrsize' variable to make the code cleaner and more
understandable, replacing all 'sizeof(attributes)'.
Removes 'bytes' prior assignment due this new approach.
Uses 'memdup_user' instead 'kmalloc' +
2013/10/30 Matt Fleming m...@console-pimps.org:
On Mon, 14 Oct, at 03:37:17PM, Geyslan G. Bem wrote:
This reorganization:
Adds 'attrsize' variable to make the code cleaner and more
understandable, replacing all 'sizeof(attributes)'.
Removes 'bytes' prior assignment due this new approach.
On Fri, 18 Oct, at 10:30:58PM, Seiji Aguchi wrote:
The scanning and deleting logic is still needed. In case an entry(A)
is found, the pointer is saved to psi-data. And efi_pstore_read()
passes the entry(A) to a pstore filesystem by releasing
__efivars-lock.
And then, the pstore filesystem
-Original Message-
From: Madper Xie [mailto:c...@redhat.com]
Sent: Wednesday, October 30, 2013 5:45 AM
To: tony.l...@intel.com; keesc...@chromium.org; ccr...@android.com;
an...@enomsg.org; Seiji Aguchi
Cc: linux-efi@vger.kernel.org; linux-ker...@vger.kernel.org;
On Wed, 30 Oct, at 10:44:16AM, Geyslan Gregório Bem wrote:
Do you want that I undo that? I aggre that the variable use only
reduces the line code.
Yes please.
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-efi in
the body
seiji.agu...@hds.com writes:
-Original Message-
From: Madper Xie [mailto:c...@redhat.com]
Sent: Wednesday, October 30, 2013 5:45 AM
To: tony.l...@intel.com; keesc...@chromium.org; ccr...@android.com;
an...@enomsg.org; Seiji Aguchi
Cc: linux-efi@vger.kernel.org;
This reorganization:
Removes useless 'bytes' prior assignment.
Uses 'memdup_user' instead 'kmalloc' + 'copy_from_user'.
Signed-off-by: Geyslan G. Bem geys...@gmail.com
---
fs/efivarfs/file.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/fs/efivarfs/file.c
1. checking type, id, psi, count and timespec when finding duplicate entries.
2. adding count and timestamp for differentiating.
Ah - I was expecting that the backend driver would have a unique id for
each record stored ... but is seems that this isn't true for efivars.
I just tried this
Ah - I was expecting that the backend driver would have a unique id for
each record stored ... but is seems that this isn't true for efivars.
So, do you mean efivars should fix to use the id in a proper way?
I acked Madper's patch 2/2 earlier today, but when I look at your test result,
I'm
So, do you mean efivars should fix to use the id in a proper way?
It would avoid the need for all these tests, and additions to the filename to
guarantee
uniqueness.
Not sure what options efivars has to create a unique, persistent id for each
record. It's a fundamental part of how ERST works
On 10/30/13 at 11:47am, Borislav Petkov wrote:
On Wed, Oct 30, 2013 at 10:03:49AM +0800, Dave Young wrote:
Will try, but please keep the posted patches in mailing list up-to-date,
Would you like me to send them to you privately?
Thanks, do not bother to send me privately I can get it from
On 10/31/13 at 10:04am, Dave Young wrote:
On 10/30/13 at 11:47am, Borislav Petkov wrote:
On Wed, Oct 30, 2013 at 10:03:49AM +0800, Dave Young wrote:
Will try, but please keep the posted patches in mailing list up-to-date,
Would you like me to send them to you privately?
Thanks, do
tony.l...@intel.com writes:
So, do you mean efivars should fix to use the id in a proper way?
It would avoid the need for all these tests, and additions to the filename to
guarantee
uniqueness.
Not sure what options efivars has to create a unique, persistent id for each
record. It's a
On 10/30/2013 07:07 PM, Dave Young wrote:
On 10/31/13 at 10:04am, Dave Young wrote:
On 10/30/13 at 11:47am, Borislav Petkov wrote:
On Wed, Oct 30, 2013 at 10:03:49AM +0800, Dave Young wrote:
Will try, but please keep the posted patches in mailing list up-to-date,
Would you like me to send
19 matches
Mail list logo
