Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-01 Thread Borislav Petkov
On Sat, Feb 28, 2015 at 06:40:39PM -0800, Yinghai Lu wrote: oh, no. the offending commit already got into linus tree. We're working on it, follow this thread: http://lkml.kernel.org/r/1424929021.10337.24.ca...@intel.com -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-01 Thread Yinghai Lu
On Sun, Mar 1, 2015 at 7:23 AM, Ingo Molnar mi...@kernel.org wrote: I think that's a different bug. parse_kaslr_setup() is simply bogus, it does: kaslr_enabled = (bool)(pa_data + sizeof(struct setup_data)); which makes no sense whatsoever: it randomly enables (or disables,

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-01 Thread Borislav Petkov
On Sun, Mar 01, 2015 at 04:23:51PM +0100, Ingo Molnar wrote: I think that's a different bug. parse_kaslr_setup() is simply bogus, it does: kaslr_enabled = (bool)(pa_data + sizeof(struct setup_data)); Well, we found that while debugging the other issue too:

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-01 Thread Borislav Petkov
On Sun, Mar 01, 2015 at 11:27:48AM -0800, Yinghai Lu wrote: other 7 should also address the problem in http://lkml.kernel.org/r/1424929021.10337.24.ca...@intel.com No, they don't: [0.00] parse_setup_data: data: 0x2206e50 (va: ff200e50) { next: 0x0, type: 0x0, len: 16,

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-01 Thread Ingo Molnar
(Cc:-ed Jiri and Kees as well.) * Borislav Petkov b...@suse.de wrote: On Sat, Feb 28, 2015 at 06:40:39PM -0800, Yinghai Lu wrote: oh, no. the offending commit already got into linus tree. We're working on it, follow this thread:

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-01 Thread Yinghai Lu
On Sun, Mar 1, 2015 at 11:49 AM, Borislav Petkov b...@suse.de wrote: On Sun, Mar 01, 2015 at 11:27:48AM -0800, Yinghai Lu wrote: other 7 should also address the problem in http://lkml.kernel.org/r/1424929021.10337.24.ca...@intel.com No, they don't: [0.00] parse_setup_data: data:

Re: [PATCH 1/8] x86, kaslr: get kaslr_enabled back correctly

2015-03-01 Thread Borislav Petkov
On Sun, Mar 01, 2015 at 12:24:08PM -0800, Yinghai Lu wrote: static allocation in misc.c can not be used to kernel/head_64.S stage safely. Correct. One possibility that works is sticking it right below LOAD_PHYSICAL_ADDR: +static void add_kaslr_setup_data(struct boot_params *params, +