Re: [PATCH V13 09/10] trace, ras: add ARM processor error trace event

2017-03-21 Thread Baicar, Tyler
Hello Xie XiuQi, On 3/21/2017 8:48 PM, Xie XiuQi wrote: Reviewed-by: Xie XiuQi Thank you! Tyler On 2017/3/22 6:47, Tyler Baicar wrote: Currently there are trace events for the various RAS errors with the exception of ARM processor type errors. Add a new trace event for such errors so that t

Re: [PATCH V13 09/10] trace, ras: add ARM processor error trace event

2017-03-21 Thread Xie XiuQi
Reviewed-by: Xie XiuQi On 2017/3/22 6:47, Tyler Baicar wrote: > Currently there are trace events for the various RAS > errors with the exception of ARM processor type errors. > Add a new trace event for such errors so that the user > will know when they occur. These trace events are > consistent

Re: [PATCH V11 10/10] arm/arm64: KVM: add guest SEA support

2017-03-21 Thread Xiongfeng Wang
Hi James, > Guests are a special case as QEMU may never access the faulty memory itself, > so > it won't receive the 'late' signal. It looks like ARM/arm64 KVM lacks support > for KVM_PFN_ERR_HWPOISON which sends SIGBUS from KVM's fault-handling code. I > have patches to add support for this whi

[PATCH V13 00/10] Add UEFI 2.6 and ACPI 6.1 updates for RAS on ARM64

2017-03-21 Thread Tyler Baicar
When a memory error, CPU error, PCIe error, or other type of hardware error that's covered by RAS occurs, firmware should populate the shared GHES memory location with the proper GHES structures to notify the OS of the error. For example, platforms that implement firmware first handling may impleme

[PATCH V13 01/10] acpi: apei: read ack upon ghes record consumption

2017-03-21 Thread Tyler Baicar
A RAS (Reliability, Availability, Serviceability) controller may be a separate processor running in parallel with OS execution, and may generate error records for consumption by the OS. If the RAS controller produces multiple error records, then they may be overwritten before the OS has consumed th

[PATCH V13 03/10] efi: parse ARM processor error

2017-03-21 Thread Tyler Baicar
Add support for ARM Common Platform Error Record (CPER). UEFI 2.6 specification adds support for ARM specific processor error information to be reported as part of the CPER records. This provides more detail on for processor error logs. Signed-off-by: Tyler Baicar CC: Jonathan (Zhixiong) Zhang R

[PATCH V13 10/10] arm/arm64: KVM: add guest SEA support

2017-03-21 Thread Tyler Baicar
Currently external aborts are unsupported by the guest abort handling. Add handling for SEAs so that the host kernel reports SEAs which occur in the guest kernel. Signed-off-by: Tyler Baicar --- arch/arm/include/asm/kvm_arm.h | 10 + arch/arm/include/asm/system_misc.h | 5 +

[PATCH V13 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1

2017-03-21 Thread Tyler Baicar
Currently when a RAS error is reported it is not timestamped. The ACPI 6.1 spec adds the timestamp field to the generic error data entry v3 structure. The timestamp of when the firmware generated the error is now being reported. Signed-off-by: Tyler Baicar CC: Jonathan (Zhixiong) Zhang Reviewed-

[PATCH V13 08/10] ras: acpi / apei: generate trace event for unrecognized CPER section

2017-03-21 Thread Tyler Baicar
UEFI spec allows for non-standard section in Common Platform Error Record. This is defined in section N.2.3 of UEFI version 2.5. Currently if the CPER section's type (UUID) does not match with any section type that the kernel knows how to parse, trace event is not generated for such section. And t

[PATCH V13 05/10] acpi: apei: handle SEA notification type for ARMv8

2017-03-21 Thread Tyler Baicar
ARM APEI extension proposal added SEA (Synchronous External Abort) notification type for ARMv8. Add a new GHES error source handling function for SEA. If an error source's notification type is SEA, then this function can be registered into the SEA exception handler. That way GHES will parse and rep

[PATCH V13 09/10] trace, ras: add ARM processor error trace event

2017-03-21 Thread Tyler Baicar
Currently there are trace events for the various RAS errors with the exception of ARM processor type errors. Add a new trace event for such errors so that the user will know when they occur. These trace events are consistent with the ARM processor error section type defined in UEFI 2.6 spec section

[PATCH V13 07/10] efi: print unrecognized CPER section

2017-03-21 Thread Tyler Baicar
UEFI spec allows for non-standard section in Common Platform Error Record. This is defined in section N.2.3 of UEFI version 2.5. Currently if the CPER section's type (UUID) does not match with one of the section types that the kernel knows how to parse, the section is skipped. Therefore, user is n

[PATCH V13 06/10] acpi: apei: panic OS with fatal error status block

2017-03-21 Thread Tyler Baicar
From: "Jonathan (Zhixiong) Zhang" Even if an error status block's severity is fatal, the kernel does not honor the severity level and panic. With the firmware first model, the platform could inform the OS about a fatal hardware error through the non-NMI GHES notification type. The OS should pani

[PATCH V13 04/10] arm64: exception: handle Synchronous External Abort

2017-03-21 Thread Tyler Baicar
SEA exceptions are often caused by an uncorrected hardware error, and are handled when data abort and instruction abort exception classes have specific values for their Fault Status Code. When SEA occurs, before killing the process, report the error in the kernel logs. Update fault_info[] with spec

Re: [PATCH V12 05/10] acpi: apei: handle SEA notification type for ARMv8

2017-03-21 Thread Baicar, Tyler
Hello James, On 3/17/2017 10:43 AM, James Morse wrote: On 06/03/17 20:44, Tyler Baicar wrote: ARM APEI extension proposal added SEA (Synchronous External Abort) notification type for ARMv8. Add a new GHES error source handling function for SEA. If an error source's notification type is SEA, th

[PATCH v2] efifb: avoid reconfiguration of BAR that covers the framebuffer

2017-03-21 Thread Ard Biesheuvel
On UEFI systems, the PCI subsystem is enumerated by the firmware, and if a graphical framebuffer is exposed by a PCI device, its base address and size are exposed to the OS via the Graphics Output Protocol (GOP). On arm64 PCI systems, the entire PCI hierarchy is reconfigured from scratch at boot.

Re: [PATCH v2] efifb: avoid reconfiguration of BAR that covers the framebuffer

2017-03-21 Thread Ard Biesheuvel
On 21 March 2017 at 19:16, Ard Biesheuvel wrote: > On UEFI systems, the PCI subsystem is enumerated by the firmware, > and if a graphical framebuffer is exposed by a PCI device, its base > address and size are exposed to the OS via the Graphics Output > Protocol (GOP). > > On arm64 PCI systems, th

Re: [PATCH] efifb: avoid reconfiguration of BAR that covers the framebuffer

2017-03-21 Thread Lorenzo Pieralisi
On Tue, Mar 21, 2017 at 11:59:16AM +, Ard Biesheuvel wrote: [...] > >> +static void efifb_fixup_resources(struct pci_dev *dev) > >> +{ > >> + u64 fb_base = screen_info.lfb_base; > >> + u64 fb_size = screen_info.lfb_size; > >> + int i; > >> + > >> + if (resource_found || screen

Re: [PATCH] efi/libstub: arm/arm64: make debug prints dependent on efi=debug

2017-03-21 Thread Ard Biesheuvel
On 21 March 2017 at 11:58, Mark Rutland wrote: > On Mon, Mar 20, 2017 at 08:57:05PM +, Ard Biesheuvel wrote: >> The EFI stub currently prints a number of diagnostic messages that do >> not carry a lot of information. Since these prints are not controlled >> by 'loglevel' or other command line

Re: [PATCH] efifb: avoid reconfiguration of BAR that covers the framebuffer

2017-03-21 Thread Ard Biesheuvel
On 21 March 2017 at 11:54, Lorenzo Pieralisi wrote: > [+Bjorn] > > On Mon, Mar 20, 2017 at 10:13:57PM +, Ard Biesheuvel wrote: >> On UEFI systems, the PCI subsystem is enumerated by the firmware, >> and if a graphical framebuffer is exposed by a PCI device, its base >> address and size are exp

Re: [PATCH] efi/libstub: arm/arm64: make debug prints dependent on efi=debug

2017-03-21 Thread Mark Rutland
On Mon, Mar 20, 2017 at 08:57:05PM +, Ard Biesheuvel wrote: > The EFI stub currently prints a number of diagnostic messages that do > not carry a lot of information. Since these prints are not controlled > by 'loglevel' or other command line parameters, and since they appear on > the EFI frameb

Re: [PATCH] efifb: avoid reconfiguration of BAR that covers the framebuffer

2017-03-21 Thread Lorenzo Pieralisi
[+Bjorn] On Mon, Mar 20, 2017 at 10:13:57PM +, Ard Biesheuvel wrote: > On UEFI systems, the PCI subsystem is enumerated by the firmware, > and if a graphical framebuffer is exposed by a PCI device, its base > address and size are exposed to the OS via the Graphics Output > Protocol (GOP). > >

Re: kexec regression since 4.9 caused by efi

2017-03-21 Thread Dave Young
On 03/20/17 at 10:14am, Dave Young wrote: > On 03/17/17 at 01:32pm, Matt Fleming wrote: > > On Fri, 17 Mar, at 10:09:51AM, Dave Young wrote: > > > > > > Matt, I think it should be fine although I think the md type checking in > > > efi_mem_desc_lookup() is causing confusion and not easy to underst