[PATCH V2] x86/efi: fix kernel param add_efi_memmap regression

2017-12-15 Thread Dave Young
'add_efi_memmap' is an early param, but do_add_efi_memmap() has no chance to run because the code path is before parse_early_param(). I believe it worked when the param was introduced but probably later some other changes caused the wrong order and nobody noticed it. Move efi_memblock_x86_reserve_

Re: [PATCH 1/2] kconfig: use bool instead of boolean for type definition attributes, again

2017-12-15 Thread Greg Kroah-Hartman
On Sat, Dec 16, 2017 at 12:38:01AM +0900, Masahiro Yamada wrote: > Commit 6341e62b212a ("kconfig: use bool instead of boolean for type > definition attributes") did treewide replacement of 'boolean', and > also mentioned the keyword 'boolean' would be dropped later on. > > Some years have passed,

Re: [PATCH] efi: make EFI a menuconfig to ease disabling it all

2017-12-15 Thread Austin S. Hemmelgarn
On 2017-12-15 12:24, Vincent Legoll wrote: Hello, This looks fine to me. Ard? Doesn't this break existing configs? Would adding a "default yes" on the new menuconfig be OK. If yes, I'd respin it for a v2 Alternatively, would it not make some degree of sense to just turn the CONFIG_EFI sy

Re: [PATCH] efi: make EFI a menuconfig to ease disabling it all

2017-12-15 Thread Vincent Legoll
Hello, >> This looks fine to me. Ard? > > Doesn't this break existing configs? Would adding a "default yes" on the new menuconfig be OK. If yes, I'd respin it for a v2 -- Vincent Legoll -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majord..

Re: [PATCH] efi: make EFI a menuconfig to ease disabling it all

2017-12-15 Thread Ard Biesheuvel
On 15 December 2017 at 16:19, Matt Fleming wrote: > On Sat, 09 Dec, at 04:52:52PM, Vincent Legoll wrote: >> No need to get into the submenu to disable all related >> config entries. >> >> This makes it easier to disable all EFI config options >> without entering the submenu. It will also enable on

[PATCH 1/2] kconfig: use bool instead of boolean for type definition attributes, again

2017-12-15 Thread Masahiro Yamada
Commit 6341e62b212a ("kconfig: use bool instead of boolean for type definition attributes") did treewide replacement of 'boolean', and also mentioned the keyword 'boolean' would be dropped later on. Some years have passed, but it has not happened yet. Meanwhile, some new instances have come up.

Re: [PATCH] efi: make EFI a menuconfig to ease disabling it all

2017-12-15 Thread Matt Fleming
On Sat, 09 Dec, at 04:52:52PM, Vincent Legoll wrote: > No need to get into the submenu to disable all related > config entries. > > This makes it easier to disable all EFI config options > without entering the submenu. It will also enable one > to see that en/dis-abled state from the outside menu.

Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

2017-12-15 Thread Matt Fleming
On Thu, 14 Dec, at 06:41:19PM, Dave Young wrote: > On 11/30/17 at 01:23pm, Dave Young wrote: > > 'add_efi_memmap' is an early param, but do_add_efi_memmap() has no > > chance to run because the code path is before parse_early_param(). > > I believe it worked when the param was introduced but probab

Re: [PATCH] efi: Use PTR_ERR_OR_ZERO()

2017-12-15 Thread Matt Fleming
On Tue, 28 Nov, at 10:39:37PM, Vasyl Gomonovych wrote: > Fix ptr_ret.cocci warnings: > drivers/firmware/efi/efi.c:610:8-14: WARNING: PTR_ERR_OR_ZERO can be used > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by:

[PATCH 4.4 013/105] efi: Move some sysfs files to be read-only by root

2017-12-15 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit af97a77bc01ce49a466f9d4c0125479e2e2230b6 upstream. Thanks to the scripts/leaking_addresses.pl script, it was found that some EFI values should not be readable by non-r

[PATCH 4.4 103/105] Revert "x86/mm/pat: Ensure cpa->pfn only contains page frame numbers"

2017-12-15 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman This reverts commit 87e2bd898d3a79a8c609f183180adac47879a2a4 which is commit edc3b9129cecd0f0857112136f5b8b1bc1d45918 upstream. Turns there was too many other issues with thi

[PATCH 4.4 101/105] Revert "x86/efi: Build our own page table structures"

2017-12-15 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman This reverts commit 36e0f05afd4e1d09fd47936761a502aedbc50649 which is commit 67a9108ed4313b85a9c53406d80dc1ae3f8c3e36 upstream. Turns there was too many other issues with thi

[PATCH 4.4 102/105] Revert "x86/efi: Hoist page table switching code into efi_call_virt()"

2017-12-15 Thread Greg Kroah-Hartman
4.4-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman This reverts commit b73adb60852034d84092d123b323196ca42529cd which is commit c9f2a9a65e4855b74d92cdad688f6ee4a1a323ff upstream. Turns there was too many other issues with thi

[PATCH 3.18 11/64] efi: Move some sysfs files to be read-only by root

2017-12-15 Thread Greg Kroah-Hartman
3.18-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit af97a77bc01ce49a466f9d4c0125479e2e2230b6 upstream. Thanks to the scripts/leaking_addresses.pl script, it was found that some EFI values should not be readable by non-

Re: arm64 crashkernel fails to boot on acpi-only machines due to ACPI regions being no longer mapped as NOMAP

2017-12-15 Thread Ard Biesheuvel
On 15 December 2017 at 09:59, AKASHI Takahiro wrote: > On Wed, Dec 13, 2017 at 12:17:22PM +, Ard Biesheuvel wrote: >> On 13 December 2017 at 12:16, AKASHI Takahiro >> wrote: >> > On Wed, Dec 13, 2017 at 10:49:27AM +, Ard Biesheuvel wrote: >> >> On 13 December 2017 at 10:26, AKASHI Takahir

Re: arm64 crashkernel fails to boot on acpi-only machines due to ACPI regions being no longer mapped as NOMAP

2017-12-15 Thread AKASHI Takahiro
On Wed, Dec 13, 2017 at 12:17:22PM +, Ard Biesheuvel wrote: > On 13 December 2017 at 12:16, AKASHI Takahiro > wrote: > > On Wed, Dec 13, 2017 at 10:49:27AM +, Ard Biesheuvel wrote: > >> On 13 December 2017 at 10:26, AKASHI Takahiro > >> wrote: > >> > Bhupesh, Ard, > >> > > >> > On Wed, De