Re: [efi:next 15/15] drivers/firmware/efi/libstub/efi-stub-helper.c:425:3: warning: cast to pointer from integer of different size

2018-07-13 Thread Lukas Wunner
On Sat, Jul 14, 2018 at 04:57:36AM +0800, kbuild test robot wrote: > vim +425 drivers/firmware/efi/libstub/efi-stub-helper.c > >415 >416static efi_status_t efi_open_volume(efi_system_table_t > *sys_table_arg, >417

[efi:next 15/15] drivers/firmware/efi/libstub/efi-stub-helper.c:425:3: warning: cast to pointer from integer of different size

2018-07-13 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next head: 44ae6f59573c50381b7ee5042bd9a0b19f6d6979 commit: 44ae6f59573c50381b7ee5042bd9a0b19f6d6979 [15/15] efi: Deduplicate efi_open_volume() config: i386-randconfig-x009-201827 (attached as .config) compiler: gcc-7 (Debian

Re: [RFC PATCH 0/2] efi: add contents of LinuxExtraArgs EFI var to command line

2018-07-13 Thread Geoff Levand
Hi Will, On 07/13/2018 02:56 AM, Will Deacon wrote: > On Fri, Jul 13, 2018 at 08:15:26AM +0200, Ard Biesheuvel wrote: > >> This is not my call to make, but I would be much less averse to this >> being merged if we could agree upfront on an expiration time of, say, >> 2 years (or more?), after

Re: [PATCH v1] efivars: Call guid_parse() against guid_t type of variable

2018-07-13 Thread Ard Biesheuvel
On 13 July 2018 at 15:10, Andy Shevchenko wrote: > uuid_le_to_bin() is deprecated API and take into consideration that variable, > to where we store parsed data, is type of guid_t we switch to guid_parse() > for sake of consistency. > > While here, add error checking to it. > > Signed-off-by:

Re: EFI mixed mode fix for v4.18

2018-07-13 Thread Ard Biesheuvel
Please don't remove cc's - I added them for a reason. On 13 July 2018 at 15:54, youling 257 wrote: > I tried Revert "mm/page_poison.c: make early_page_poison_param() > __init"Revert "mm/kmemleak.c: make kmemleak_boot_config() > __init" Revert "mm/page_owner.c: make early_page_owner_param() >

Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-13 Thread Ard Biesheuvel
On 13 July 2018 at 11:57, Lukas Wunner wrote: > On Thu, Jul 12, 2018 at 02:21:48PM +0200, Ard Biesheuvel wrote: >> Patch #2 merges the remaining 32/64-bit specific parts of the setup_efi_pci >> routine. >> >> Patches #3 and #4 do the same for the UGA draw protocol discovery routines. >> >> Patch

Re: EFI mixed mode fix for v4.18

2018-07-13 Thread Ard Biesheuvel
(+ Sai) On 13 July 2018 at 13:56, youling 257 wrote: > https://github.com/torvalds/linux/commit/03781e40890c18bdea40092355b61431d0073c1d > x86_64 kernel and"efi=old_map" disabled because, x86_32 and efi=old_map do > not use > efi_pgd, rather they use swapper_pg_dir. > > so what x86_64 kernel and

Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-13 Thread Ard Biesheuvel
On 13 July 2018 at 15:29, Ingo Molnar wrote: > > * Lukas Wunner wrote: > >> --- a/drivers/firmware/efi/libstub/efi-stub-helper.c >> +++ b/drivers/firmware/efi/libstub/efi-stub-helper.c >> @@ -413,6 +413,32 @@ static efi_status_t efi_file_close(void *handle) >> return

Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-13 Thread Ingo Molnar
* Lukas Wunner wrote: > --- a/drivers/firmware/efi/libstub/efi-stub-helper.c > +++ b/drivers/firmware/efi/libstub/efi-stub-helper.c > @@ -413,6 +413,32 @@ static efi_status_t efi_file_close(void *handle) > return efi_call_proto(efi_file_handle, close, handle); > } > > +static

[PATCH v1] efivars: Call guid_parse() against guid_t type of variable

2018-07-13 Thread Andy Shevchenko
uuid_le_to_bin() is deprecated API and take into consideration that variable, to where we store parsed data, is type of guid_t we switch to guid_parse() for sake of consistency. While here, add error checking to it. Signed-off-by: Andy Shevchenko --- fs/efivarfs/inode.c | 4 +++- 1 file

Re: [RFC PATCH 0/2] efi: add contents of LinuxExtraArgs EFI var to command line

2018-07-13 Thread Ian Campbell
On Fri, 2018-07-13 at 08:15 +0200, Ard Biesheuvel wrote: > I still think we should not be using DMI, though. Would a quirk be acceptable if keyed on something other than DMI? Are there some other options, perhaps some property of the ACPI tables proper? Something which can be queried from UEFI

Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-13 Thread Lukas Wunner
On Thu, Jul 12, 2018 at 02:21:48PM +0200, Ard Biesheuvel wrote: > Patch #2 merges the remaining 32/64-bit specific parts of the setup_efi_pci > routine. > > Patches #3 and #4 do the same for the UGA draw protocol discovery routines. > > Patch #6 helps unused code paths to be optimized away on

Re: [RFC PATCH 0/2] efi: add contents of LinuxExtraArgs EFI var to command line

2018-07-13 Thread Will Deacon
On Fri, Jul 13, 2018 at 08:15:26AM +0200, Ard Biesheuvel wrote: > On 13 July 2018 at 00:22, Geoff Levand wrote: > > Hi Ard, > > > > On 07/04/2018 08:49 AM, Ard Biesheuvel wrote: > >> efi/libstub: taken contents of LinuxExtraArgs UEFI variable into > >> account > > > > To me this seems an

Re: [RFC PATCH 0/2] efi: add contents of LinuxExtraArgs EFI var to command line

2018-07-13 Thread Ard Biesheuvel
On 13 July 2018 at 00:22, Geoff Levand wrote: > Hi Ard, > > On 07/04/2018 08:49 AM, Ard Biesheuvel wrote: >> efi/libstub: taken contents of LinuxExtraArgs UEFI variable into >> account > > To me this seems an overly complicated interface to the kernel, and > still doesn't in itself solve