RE: [[efi boot control]] efibc: Replace variable set function in notifier call

2019-06-19 Thread Tian, Baofeng
Hi, Reviewers and all Could you help review below changes? and let me know your opinion. Jeremy, could you help add Matt Fleming into the loop to review this change? Thanks Tim -Original Message- From: Tian, Baofeng Sent: Wednesday, June 12, 2019 4:18 PM To: ard.biesheu...@linaro.org;

Re: [PATCH] drivers: firmware: efi: fix gcc warning -Wint-conversion

2019-06-19 Thread Matthew Garrett
On Wed, Jun 19, 2019 at 2:55 AM Ard Biesheuvel wrote: > > (+ Jarkko, tpmdd, Matthew) > > On Sat, 15 Jun 2019 at 06:02, Hariprasad Kelam > wrote: > > > > This patch fixes below warning > > > > drivers/firmware/efi/tpm.c:78:38: warning: passing argument 1 of > > ‘tpm2_calc_event_log_size’ makes

Re: [PATCH AUTOSEL 4.19 17/49] efi/x86/Add missing error handling to old_memmap 1:1 mapping code

2019-06-19 Thread Sasha Levin
On Sun, Jun 09, 2019 at 08:14:29PM +0200, Ard Biesheuvel wrote: On Sat, 8 Jun 2019 at 13:43, Sasha Levin wrote: From: Gen Zhang [ Upstream commit 4e78921ba4dd0aca1cc89168f45039add4183f8e ] The old_memmap flow in efi_call_phys_prolog() performs numerous memory allocations, and either does

RE: [PATCH v2] x86/efi: fix a -Wtype-limits compilation warning

2019-06-19 Thread Prakhya, Sai Praneeth
> Compiling a kernel with W=1 generates this warning, > > arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned > expression >= 0 is always true [-Wtype-limits] > > Fixes: 3425d934fc03 ("efi/x86: Handle page faults occurring while running EFI > runtime services") >

[PATCH v2] x86/efi: fix a -Wtype-limits compilation warning

2019-06-19 Thread Qian Cai
Compiling a kernel with W=1 generates this warning, arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] Fixes: 3425d934fc03 ("efi/x86: Handle page faults occurring while running EFI runtime services") Signed-off-by: Qian Cai ---

Re: [PATCH] drivers: firmware: efi: fix gcc warning -Wint-conversion

2019-06-19 Thread Ard Biesheuvel
(+ Jarkko, tpmdd, Matthew) On Sat, 15 Jun 2019 at 06:02, Hariprasad Kelam wrote: > > This patch fixes below warning > > drivers/firmware/efi/tpm.c:78:38: warning: passing argument 1 of > ‘tpm2_calc_event_log_size’ makes pointer from integer without a cast > [-Wint-conversion] > > Signed-off-by: