Re: [PATCH 12/17] Add proper definitions for some EFI function pointers.

2013-08-09 Thread Mark Salter
On Tue, 2013-08-06 at 20:45 -0700, Roy Franz wrote: The x86/AMD64 EFI stubs must us a call wrapper to convert between the Linux and EFI ABIs, so void pointers are sufficient. For ARM, the ABIs are compatible, so we can directly invoke the function pointers. The functions that are used by the

Re: [PATCH V3 RFC 00/16] EFI stub for ARM

2013-08-12 Thread Mark Salter
On Fri, 2013-08-09 at 16:26 -0700, Roy Franz wrote: * Change FDT memory allocation to retry with a larger allocation if first educated guess is inadequate. With this change, it looks like you no longer free the original cmdline and fdt memory. The current flow looks like: retry:

Re: [PATCH 15/16] Add EFI stub for ARM

2013-08-12 Thread Mark Salter
On Fri, 2013-08-09 at 16:26 -0700, Roy Franz wrote: +static int relocate_kernel(efi_system_table_t *sys_table, + unsigned long *zimage_addr, + unsigned long zimage_size, + unsigned long min_addr, unsigned long max_addr)

Re: [PATCH 02/16] Add system pointer argument to shared EFI stub related functions so they no longer use global system table pointer as they did when part of eboot.c. This code is now shared, so using

2013-08-13 Thread Mark Salter
(-) Tested on arm64. Acked-by: Mark Salter msal...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 13/16] resolve warnings found on ARM compile

2013-08-13 Thread Mark Salter
On Fri, 2013-08-09 at 16:26 -0700, Roy Franz wrote: 2 unused labels 1 value computed is not used Signed-off-by: Roy Franz roy.fr...@linaro.org --- Tested on arm64. Acked-by: Mark Salter msal...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body

Re: [PATCH 12/16] Fix types in EFI calls to match EFI function definitions.

2013-08-13 Thread Mark Salter
...@linaro.org --- Tested on arm64. Acked-by: Mark Salter msal...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 10/16] Move EFI_READ_CHUNK_SIZE define to shared location.

2013-08-13 Thread Mark Salter
On Fri, 2013-08-09 at 16:26 -0700, Roy Franz wrote: This #define is only used the the shared code, so move it there. Signed-off-by: Roy Franz roy.fr...@linaro.org --- Tested on arm64. Acked-by: Mark Salter msal...@redhat.com -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 11/16] Add proper definitions for some EFI function pointers.

2013-08-13 Thread Mark Salter
by the ARM stub are updated to match the EFI definitions. Signed-off-by: Roy Franz roy.fr...@linaro.org --- Tested on arm64. Acked-by: Mark Salter msal...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 08/16] Generalize handle_ramdisks() and rename to handle_cmdline_files().

2013-08-13 Thread Mark Salter
to initrd images. Signed-off-by: Roy Franz roy.fr...@linaro.org --- Tested on arm64. Acked-by: Mark Salter msal...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 03/16] Rename memory allocation/free functions

2013-08-13 Thread Mark Salter
roy.fr...@linaro.org --- Tested on arm64. Acked-by: Mark Salter msal...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 06/16] Enforce minimum alignment of 1 page on allocations. The efi_high_alloc() and efi_low_alloc() functions use the EFI_ALLOCATE_ADDRESS option to the EFI function allocate_pages(), which

2013-08-13 Thread Mark Salter
. Acked-by: Mark Salter msal...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/16] rename __get_map() to efi_get_memory_map(), add parameter to optionally return mmap key. The mmap key is required to exit EFI boot services, and allows efi_get_memory_map() to be use

2013-08-13 Thread Mark Salter
On Fri, 2013-08-09 at 16:26 -0700, Roy Franz wrote: Signed-off-by: Roy Franz roy.fr...@linaro.org --- drivers/firmware/efi/efi-stub-helper.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) Tested on arm64. Acked-by: Mark Salter msal...@redhat.com

Re: [PATCH v2 2/3] arm: Add [U]EFI runtime services support

2013-10-17 Thread Mark Salter
On Thu, 2013-10-17 at 16:31 +0200, Leif Lindholm wrote: On Thu, Oct 17, 2013 at 03:07:39PM +0100, Matt Fleming wrote: +/* + * If you need to (temporarily) support buggy firmware. + */ +#define KEEP_BOOT_SERVICES_REGIONS Have you seen firmware that requires this? I'm just curious

[PATCH 0/3] arm64: Add EFI stub and runtime services support

2013-11-29 Thread Mark Salter
and the prerequisite patches is at: git://github.com/mosalter/linux.git (arm64-efi-patches branch) Mark Salter (3): arm64: add EFI stub doc: arm64: add description of EFI stub support arm64: add EFI runtime services Documentation/arm64/booting.txt | 4 + Documentation/efi-stub.txt | 10

[PATCH 1/3] arm64: add EFI stub

2013-11-29 Thread Mark Salter
. Support in the COFF header for signed images was provided by Ard Biesheuvel. Signed-off-by: Mark Salter msal...@redhat.com Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org CC: Catalin Marinas catalin.mari...@arm.com CC: Will Deacon will.dea...@arm.com CC: linux-arm-ker...@lists.infradead.org

[PATCH 3/3] arm64: add EFI runtime services

2013-11-29 Thread Mark Salter
This patch adds EFI runtime support for arm64. The runtime support allows the kernel to access various EFI runtime services provided by EFI firmware. Things like reboot, real time clock, EFI boot variables, and others. Signed-off-by: Mark Salter msal...@redhat.com CC: Catalin Marinas catalin.mari

Re: [PATCH 1/3] arm64: add EFI stub

2013-12-05 Thread Mark Salter
On Thu, 2013-12-05 at 14:18 +, Catalin Marinas wrote: On Fri, Nov 29, 2013 at 10:05:10PM +, Mark Salter wrote: This patch adds PE/COFF header fields to the start of the Image so that it appears as an EFI application to EFI firmware. An EFI stub is included to allow direct booting

Re: [PATCH 3/3] arm64: add EFI runtime services

2013-12-05 Thread Mark Salter
On Thu, 2013-12-05 at 15:25 +, Catalin Marinas wrote: I lost track of the early_ioremap status for arm/arm64? Was there more progress since October (I think)? See the two patch series: https://lkml.org/lkml/2013/11/25/474 and https://lkml.org/lkml/2013/11/27/621 The latter

Re: [PATCH 1/3] arm64: add EFI stub

2013-12-06 Thread Mark Salter
On Fri, 2013-12-06 at 12:25 +, Grant Likely wrote: On Thu, 5 Dec 2013 15:28:06 +, Catalin Marinas catalin.mari...@arm.com wrote: On Thu, Dec 05, 2013 at 02:43:23PM +, Mark Salter wrote: On Thu, 2013-12-05 at 14:18 +, Catalin Marinas wrote: On Fri, Nov 29, 2013 at 10:05

Re: [PATCH 1/3] arm64: add EFI stub

2013-12-06 Thread Mark Salter
On Fri, 2013-12-06 at 14:38 +0100, Leif Lindholm wrote: On Fri, Dec 06, 2013 at 08:34:30AM -0500, Mark Salter wrote: Or just disable runtime services on the switch to big ending. Big endian should not disable the stub (but getting it to work could be a follow-up patch) The other

Re: [PATCH 3/3] arm64: add EFI runtime services

2013-12-06 Thread Mark Salter
On Thu, 2013-12-05 at 15:25 +, Catalin Marinas wrote: On Fri, Nov 29, 2013 at 10:05:12PM +, Mark Salter wrote: + +#define efi_remap(cookie, size) __ioremap((cookie), (size), PAGE_KERNEL_EXEC) +#define efi_ioremap(cookie, size) __ioremap((cookie), (size

Re: [PATCH 1/3] arm64: add EFI stub

2013-12-06 Thread Mark Salter
On Thu, 2013-12-05 at 14:18 +, Catalin Marinas wrote: Hi Mark, On Fri, Nov 29, 2013 at 10:05:10PM +, Mark Salter wrote: +#include linux/linkage.h +#include linux/init.h + +#include asm/assembler.h + +#define EFI_LOAD_ERROR 0x8001 It's defined already but I

Re: [PATCH 3/3] arm64: add EFI runtime services

2013-12-10 Thread Mark Salter
On Mon, 2013-12-09 at 14:52 +0100, Leif Lindholm wrote: Apologies for late feedback. On Fri, Nov 29, 2013 at 05:05:12PM -0500, Mark Salter wrote: diff --git a/arch/arm64/kernel/efi.c b/arch/arm64/kernel/efi.c new file mode 100644 index 000..1bad8a7 --- /dev/null +++ b/arch/arm64

Re: [PATCH v5 02/14] efi: use early_memremap and early_memunmap

2013-12-11 Thread Mark Salter
On Wed, 2013-12-11 at 11:32 +, Matt Fleming wrote: On Wed, 11 Dec, at 12:02:27PM, Leif Lindholm wrote: On Wed, Dec 11, 2013 at 10:39:03AM +, Matt Fleming wrote: Leif, Mark, does this patch look OK for ARM? We'd need to introduce a new early_memunmap() function so that things still

[PATCH] x86: efi: create memory map iteration helper

2014-01-08 Thread Mark Salter
to use. Signed-off-by: Mark Salter msal...@redhat.com --- arch/x86/platform/efi/efi.c| 48 +- arch/x86/platform/efi/efi_64.c | 5 + drivers/firmware/efi/efi.c | 5 ++--- include/linux/efi.h| 6 ++ 4 files changed, 24 insertions

[PATCH 1/6] efi: create memory map iteration helper

2014-01-10 Thread Mark Salter
There are a lot of places in the kernel which iterate through an EFI memory map. Most of these places use essentially the same for-loop code. This patch adds a for_each_efi_memory_desc() helper to clean up all of the existing duplicate code and avoid more in the future. Signed-off-by: Mark Salter

Re: [PATCH 1/6] efi: create memory map iteration helper

2014-01-13 Thread Mark Salter
On Mon, 2014-01-13 at 15:17 +, Matt Fleming wrote: On Fri, 10 Jan, at 05:29:05PM, Mark Salter wrote: There are a lot of places in the kernel which iterate through an EFI memory map. Most of these places use essentially the same for-loop code. This patch adds a for_each_efi_memory_desc

Re: [PATCH v4 2/5] arm: add new asm macro update_sctlr

2014-01-29 Thread Mark Salter
On Wed, 2014-01-29 at 18:28 +, Leif Lindholm wrote: On Wed, Jan 22, 2014 at 11:20:55AM +, Will Deacon wrote: +#ifdef CONFIG_CPU_CP15 +/* Macro for setting/clearing bits in sctlr */ + .macro update_sctlr, set:req, clear:req, tmp:req, tmp2:req + mrc p15, 0, \tmp, c1, c0,

Re: [PATCH 03/22] efi: add helper function to get UEFI params from FDT

2014-02-13 Thread Mark Salter
On Thu, 2014-02-13 at 11:17 +, Matt Fleming wrote: On Wed, 05 Feb, at 05:03:54PM, Leif Lindholm wrote: From: Mark Salter msal...@redhat.com ARM and ARM64 architectures use the device tree to pass UEFI parameters from stub to kernel. These parameters are things known to the stub

Re: [PATCH v2 13/15] arm64: add EFI runtime services

2014-03-18 Thread Mark Salter
On Tue, 2014-03-18 at 12:34 +, Catalin Marinas wrote: On Thu, Mar 13, 2014 at 10:47:06PM +, Leif Lindholm wrote: --- /dev/null +++ b/arch/arm64/kernel/efi.c [...] +/* + * Called from setup_arch with interrupts disabled. + */ +void __init efi_enter_virtual_mode(void) [...]

Re: [PATCH v2 11/15] arm64: add EFI stub

2014-03-18 Thread Mark Salter
On Tue, 2014-03-18 at 12:09 +, Catalin Marinas wrote: On Thu, Mar 13, 2014 at 10:47:04PM +, Leif Lindholm wrote: --- /dev/null +++ b/arch/arm64/kernel/efi-entry.S @@ -0,0 +1,93 @@ +/* + * EFI entry point. + * + * Copyright (C) 2013 Red Hat, Inc. + * Author: Mark Salter

Re: [PATCH v2 11/15] arm64: add EFI stub

2014-03-18 Thread Mark Salter
On Tue, 2014-03-18 at 18:28 +, Catalin Marinas wrote: On Tue, Mar 18, 2014 at 02:40:29PM +, Mark Salter wrote: On Tue, 2014-03-18 at 12:09 +, Catalin Marinas wrote: On Thu, Mar 13, 2014 at 10:47:04PM +, Leif Lindholm wrote: --- /dev/null +++ b/arch/arm64/kernel/efi

Re: [PATCH v2 11/15] arm64: add EFI stub

2014-03-19 Thread Mark Salter
On Wed, 2014-03-19 at 10:57 +, Catalin Marinas wrote: On Tue, Mar 18, 2014 at 09:40:31PM +, Mark Salter wrote: On Tue, 2014-03-18 at 18:28 +, Catalin Marinas wrote: If UEFI doesn't handle the caches, the only thing left to EFI_STUB is to flush by MVA. We don't need to flush

Re: [PATCH v2 11/15] arm64: add EFI stub

2014-03-19 Thread Mark Salter
On Wed, 2014-03-19 at 16:01 +, Catalin Marinas wrote: On Wed, Mar 19, 2014 at 03:13:18PM +, Mark Salter wrote: On Wed, 2014-03-19 at 10:57 +, Catalin Marinas wrote: On Tue, Mar 18, 2014 at 09:40:31PM +, Mark Salter wrote: On Tue, 2014-03-18 at 18:28 +, Catalin Marinas

Re: [PATCH v5 1/7] efi: Use early_mem*() instead of early_io*()

2014-06-18 Thread Mark Salter
On Wed, 2014-06-18 at 13:17 +0100, Matt Fleming wrote: Now, the only difference between early_memremap() and early_ioremap(), at least on x86, is PAGE_KERNEL vs. PAGE_KERNEL_IO, where PAGE_KERNEL_IO has the additional _PAGE_BIT_IOMAP bit set in the pte. But that's a software bit for x86. I

Re: [PATCH] arm64: support reboot and power off via EFI runtime

2014-06-18 Thread Mark Salter
On Wed, 2014-06-18 at 09:09 -0500, Rob Herring wrote: On Tue, Jun 17, 2014 at 11:45 AM, Mark Salter msal...@redhat.com wrote: Add handlers for arm_pm_resestart and pm_power_off which use EFI typo. runtime services ResetSystem call to perform the functions. These handlers are only

Re: [PATCH 1/3] efi/reboot: Add generic wrapper around EfiResetSystem()

2014-06-23 Thread Mark Salter
simplifies the callsites since users no longer need to check to see whether EFI_RUNTIME_SERVICES are enabled. Cc: Tony Luck tony.l...@intel.com Cc: Mark Salter msal...@redhat.com Signed-off-by: Matt Fleming matt.flem...@intel.com --- Tested-by: Mark Salter msal...@redhat.com Mark, I

Re: [PATCH 2/3] efi/reboot: Allow powering off machines using EFI

2014-06-23 Thread Mark Salter
this for specific classes of hardware will be submitted separately. Cc: Mark Salter msal...@redhat.com Signed-off-by: Matt Fleming matt.flem...@intel.com --- Tested-by: Mark Salter msal...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message

Re: [PATCH v2 0/2] efi: preserve NEON registers on UEFI services calls

2014-06-26 Thread Mark Salter
On Thu, 2014-06-26 at 12:09 +0200, Ard Biesheuvel wrote: The current UEFI implementation for arm64 fails to preserve/restore the contents of the NEON register file, Does the current implementation actually use NEON registers? I know there are some at least, which build with

Re: [PATCH v2 2/5] efi/x86: efistub: move shared dependencies to asm/efi.h

2014-07-02 Thread Mark Salter
On Thu, 2014-06-26 at 16:23 +0200, Ard Biesheuvel wrote: This moves definitions depended upon both by code under arch/x86/boot and under drivers/firmware/efi to asm/efi.h. This is in preparation of turning the stub code under drivers/firmware/efi into a static library. Signed-off-by: Ard

Re: [PATCH 1/2] efi/arm64: fix potential NULL dereference of efi.systab

2014-07-02 Thread Mark Salter
On Wed, 2014-07-02 at 12:13 +0200, Ard Biesheuvel wrote: On 2 July 2014 12:10, Ard Biesheuvel ard.biesheu...@linaro.org wrote: We assign efi.systab using efi_lookup_mapped_addr(), and test for !NULL, but then go on an dereference it anyway. Signed-off-by: Ard Biesheuvel

Re: [PATCH v2] efi/arm64: handle missing virtual mapping for UEFI System Table

2014-07-04 Thread Mark Salter
On Fri, 2014-07-04 at 12:16 +0200, Ard Biesheuvel wrote: If we cannot resolve the virtual address of the UEFI System Table, its physical offset must be missing from the virtual memory map, and there is really no point in proceeding with installing the virtual memory map and the runtime

Re: [PATCH v3] efi/arm64: handle missing virtual mapping for UEFI System Table

2014-07-04 Thread Mark Salter
services dispatch table. So back out gracefully. Signed-off-by: Ard Biesheuvel ard.biesheu...@linaro.org --- Acked-by: Mark Salter msal...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] efi/arm64: efistub: don't abort if base of DRAM is occupied

2014-07-15 Thread Mark Salter
On Tue, 2014-07-15 at 11:02 +0100, Leif Lindholm wrote: @@ -273,6 +282,10 @@ static void __init free_boot_services(void) continue; } + /* Don't free anything below kernel */ + if (md-phys_addr PHYS_OFFSET) +

Re: [PATCH] efi/arm64: efistub: don't abort if base of DRAM is occupied

2014-07-15 Thread Mark Salter
On Tue, 2014-07-15 at 14:54 +0100, Leif Lindholm wrote: On Tue, Jul 15, 2014 at 09:11:00AM -0400, Mark Salter wrote: On Tue, 2014-07-15 at 11:02 +0100, Leif Lindholm wrote: @@ -273,6 +282,10 @@ static void __init free_boot_services(void) continue

Re: [PATCH] efi/arm64: efistub: don't abort if base of DRAM is occupied

2014-07-16 Thread Mark Salter
On Tue, 2014-07-15 at 16:28 +0100, Leif Lindholm wrote: On Tue, Jul 15, 2014 at 11:04:37AM -0400, Mark Salter wrote: On Tue, 2014-07-15 at 15:49 +0100, Leif Lindholm wrote: On Tue, Jul 15, 2014 at 10:23:26AM -0400, Mark Salter wrote: On Tue, 2014-07-15 at 14:54 +0100, Leif Lindholm wrote

Re: [RFC PATCH] arm64/efi: efistub: reuse EFI mapping for Image if it is lower

2014-07-16 Thread Mark Salter
On Tue, 2014-07-15 at 18:50 +0200, Ard Biesheuvel wrote: The EFI loader may load Image at any available offset. This means Image may reside very close to or at the base of DRAM, in which case the relocation done by efi_entry() results in Image being moved up in memory, which is undesirable

Re: [PATCH v2] arm64/efi: efistub: jump to 'stext' directly, not through the header

2014-07-16 Thread Mark Salter
On Tue, 2014-07-15 at 12:58 +0200, Ard Biesheuvel wrote: After the EFI stub has done its business, it jumps into the kernel by branching to offset #0 of the loaded Image, which is where it expects to find the header containing a 'branch to stext' instruction. However, the header is not

Re: [PATCH v2] arm64/efi: efistub: jump to 'stext' directly, not through the header

2014-07-16 Thread Mark Salter
On Wed, 2014-07-16 at 16:53 +0100, Mark Rutland wrote: On Wed, Jul 16, 2014 at 03:51:37PM +0100, Mark Salter wrote: On Tue, 2014-07-15 at 12:58 +0200, Ard Biesheuvel wrote: After the EFI stub has done its business, it jumps into the kernel by branching to offset #0 of the loaded Image

Re: [PATCH v2] arm64/efi: efistub: jump to 'stext' directly, not through the header

2014-07-16 Thread Mark Salter
On Wed, 2014-07-16 at 22:38 +0200, Ard Biesheuvel wrote: On 16 July 2014 21:45, Mark Salter msal...@redhat.com wrote: On Wed, 2014-07-16 at 16:53 +0100, Mark Rutland wrote: On Wed, Jul 16, 2014 at 03:51:37PM +0100, Mark Salter wrote: On Tue, 2014-07-15 at 12:58 +0200, Ard Biesheuvel wrote

Re: [PATCH v2] arm64/efi: efistub: jump to 'stext' directly, not through the header

2014-07-17 Thread Mark Salter
On Wed, 2014-07-16 at 23:13 +0200, Ard Biesheuvel wrote: On 16 July 2014 23:03, Mark Salter msal...@redhat.com wrote: On Wed, 2014-07-16 at 22:38 +0200, Ard Biesheuvel wrote: On 16 July 2014 21:45, Mark Salter msal...@redhat.com wrote: On Wed, 2014-07-16 at 16:53 +0100, Mark Rutland wrote

Re: [PATCH] efi/arm64: efistub: don't abort if base of DRAM is occupied

2014-07-22 Thread Mark Salter
On Tue, 2014-07-22 at 18:08 +0100, Leif Lindholm wrote: (Argh, late reply due to broken mail filters.) On Wed, Jul 16, 2014 at 09:13:48AM -0400, Mark Salter wrote: Is the spin table area really allocated as BOOT_SERVICES_*? No. It is EFI_RESERVED_TYPE. But if UEFI

Re: [PATCH 1/3] arm64: spin-table: handle unmapped cpu-release-addrs

2014-07-29 Thread Mark Salter
On Tue, 2014-07-29 at 11:15 -0400, Mark Salter wrote: On Tue, 2014-07-29 at 12:49 +0200, Ard Biesheuvel wrote: From: Mark Rutland mark.rutl...@arm.com In certain cases the cpu-release-addr of a CPU may not fall in the linear mapping (e.g. when the kernel is loaded above this address due

Re: [PATCH 1/3] arm64: spin-table: handle unmapped cpu-release-addrs

2014-07-29 Thread Mark Salter
On Tue, 2014-07-29 at 17:20 +0200, Arnd Bergmann wrote: On Tuesday 29 July 2014 11:15:45 Mark Salter wrote: - - __flush_dcache_area(release_addr, sizeof(release_addr[0])); + writeq_relaxed(__pa(secondary_holding_pen), release_addr); + __flush_dcache_area(release_addr

Re: [PATCH 3/3] arm64/efi: efistub: don't abort if base of DRAM is occupied

2014-07-29 Thread Mark Salter
, - PAGE_SIZE); Can we make efi_relocate_kernel static inline to get rid of the defined but unused warning? Otherwise: Acked-by: Mark Salter msal...@redhat.com + status = efi_low_alloc(sys_table, kernel_memsize + TEXT_OFFSET

Re: [PATCH 2/3] arm64/efi: efistub: cover entire static mem footprint in PE/COFF .text

2014-07-29 Thread Mark Salter
(-) Acked-by: Mark Salter msal...@redhat.com diff --git a/arch/arm64/kernel/head.S b/arch/arm64/kernel/head.S index 69dafe9621fd..dafc4f2c1ade 100644 --- a/arch/arm64/kernel/head.S +++ b/arch/arm64/kernel/head.S @@ -148,7 +148,7 @@ optional_header: .short 0x20b

Re: [PATCH 3/3] arm64/efi: efistub: don't abort if base of DRAM is occupied

2014-07-29 Thread Mark Salter
On Tue, 2014-07-29 at 20:46 +0200, Ard Biesheuvel wrote: On 29 July 2014 20:27, Mark Salter msal...@redhat.com wrote: On Tue, 2014-07-29 at 20:17 +0200, Ard Biesheuvel wrote: On 29 July 2014 17:29, Mark Salter msal...@redhat.com wrote: On Tue, 2014-07-29 at 12:49 +0200, Ard Biesheuvel

Re: [PATCH v2 1/3] arm64: spin-table: handle unmapped cpu-release-addrs

2014-07-31 Thread Mark Salter
-release-addr, enabling us to support addresses regardless of whether they are covered by the linear mapping. Signed-off-by: Mark Rutland mark.rutl...@arm.com Tested-by: Mark Salter msal...@redhat.com [ardb: added (__force void *) cast] Signed-off-by: Ard

Re: [RFC PATCH] arm64/efi: use id mapping for Runtime Services

2014-07-31 Thread Mark Salter
On Thu, 2014-07-31 at 16:11 +0200, Ard Biesheuvel wrote: There are 2 interesting pieces of information in the UEFI spec section 2.3.6 regarding the mapping of runtime regions: (a) the firmware should not request a virtual mapping for configuration tables, even though they are marked as

Re: [PATCH 4/7] arm64/efi: uefi_init error handling fix

2014-08-14 Thread Mark Salter
(-) Acked-by: Mark Salter msal...@redhat.com -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] efi/arm64: fix fdt-related memory reservation

2014-09-08 Thread Mark Salter
. Signed-off-by: Mark Salter msal...@redhat.com --- arch/arm64/mm/init.c | 3 +-- drivers/firmware/efi/libstub/fdt.c | 10 +- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 5472c24..a83061f 100644 --- a/arch/arm64/mm

Re: [PATCH] efi/arm64: fix fdt-related memory reservation

2014-09-08 Thread Mark Salter
On Mon, 2014-09-08 at 15:06 +0100, Mark Rutland wrote: Hi Mark, On Mon, Sep 08, 2014 at 02:31:42PM +0100, Mark Salter wrote: Commit 86c8b27a01cf: arm64: ignore DT memreserve entries when booting in UEFI mode prevents early_init_fdt_scan_reserved_mem() from being called for arm64

[PATCH v2] efi/arm64: fix fdt-related memory reservation

2014-09-08 Thread Mark Salter
. Change from v1: * Acks added * Fixed loop logic to remove reserved regions Signed-off-by: Mark Salter msal...@redhat.com Acked-by: Ard Biesheuvel ard.biesheu...@linaro.org Acked-by: Mark Rutland mark.rutl...@arm.com --- arch/arm64/mm/init.c | 3 +-- drivers/firmware/efi/libstub/fdt.c

Re: [PATCH] rtc: Disable EFI rtc for x86

2014-10-03 Thread Mark Salter
on 32-bit tablets, https://bugzilla.kernel.org/show_bug.cgi?id=84241#c21 Disable it explicitly for x86 so that we don't give users false hope that this driver will work - it won't, and your machine is likely to crash. Cc: Mark Salter msal...@redhat.com Cc: Dave Young dyo...@redhat.com Cc

Re: [PATCH v3] arm64/efi: efistub: jump to 'stext' directly, not through the header

2014-10-09 Thread Mark Salter
with the rest of the image if it needs to be relocated, so I don't see an issue there. However, I do remember Mark Salter mentioning that there is at least one other location that needs to be fixed up if this concern is valid. Mark? I think at one time we were using the the EFI_LOADED_IMAGE_PROTOCOL

Re: [PATCH v3] arm64/efi: efistub: jump to 'stext' directly, not through the header

2014-10-10 Thread Mark Salter
On Fri, 2014-10-10 at 08:30 +0200, Ard Biesheuvel wrote: On 10 October 2014 01:20, Roy Franz roy.fr...@linaro.org wrote: On Thu, Oct 9, 2014 at 3:19 PM, Mark Salter msal...@redhat.com wrote: On Thu, 2014-10-09 at 21:03 +0200, Ard Biesheuvel wrote: On 9 October 2014 19:23, Mark Rutland

Re: [PATCH 06/10] arm64/efi: use UEFI memory map unconditionally if available

2014-10-22 Thread Mark Salter
On Wed, 2014-10-22 at 16:21 +0200, Ard Biesheuvel wrote: On systems that boot via UEFI, all memory nodes are deleted from the device tree, and instead, the size and location of system RAM is derived from the UEFI memory map. This is handled by reserve_regions, which not only reserves parts of

Re: [PATCH 06/10] arm64/efi: use UEFI memory map unconditionally if available

2014-10-22 Thread Mark Salter
On Wed, 2014-10-22 at 19:20 +0200, Ard Biesheuvel wrote: On 22 October 2014 19:06, Mark Salter msal...@redhat.com wrote: On Wed, 2014-10-22 at 16:21 +0200, Ard Biesheuvel wrote: On systems that boot via UEFI, all memory nodes are deleted from the device tree, and instead, the size

Re: [PATCH 06/10] arm64/efi: use UEFI memory map unconditionally if available

2014-10-23 Thread Mark Salter
On Thu, 2014-10-23 at 16:54 +0100, Mark Rutland wrote: On Wed, Oct 22, 2014 at 06:06:56PM +0100, Mark Salter wrote: On Wed, 2014-10-22 at 16:21 +0200, Ard Biesheuvel wrote: On systems that boot via UEFI, all memory nodes are deleted from the device tree, and instead, the size and location

Re: [PATCH v2 09/10] arm64/efi: ignore unusable regions instead of reserving them

2014-11-09 Thread Mark Salter
On Thu, 2014-11-06 at 15:13 +0100, Ard Biesheuvel wrote: This changes the way memblocks are installed based on the contents of the UEFI memory map. Formerly, all regions would be memblock_add()'ed, after which unusable regions would be memblock_reserve()'d as well. To simplify things, but also

Re: [PATCH v2 09/10] arm64/efi: ignore unusable regions instead of reserving them

2014-11-11 Thread Mark Salter
On Tue, 2014-11-11 at 10:42 -0500, Mark Salter wrote: On Mon, 2014-11-10 at 08:31 +0100, Ard Biesheuvel wrote: On 10 November 2014 05:11, Mark Salter msal...@redhat.com wrote: On Thu, 2014-11-06 at 15:13 +0100, Ard Biesheuvel wrote: This changes the way memblocks are installed based

Re: [PATCH v3 11/13] arm64/efi: use plain memblock API for adding and removing reserved RAM

2014-11-20 Thread Mark Salter
On Tue, 2014-11-18 at 13:57 +0100, Ard Biesheuvel wrote: diff --git a/drivers/firmware/efi/virtmap.c b/drivers/firmware/efi/virtmap.c index 98735fb43581..4b6a5c31629f 100644 --- a/drivers/firmware/efi/virtmap.c +++ b/drivers/firmware/efi/virtmap.c @@ -8,6 +8,7 @@ */ #include

Re: [PATCH v3 11/13] arm64/efi: use plain memblock API for adding and removing reserved RAM

2014-11-20 Thread Mark Salter
On Thu, 2014-11-20 at 18:38 +0100, Ard Biesheuvel wrote: On 20 November 2014 18:28, Mark Salter msal...@redhat.com wrote: On Tue, 2014-11-18 at 13:57 +0100, Ard Biesheuvel wrote: diff --git a/drivers/firmware/efi/virtmap.c b/drivers/firmware/efi/virtmap.c index 98735fb43581..4b6a5c31629f

Re: [PATCH v3 11/13] arm64/efi: use plain memblock API for adding and removing reserved RAM

2014-11-21 Thread Mark Salter
On Fri, 2014-11-21 at 13:07 +0100, Ard Biesheuvel wrote: On 20 November 2014 18:54, Mark Salter msal...@redhat.com wrote: On Thu, 2014-11-20 at 18:38 +0100, Ard Biesheuvel wrote: On 20 November 2014 18:28, Mark Salter msal...@redhat.com wrote: On Tue, 2014-11-18 at 13:57 +0100, Ard

Re: [PATCH] arm64/efi: handle potential failure to remap memory map

2015-01-15 Thread Mark Salter
; + } memmap.map_end = memmap.map + mapsize; - efi.memmap = memmap; efi.systab = (__force void *)ioremap_cache(efi_system_table, Somewhat unrelated but we should unmap memmap.map if the efi.systab mapping fails. Acked-by: Mark Salter msal...@redhat.com

Re: [PATCH v2 1/2] arm64: don't make early_*map() calls post paging_init()

2015-01-06 Thread Mark Salter
On Tue, 2015-01-06 at 13:41 +, Leif Lindholm wrote: arm64 early_ioremap/iounmap/memremap/memunmap are not supported beyond the call to paging_init(), but arm64_enter_virtual_mode() (an early initcall) makes one call to unmap the UEFI memory map. Rearrange the code to unmap this region

Re: [PATCH] efi: Work around ia64 build problem with ESRT driver.

2015-06-08 Thread Mark Salter
On Mon, 2015-06-08 at 11:09 +0100, Matt Fleming wrote: On Fri, 05 Jun, at 03:14:54PM, Peter Jones wrote: So, I'm told this problem exists in the world: -- Subject: Build error in -next due to 'efi: Add esrt support' Building ia64:defconfig

Re: [PATCH 3/3] efi/libstub: fix deletion of FDT memory nodes

2015-10-07 Thread Mark Salter
On Wed, 2015-10-07 at 09:35 +0100, Ard Biesheuvel wrote: > This fixes two issues with the EFI libstub code that removes the memory > nodes from the FDT: > a) fdt_del_node() invalidates the iterator, so we should restart from the >top after calling it; > b) use fixed length of 6 when matching

Re: [PATCH 3/3] efi/libstub: fix deletion of FDT memory nodes

2015-10-07 Thread Mark Salter
On Wed, 2015-10-07 at 18:56 +0100, Ard Biesheuvel wrote: > On 7 October 2015 at 17:02, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > > On 7 October 2015 at 16:49, Mark Salter <msal...@redhat.com> wrote: > > > On Wed, 2015-10-07 at 09:35 +0100, Ard Biesheuvel

Re: [PATCH 3/3] efi/arm64: clean up efi_get_fdt_params() interface

2015-08-26 Thread Mark Salter
On Wed, 2015-08-26 at 16:04 +0200, Ard Biesheuvel wrote: On 26 August 2015 at 15:24, Leif Lindholm leif.lindh...@linaro.org wrote: As we now have a common debug infrastructure between core and arm64 efi, drop the bit of the interface passing verbose output flags around.

Re: [PATCH v2] arm64/efi: don't pad between EFI_MEMORY_RUNTIME regions

2015-09-09 Thread Mark Salter
is means we also need to > sort it first. > > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- Tested-by: Mark Salter <msal...@redhat.com> Reviewed-by: Mark Salter <msal...@redhat.com> > > As discussed off list, this is the arm64 side of what we shou