Re: [RFC V4 PATCH 00/15] Signature verification of hibernate snapshot

2013-10-17 Thread Rafael J. Wysocki
On Sunday, September 15, 2013 08:56:46 AM Lee, Chun-Yi wrote: Hi experts, This patchset is the implementation for signature verification of hibernate snapshot image. The origin idea is from Jiri Kosina: Let EFI bootloader generate key-pair in UEFI secure boot environment, then pass it to

Re: [RFC PATCH 00/14] Support timezone of ACPI TAD and EFI TIME

2013-12-20 Thread Rafael J. Wysocki
On Friday, December 20, 2013 01:10:26 PM H. Peter Anvin wrote: On 12/19/2013 09:38 PM, joeyli wrote: If don't use EFI time, then the first priority is using ACPI TAD if it present. Due to ACPI TAD is a generic acpi device that's need OS parsing DSDT table before set system time.

Re: [RFC PATCH 04/14] ACPI: Add ACPI 5.0 Time and Alarm Device driver

2014-01-09 Thread Rafael J. Wysocki
that to start with or we risk conflicts between kernel code and AML accessing registers in that space. Thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord

[RFT][PATCH] ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode() (was: Re: [RFC PATCH 00/14] Support timezone of ACPI TAD and EFI TIME)

2014-01-11 Thread Rafael J. Wysocki
On Saturday, December 21, 2013 12:21:48 PM Matt Fleming wrote: On Fri, 20 Dec, at 11:18:56PM, Rafael J. Wysocki wrote: I'm not sure 100%, but I *think* we need to do that with interrupts enabled. At least after mm_init(), because it relies on things initialized there if I remember

Re: [RFT][PATCH] ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode() (was: Re: [RFC PATCH 00/14] Support timezone of ACPI TAD and EFI TIME)

2014-01-14 Thread Rafael J. Wysocki
On Tuesday, January 14, 2014 12:09:08 PM joeyli wrote: 於 日,2014-01-12 於 01:30 +0100,Rafael J. Wysocki 提到: OK I don't see any adverse effects of the patch below on a couple of my test boxes, but (a) they are Intel-based and (b) they are non-EFI, so it would be good to give it a go

Re: [PATCH] ACPI / init: Run acpi_early_init() before timekeeping_init()

2014-01-15 Thread Rafael J. Wysocki
timekeeping_init(). This final position is also before efi_enter_virtual_mode(). v2: Move acpi_early_init() before timekeeping_init() to prepare setting system clock with ACPI TAD. v1: Rafael J. Wysocki ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode() Cc: Rafael J

Re: [BUG] can't boot up: unable to handle kernel paging request at ffffffffff340003

2014-02-13 Thread Rafael J. Wysocki
think this is the right thing to do. Agreed. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 03/44] hibernate: Call have_kernel_poweroff instead of checking pm_power_off

2014-10-07 Thread Rafael J. Wysocki
On Monday, October 06, 2014 10:28:05 PM Guenter Roeck wrote: Poweroff handlers may now be installed with register_poweroff_handler. Use the new API function have_kernel_poweroff to determine if a poweroff handler has been installed. Cc: Rafael J. Wysocki r...@rjwysocki.net Cc: Pavel Machek

Re: [PATCH 44/44] kernel: Remove pm_power_off

2014-10-07 Thread Rafael J. Wysocki
On Monday, October 06, 2014 10:28:46 PM Guenter Roeck wrote: No users of pm_power_off are left, so it is safe to remove the function. Cc: Rafael J. Wysocki r...@rjwysocki.net Cc: Pavel Machek pa...@ucw.cz Cc: Len Brown len.br...@intel.com Signed-off-by: Guenter Roeck li...@roeck-us.net ACK

Re: [RFC PATCH 00/16] Signature verification of hibernate snapshot

2015-07-24 Thread Rafael J. Wysocki
On Friday, July 24, 2015 07:08:18 PM Jiri Kosina wrote: On Thu, 16 Jul 2015, Lee, Chun-Yi wrote: This patchset is the implementation of signature verification of hibernate snapshot image. The origin idea is from Jiri Kosina: Let EFI bootloader generate key-pair in UEFI secure boot

Re: [PATCH 17/24] acpi: Ignore acpi_rsdp kernel param when the kernel has been locked down

2017-04-06 Thread Rafael J. Wysocki
On Wed, Apr 5, 2017 at 10:16 PM, David Howells wrote: > From: Josh Boyer > > This option allows userspace to pass the RSDP address to the kernel, which > makes it possible for a user to circumvent any restrictions imposed on > loading modules. Ignore the

Re: [PATCH 11/24] uswsusp: Disable when the kernel is locked down

2017-04-06 Thread Rafael J. Wysocki
On Thu, Apr 6, 2017 at 8:55 AM, David Howells <dhowe...@redhat.com> wrote: > Rafael J. Wysocki <raf...@kernel.org> wrote: > >> You probably want to disable hibernation altogether in this case. > > See patch 10. Does that mean patch 11 is superfluous? Yes, it does.

Re: [PATCH 11/24] uswsusp: Disable when the kernel is locked down

2017-04-06 Thread Rafael J. Wysocki
On Thu, Apr 6, 2017 at 10:09 PM, Rafael J. Wysocki <raf...@kernel.org> wrote: > On Thu, Apr 6, 2017 at 10:41 AM, David Howells <dhowe...@redhat.com> wrote: >> Oliver Neukum <oneu...@suse.com> wrote: >> >>> Your swap partition may be located on an NVDI

Re: [PATCH v1 8/8] ACPI: Use recently introduced uuid_le_cmp_p{p}() helpers

2017-04-21 Thread Rafael J. Wysocki
On Friday, April 21, 2017 05:46:45 PM Andy Shevchenko wrote: > Recently introduced helpers take pointers to uuid_{be|le} instead of > reference. > > Using them makes code less ugly. > > Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> > Signed-of

Re: [PATCH 11/24] uswsusp: Disable when the kernel is locked down

2017-04-05 Thread Rafael J. Wysocki
On Wed, Apr 5, 2017 at 10:16 PM, David Howells wrote: > From: Matthew Garrett > > uswsusp allows a user process to dump and then restore kernel state, which > makes it possible to modify the running kernel. Disable this if the kernel > is locked down. >

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-26 Thread Rafael J. Wysocki
On Wednesday, July 26, 2017 01:03:03 PM Andy Shevchenko wrote: > On Wed, 2017-07-26 at 02:27 +0200, Rafael J. Wysocki wrote: > > On Wednesday, July 26, 2017 03:35:01 AM Andy Shevchenko wrote: > > > On Wed, Jul 26, 2017 at 3:21 AM, Rafael J. Wysocki <r...@rjwyso

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-19 Thread Rafael J. Wysocki
On Wed, Jul 19, 2017 at 8:28 PM, Andy Shevchenko wrote: > There are new types and helpers that are supposed to be used in new code. > > As a preparation to get rid of legacy types and API functions do > the conversion here. Please talk to Mika about this one.

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-25 Thread Rafael J. Wysocki
On Wednesday, July 26, 2017 03:35:01 AM Andy Shevchenko wrote: > On Wed, Jul 26, 2017 at 3:21 AM, Rafael J. Wysocki <r...@rjwysocki.net> wrote: > > On Tuesday, July 25, 2017 05:12:35 PM Mika Westerberg wrote: > >> On Wed, Jul 19, 2017 at 09:28:57PM +030

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-07-25 Thread Rafael J. Wysocki
do > > the conversion here. > > > > Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> > > Cc: Mika Westerberg <mika.westerb...@linux.intel.com> > > Acked-by: Mika Westerberg <mika.westerb...@linux.intel.com> OK Andy, do you want me

Re: [PATCH v4 23/27] x86_64: assembly, change all ENTRY+ENDPROC to SYM_FUNC_*

2017-10-02 Thread Rafael J. Wysocki
lt;herb...@gondor.apana.org.au> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> > Cc: Len Brown <len.br...@intel.com> > Cc: Pavel Machek <pa...@ucw.cz> > Cc: Matt Fleming <m...@code

Re: [PATCH v1 6/6] device property: Switch to use new generic UUID API

2017-08-30 Thread Rafael J. Wysocki
On Wednesday, August 30, 2017 2:41:41 PM CEST Christoph Hellwig wrote: > On Wed, Jul 26, 2017 at 02:27:44AM +0200, Rafael J. Wysocki wrote: > > > >> > Cc: "Rafael J. Wysocki" <r...@rjwysocki.net> > > > >> > Cc: Mika Westerberg <mika.we

Re: [PATCH v2] device property: Get rid of union aliasing

2018-05-14 Thread Rafael J. Wysocki
On Mon, May 14, 2018 at 6:13 PM, Andy Shevchenko wrote: > On Mon, 2018-05-14 at 17:40 +0200, Lukas Wunner wrote: >> On Mon, May 14, 2018 at 03:48:09PM +0300, Andy Shevchenko wrote: >> > On Mon, 2018-05-14 at 14:18 +0200, Lukas Wunner wrote: >> > > On Tue, May

Re: [PATCH v1] device property: Get rid of union aliasing

2018-04-27 Thread Rafael J. Wysocki
On Thu, Apr 26, 2018 at 12:23 PM, Andy Shevchenko wrote: > The commit > > 318a19718261 ("device property: refactor built-in properties support") > > went way too far and brought a union aliasing. Partially revert it here > to get rid of union aliasing. > >

Re: [PATCH v3] device property: Get rid of union aliasing

2018-05-23 Thread Rafael J. Wysocki
On Wednesday, May 16, 2018 11:41:33 AM CEST Mika Westerberg wrote: > On Tue, May 15, 2018 at 08:32:02PM +0300, Andy Shevchenko wrote: > > The commit > > > > 318a19718261 ("device property: refactor built-in properties support") > > > > went way too far and brought a union aliasing. Partially

Re: Multiple Acer laptops hang on ACPI poweroff

2017-10-27 Thread Rafael J. Wysocki
On Fri, Oct 27, 2017 at 8:35 AM, Daniel Drake wrote: > On Sat, Mar 4, 2017 at 4:15 AM, Daniel Drake wrote: >> Some particular Acer/Packard Bell machines hang during shutdown. >> The system completely hangs while doing bit operations for turning on SLP_EN

Re: [PATCH v1] device property: Get rid of union aliasing

2018-04-26 Thread Rafael J. Wysocki
On Thu, Apr 26, 2018 at 2:54 PM, Greg Kroah-Hartman wrote: > On Thu, Apr 26, 2018 at 01:23:56PM +0300, Andy Shevchenko wrote: >> The commit >> >> 318a19718261 ("device property: refactor built-in properties support") >> >> went way too far and brought a union

Re: [PATCH v6 1/3] x86/boot: Add acpitb.c to parse acpi tables

2018-09-10 Thread Rafael J. Wysocki
On Mon, Sep 10, 2018 at 2:41 PM Chao Fan wrote: > > Imitate the ACPI code of parsing ACPI tables to dig and read ACPI > tables. Why? > Since some operations are not needed here, What operations? > functions are simplified. Functions will be used to dig SRAT tables to get > information of

Re: [PATCH v6 1/3] x86/boot: Add acpitb.c to parse acpi tables

2018-09-11 Thread Rafael J. Wysocki
On Tue, Sep 11, 2018 at 3:28 AM Chao Fan wrote: > > On Mon, Sep 10, 2018 at 10:13:49PM +0200, Rafael J. Wysocki wrote: > >On Mon, Sep 10, 2018 at 2:41 PM Chao Fan wrote: > >> > >> Imitate the ACPI code of parsing ACPI tables to dig and read ACPI > >> ta

Re: [PATCH v1 4/4] ACPI / x86: utils: Get rid of custom ICPU() macro

2018-09-11 Thread Rafael J. Wysocki
A(ATOM_AIRMONT), { > DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"), > DMI_MATCH(DMI_BOARD_NAME, "Default string"), > DMI_MATCH(DMI_PRODUCT_NAME, "Default string"), > DMI_MATCH(DMI_BIOS_DATE, "03/20/2017") > }), > - ENTRY("KIOX000A", "1", ICPU(INTEL_FAM6_ATOM_AIRMONT), { > + ENTRY("KIOX000A", "1", INTEL_CPU_FAM6_NODATA(ATOM_AIRMONT), { > DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"), > DMI_MATCH(DMI_BOARD_NAME, "Default string"), > DMI_MATCH(DMI_PRODUCT_NAME, "Default string"), > Acked-by: Rafael J. Wysocki

Re: [PATCH v1 3/4] ACPI / LPSS: Get rid of custom ICPU() macro

2018-09-11 Thread Rafael J. Wysocki
t; - ICPU(INTEL_FAM6_ATOM_AIRMONT), /* Braswell, Cherry Trail */ > + INTEL_CPU_FAM6_NODATA(ATOM_SILVERMONT1),/* Valleyview, Bay > Trail */ > + INTEL_CPU_FAM6_NODATA(ATOM_AIRMONT), /* Braswell, Cherry > Trail */ > {} > }; > > Acked-by: Rafael J. Wysocki

Re: [PATCH v2 0/2] Fix crash in cper_estatus_check()

2019-02-19 Thread Rafael J. Wysocki
On Monday, January 28, 2019 11:04:22 AM CET Ross Lagerwall wrote: > v2 changes: > - Address Boris's comments. > > --- > > I recently encountered a crash in cper_estatus_check() when called by > bert_init(). Patches follow to fix the problem. Note that I cannot fully > test the patches since the

Re: [PATCH v2 0/2] Fix crash in cper_estatus_check()

2019-02-20 Thread Rafael J. Wysocki
On Tuesday, February 19, 2019 2:50:04 PM CET Borislav Petkov wrote: > On Tue, Feb 19, 2019 at 11:00:49AM +0100, Rafael J. Wysocki wrote: > > Boris, any comments here? > > For both: > > Acked-by: Borislav Petkov Both applied, thanks!

Re: [PATCH] acpi: bgrt: parse BGRT to obtain BMP address before it gets clobbered

2019-01-29 Thread Rafael J. Wysocki
On Tue, Jan 29, 2019 at 3:36 PM Ard Biesheuvel wrote: > > On Tue, 22 Jan 2019 at 16:06, Ard Biesheuvel > wrote: > > > > The bitmap left in the framebuffer by the firmware is described by an > > ACPI table called "BGRT", which describes the size, pixel format and > > the address of a BMP image

Re: [PATCH v2 1/8] acpi: Drop drivers/acpi/hmat/ directory

2019-05-31 Thread Rafael J. Wysocki
On Friday, May 31, 2019 12:59:27 AM CEST Dan Williams wrote: > As a single source file object there is no need for the hmat enabling to > have its own directory. Well, I asked Keith to add that directory as the code in hmat.c is more related to mm than to the rest of the ACPI subsystem. Is

Re: [PATCH v3 01/10] acpi/numa: Establish a new drivers/acpi/numa/ directory

2019-06-10 Thread Rafael J. Wysocki
ed to srat.c and moved to drivers/acpi/numa/ along with > hmat.c. > > Cc: Len Brown > Cc: Keith Busch > Cc: "Rafael J. Wysocki" > Signed-off-by: Dan Williams A CC to linux-acpi is missing from this series. > --- > drivers/acpi/Kconfig |9 +

Re: [PATCH v5 00/10] EFI Specific Purpose Memory Support

2019-09-02 Thread Rafael J. Wysocki
|1 > lib/memregion.c | 18 +++ > 41 files changed, 584 insertions(+), 93 deletions(-) > create mode 100644 arch/x86/include/asm/efi-stub.h > delete mode 100644 drivers/acpi/hmat/Makefile > rename drivers/acpi/{hmat/Kconfig => numa/Kconfig} (70%) > create mode 100644 drivers/acpi/numa/Makefile > rename drivers/acpi/{hmat/hmat.c => numa/hmat.c} (85%) > rename drivers/acpi/{numa.c => numa/srat.c} (100%) > create mode 100644 drivers/dax/hmem.c > create mode 100644 drivers/firmware/efi/fake_mem.h > create mode 100644 drivers/firmware/efi/x86-fake_mem.c > create mode 100644 include/linux/memregion.h > create mode 100644 lib/memregion.c > Acked-by: Rafael J. Wysocki for the ACPI-related changes in this series.

Re: [PATCH v5 00/10] EFI Specific Purpose Memory Support

2019-09-06 Thread Rafael J. Wysocki
On 9/5/2019 1:06 AM, Dan Williams wrote: On Mon, Sep 2, 2019 at 4:09 AM Rafael J. Wysocki wrote: On Friday, August 30, 2019 3:52:18 AM CEST Dan Williams wrote: Changes since v4 [1]: - Rename the facility from "Application Reserved" to "Soft Reserved" to better re

Re: [PATCH v7 01/12] acpi/numa: Establish a new drivers/acpi/numa/ directory

2019-10-18 Thread Rafael J. Wysocki
named to srat.c and moved to drivers/acpi/numa/ along with > hmat.c. > > Cc: Len Brown > Cc: Keith Busch > Acked-by: Rafael J. Wysocki > Reviewed-by: Dave Hansen > Signed-off-by: Dan Williams Please note that https://patchwork.kernel.org/patch/11078171/ is being pushed to Linu

Re: [PATCH v7 01/12] acpi/numa: Establish a new drivers/acpi/numa/ directory

2019-10-22 Thread Rafael J. Wysocki
On Fri, Oct 18, 2019 at 11:25 AM Rafael J. Wysocki wrote: > > On Wed, Oct 16, 2019 at 3:13 AM Dan Williams > wrote: > > > > Currently hmat.c lives under an "hmat" directory which does not enhance > > the description of the file. The initial motivation fo

Re: [PATCH v7 11/12] acpi/numa/hmat: Register HMAT at device_initcall level

2019-10-17 Thread Rafael J. Wysocki
ccur > after e820__reserve_resources_late() which is the point at which the > iomem resource tree is populated with "Application Reserved" > (IORES_DESC_APPLICATION_RESERVED). e820__reserve_resources_late() > happens at subsys_initcall time. > > Cc: "Rafael J. Wysocki" > Cc:

Re: [PATCH] sysfs: Unbreak the build around sysfs_bin_attr_simple_read()

2024-05-23 Thread Rafael J. Wysocki
sysfs_bin_attr_simple_read() helper") > Reported-by: Guenter Roeck > Closes: > https://lore.kernel.org/r/e12b0027-b199-4de7-b83d-668171447...@roeck-us.net > Signed-off-by: Lukas Wunner Works for me. Reviewed-by: Rafael J. Wysocki > --- > include/linux/sysfs.h | 9 +

Re: [PATCH 0/2] Deduplicate bin_attribute simple read() callbacks

2024-04-08 Thread Rafael J. Wysocki
| 27 > ++ > include/linux/sysfs.h | 15 > init/initramfs.c | 10 +--- > kernel/module/sysfs.c | 13 +-- > 10 files changed, 56 insertions(+), 85 deletions(-) > > -- For the series Acked-by: Rafael J. Wysocki