Re: [PATCH] efi/bgrt: Drop BGRT status field reserved bits check

[Ard Biesheuvel]

On Wed, 29 May 2019 at 15:28, Hans de Goede  wrote:
>
> Starting with ACPI 6.2 bits 1 and 2 of the BGRT status field are no longer
> reserved. These bits are now used to indicate if the image needs to be
> rotated before being displayed.
>
> The first device using these bits has now shown up (the GPD MicroPC) and
> the reserved bits check causes us to reject the valid BGRT table on this
> device.
>
> Rather then changing the reserved bits check, allowing only the 2 new bits,
> instead just completely remove it so that we do not end up with a similar
> problem when more bits are added in the future.
>
> Signed-off-by: Hans de Goede 

Thanks, Hans. I'll take this as a fix.

> ---
>  drivers/firmware/efi/efi-bgrt.c | 5 -
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/firmware/efi/efi-bgrt.c b/drivers/firmware/efi/efi-bgrt.c
> index a2384184a7de..b07c17643210 100644
> --- a/drivers/firmware/efi/efi-bgrt.c
> +++ b/drivers/firmware/efi/efi-bgrt.c
> @@ -47,11 +47,6 @@ void __init efi_bgrt_init(struct acpi_table_header *table)
>bgrt->version);
> goto out;
> }
> -   if (bgrt->status & 0xfe) {
> -   pr_notice("Ignoring BGRT: reserved status bits are non-zero 
> %u\n",
> -  bgrt->status);
> -   goto out;
> -   }
> if (bgrt->image_type != 0) {
> pr_notice("Ignoring BGRT: invalid image type %u (expected 
> 0)\n",
>bgrt->image_type);
> --
> 2.21.0
>

[PATCH] efi/bgrt: Drop BGRT status field reserved bits check

[Hans de Goede]

Starting with ACPI 6.2 bits 1 and 2 of the BGRT status field are no longer
reserved. These bits are now used to indicate if the image needs to be
rotated before being displayed.

The first device using these bits has now shown up (the GPD MicroPC) and
the reserved bits check causes us to reject the valid BGRT table on this
device.

Rather then changing the reserved bits check, allowing only the 2 new bits,
instead just completely remove it so that we do not end up with a similar
problem when more bits are added in the future.

Signed-off-by: Hans de Goede 
---
 drivers/firmware/efi/efi-bgrt.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/drivers/firmware/efi/efi-bgrt.c b/drivers/firmware/efi/efi-bgrt.c
index a2384184a7de..b07c17643210 100644
--- a/drivers/firmware/efi/efi-bgrt.c
+++ b/drivers/firmware/efi/efi-bgrt.c
@@ -47,11 +47,6 @@ void __init efi_bgrt_init(struct acpi_table_header *table)
   bgrt->version);
goto out;
}
-   if (bgrt->status & 0xfe) {
-   pr_notice("Ignoring BGRT: reserved status bits are non-zero 
%u\n",
-  bgrt->status);
-   goto out;
-   }
if (bgrt->image_type != 0) {
pr_notice("Ignoring BGRT: invalid image type %u (expected 0)\n",
   bgrt->image_type);
-- 
2.21.0