Re: [PATCH] efi: fix pointer type errors in fdt_uefi_find_params()

2014-06-18 Thread Ard Biesheuvel
On 18 June 2014 11:28, Matt Fleming wrote: > On Wed, 18 Jun, at 11:06:09AM, Ard Biesheuvel wrote: >> >> You say potato, I say po-tah-to? >> But seriously, whichever you prefer ... > > $ git grep "const void" | wc -l > 4441 > > $ git grep "void const" | wc -l > 50 > > I say potato, you say "tasty c

Re: [PATCH] efi: fix pointer type errors in fdt_uefi_find_params()

2014-06-18 Thread Matt Fleming
On Wed, 18 Jun, at 11:06:09AM, Ard Biesheuvel wrote: > > You say potato, I say po-tah-to? > But seriously, whichever you prefer ... $ git grep "const void" | wc -l 4441 $ git grep "void const" | wc -l 50 I say potato, you say "tasty carbohydrate ball" But yeah, it's not a big deal and I can fi

Re: [PATCH] efi: fix pointer type errors in fdt_uefi_find_params()

2014-06-18 Thread Ard Biesheuvel
On 18 June 2014 11:02, Matt Fleming wrote: > On Fri, 13 Jun, at 04:54:59PM, Ard Biesheuvel wrote: >> Fix two instances of pointer type errors, a harmless one where a const void* >> value is assigned to a non-const void* variable, and a not-so-harmless one >> where >> we pass a pointer to unsigned

Re: [PATCH] efi: fix pointer type errors in fdt_uefi_find_params()

2014-06-18 Thread Matt Fleming
On Fri, 13 Jun, at 04:54:59PM, Ard Biesheuvel wrote: > Fix two instances of pointer type errors, a harmless one where a const void* > value is assigned to a non-const void* variable, and a not-so-harmless one > where > we pass a pointer to unsigned long where a pointer to int is expected. > > Sig

[PATCH] efi: fix pointer type errors in fdt_uefi_find_params()

2014-06-13 Thread Ard Biesheuvel
Fix two instances of pointer type errors, a harmless one where a const void* value is assigned to a non-const void* variable, and a not-so-harmless one where we pass a pointer to unsigned long where a pointer to int is expected. Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/efi.c | 4 ++