Re: [PATCH] efivarfs: 'efivarfs_file_write' function reorganization

2013-10-30 Thread Matt Fleming
On Mon, 14 Oct, at 03:37:17PM, Geyslan G. Bem wrote: This reorganization: Adds 'attrsize' variable to make the code cleaner and more understandable, replacing all 'sizeof(attributes)'. Removes 'bytes' prior assignment due this new approach. Uses 'memdup_user' instead 'kmalloc' +

Re: [PATCH] efivarfs: 'efivarfs_file_write' function reorganization

2013-10-30 Thread Geyslan Gregório Bem
2013/10/30 Matt Fleming m...@console-pimps.org: On Mon, 14 Oct, at 03:37:17PM, Geyslan G. Bem wrote: This reorganization: Adds 'attrsize' variable to make the code cleaner and more understandable, replacing all 'sizeof(attributes)'. Removes 'bytes' prior assignment due this new approach.

Re: [PATCH] efivarfs: 'efivarfs_file_write' function reorganization

2013-10-30 Thread Matt Fleming
On Wed, 30 Oct, at 10:44:16AM, Geyslan Gregório Bem wrote: Do you want that I undo that? I aggre that the variable use only reduces the line code. Yes please. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line unsubscribe linux-efi in the body

[PATCH] efivarfs: 'efivarfs_file_write' function reorganization

2013-10-14 Thread Geyslan G. Bem
This reorganization: Adds 'attrsize' variable to make the code cleaner and more understandable, replacing all 'sizeof(attributes)'. Removes 'bytes' prior assignment due this new approach. Uses 'memdup_user' instead 'kmalloc' + 'copy_from_user'. Signed-off-by: Geyslan G. Bem geys...@gmail.com