Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints

2015-09-12 Thread joeyli
On Wed, Sep 09, 2015 at 01:24:08PM +0100, Matt Fleming wrote: > On Thu, 27 Aug, at 06:21:44PM, joeyli wrote: > > On Fri, Aug 21, 2015 at 02:27:53PM +0100, Matt Fleming wrote: > > > On Tue, 11 Aug, at 02:16:29PM, Lee, Chun-Yi wrote: > > > > +static int __init init_hibernation_keys(void) > > > > +{

Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints

2015-09-09 Thread Matt Fleming
On Thu, 27 Aug, at 06:21:44PM, joeyli wrote: > On Fri, Aug 21, 2015 at 02:27:53PM +0100, Matt Fleming wrote: > > On Tue, 11 Aug, at 02:16:29PM, Lee, Chun-Yi wrote: > > > +static int __init init_hibernation_keys(void) > > > +{ > > > + struct hibernation_keys *keys; > > > + int ret = 0; > > > + > >

Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints

2015-08-27 Thread joeyli
On Fri, Aug 21, 2015 at 02:27:53PM +0100, Matt Fleming wrote: On Tue, 11 Aug, at 02:16:29PM, Lee, Chun-Yi wrote: Add handler to parse the setup data that carrying hibernation key, it reserves hibernation key by memblock then copies key to a allocated page in later initcall stage. And

Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints

2015-08-21 Thread Matt Fleming
On Tue, 11 Aug, at 02:16:29PM, Lee, Chun-Yi wrote: Add handler to parse the setup data that carrying hibernation key, it reserves hibernation key by memblock then copies key to a allocated page in later initcall stage. And for erasing footprints, the codes in this patch remove setup data

Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints

2015-08-13 Thread joeyli
On Tue, Aug 11, 2015 at 02:16:29PM +0800, Lee, Chun-Yi wrote: Add handler to parse the setup data that carrying hibernation key, it reserves hibernation key by memblock then copies key to a allocated page in later initcall stage. [...snip] diff --git a/arch/x86/power/hibernate_keys.c

Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints

2015-08-12 Thread joeyli
Hi Yu, Thanks for your reviewing. On Thu, Aug 13, 2015 at 02:45:32AM +, Chen, Yu C wrote: Hi Chun-yi, On Tue, 2015-08-11 at 14:16 +0800, Lee, Chun-Yi wrote: +/* A page used to keep hibernation keys */ +static struct hibernation_keys *hibernation_keys; + +void __init

Re: [PATCH v2 09/16] PM / hibernate: Reserve hibernation key and erase footprints

2015-08-12 Thread Chen, Yu C
Hi Chun-yi, On Tue, 2015-08-11 at 14:16 +0800, Lee, Chun-Yi wrote: +/* A page used to keep hibernation keys */ +static struct hibernation_keys *hibernation_keys; + +void __init parse_hibernation_keys(u64 phys_addr, u32 data_len) +{ + struct setup_data *hibernation_setup_data; + +