Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-15 Thread Ard Biesheuvel
On 14 July 2018 at 13:41, Lukas Wunner wrote: > On Fri, Jul 13, 2018 at 03:54:29PM +0200, Ard Biesheuvel wrote: >> Did you have any thoughts about how we could at least detect >> situations where we are invoking protocols that are not mixed-mode >> safe (i.e., they pass 64-bit quantities by

Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-14 Thread Lukas Wunner
On Fri, Jul 13, 2018 at 03:54:29PM +0200, Ard Biesheuvel wrote: > Did you have any thoughts about how we could at least detect > situations where we are invoking protocols that are not mixed-mode > safe (i.e., they pass 64-bit quantities by value, which our current > thunking routine does not take

Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-13 Thread Ard Biesheuvel
On 13 July 2018 at 11:57, Lukas Wunner wrote: > On Thu, Jul 12, 2018 at 02:21:48PM +0200, Ard Biesheuvel wrote: >> Patch #2 merges the remaining 32/64-bit specific parts of the setup_efi_pci >> routine. >> >> Patches #3 and #4 do the same for the UGA draw protocol discovery routines. >> >> Patch

Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-13 Thread Ard Biesheuvel
On 13 July 2018 at 15:29, Ingo Molnar wrote: > > * Lukas Wunner wrote: > >> --- a/drivers/firmware/efi/libstub/efi-stub-helper.c >> +++ b/drivers/firmware/efi/libstub/efi-stub-helper.c >> @@ -413,6 +413,32 @@ static efi_status_t efi_file_close(void *handle) >> return

Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-13 Thread Ingo Molnar
* Lukas Wunner wrote: > --- a/drivers/firmware/efi/libstub/efi-stub-helper.c > +++ b/drivers/firmware/efi/libstub/efi-stub-helper.c > @@ -413,6 +413,32 @@ static efi_status_t efi_file_close(void *handle) > return efi_call_proto(efi_file_handle, close, handle); > } > > +static

Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-13 Thread Lukas Wunner
On Thu, Jul 12, 2018 at 02:21:48PM +0200, Ard Biesheuvel wrote: > Patch #2 merges the remaining 32/64-bit specific parts of the setup_efi_pci > routine. > > Patches #3 and #4 do the same for the UGA draw protocol discovery routines. > > Patch #6 helps unused code paths to be optimized away on

RE: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-12 Thread Prakhya, Sai Praneeth
> >> Patch #6 helps unused code paths to be optimized away on > >> configurations that don't need them (32-bit only and 64-bit only) > > > > I have tested this patch set on qemu and I see mixed mode kernel not > > booting. > > My test setup is: > > Running qemu-system-x86_64 with 32 bit OVMF and

Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-12 Thread Ard Biesheuvel
On 13 July 2018 at 03:59, Prakhya, Sai Praneeth wrote: > Hi Ard, > >> This series contains some fixes and cleanups for mixed-mode UEFI on x86. >> >> Patch #1 adds the missing locking in the runtime service wrapper code for >> mixed >> mode. This was found by inspection rather than having been

RE: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-12 Thread Prakhya, Sai Praneeth
Hi Ard, > This series contains some fixes and cleanups for mixed-mode UEFI on x86. > > Patch #1 adds the missing locking in the runtime service wrapper code for > mixed > mode. This was found by inspection rather than having been reported but could > be a candidate for -stable nonetheless. > >

Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-12 Thread Ard Biesheuvel
On 12 July 2018 at 16:26, Hans de Goede wrote: > Hi, > > On 12-07-18 14:21, Ard Biesheuvel wrote: >> >> This series contains some fixes and cleanups for mixed-mode UEFI on x86. >> >> Patch #1 adds the missing locking in the runtime service wrapper code for >> mixed mode. This was found by

Re: [PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-12 Thread Hans de Goede
Hi, On 12-07-18 14:21, Ard Biesheuvel wrote: This series contains some fixes and cleanups for mixed-mode UEFI on x86. Patch #1 adds the missing locking in the runtime service wrapper code for mixed mode. This was found by inspection rather than having been reported but could be a candidate for

[PATCH 0/6] efi/x86 mixed mode cleanups

2018-07-12 Thread Ard Biesheuvel
This series contains some fixes and cleanups for mixed-mode UEFI on x86. Patch #1 adds the missing locking in the runtime service wrapper code for mixed mode. This was found by inspection rather than having been reported but could be a candidate for -stable nonetheless. Patch #2 merges the