Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
On Tue, Apr 24, 2018 at 08:39:09AM +0200, Ard Biesheuvel wrote: > On 23 April 2018 at 21:38, Jarkko Sakkinen > wrote: > > On Mon, Apr 16, 2018 at 01:05:24PM +0200, Ard Biesheuvel wrote: > >> On 22 March 2018 at 15:09, Jarkko Sakkinen > >> wrote: > >> > On Thu, 2018-03-22 at 16:06 +0200, Jarkko Sakkinen wrote: > >> >> On Tue, 2018-03-20 at 14:17 +, Wei Yongjun wrote: > >> >> > Fixes the following sparse warning: > >> >> > > >> >> > drivers/firmware/efi/libstub/tpm.c:62:6: warning: > >> >> > symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it > >> >> > be > >> >> > static? > >> >> > > >> >> > Signed-off-by: Wei Yongjun > >> >> > --- > >> >> > drivers/firmware/efi/libstub/tpm.c | 2 +- > >> >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> >> > > >> >> > diff --git a/drivers/firmware/efi/libstub/tpm.c > >> >> > b/drivers/firmware/efi/libstub/tpm.c > >> >> > index 9d08cea..caa37a6 100644 > >> >> > --- a/drivers/firmware/efi/libstub/tpm.c > >> >> > +++ b/drivers/firmware/efi/libstub/tpm.c > >> >> > @@ -59,7 +59,7 @@ void > >> >> > efi_enable_reset_attack_mitigation(efi_system_table_t > >> >> > *sys_table_arg) > >> >> > > >> >> > #endif > >> >> > > >> >> > -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t > >> >> > *sys_table_arg) > >> >> > +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t > >> >> > *sys_table_arg) > >> >> > { > >> >> > efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID; > >> >> > efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID; > >> >> > > >> >> > >> >> Reviewed-by: Jarkko Sakkinen > >> > > >> > Applied. > >> > > >> > >> Applied to? > > > > Mistake, efi maintainers should pick this one up. Sorry (my reviewed tag > > still holds). > > > > Thanks. I have queued this up in efi/next And sorry for the confusion! Had a lot of traffic that point.. /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
On 23 April 2018 at 21:38, Jarkko Sakkinen wrote: > On Mon, Apr 16, 2018 at 01:05:24PM +0200, Ard Biesheuvel wrote: >> On 22 March 2018 at 15:09, Jarkko Sakkinen >> wrote: >> > On Thu, 2018-03-22 at 16:06 +0200, Jarkko Sakkinen wrote: >> >> On Tue, 2018-03-20 at 14:17 +, Wei Yongjun wrote: >> >> > Fixes the following sparse warning: >> >> > >> >> > drivers/firmware/efi/libstub/tpm.c:62:6: warning: >> >> > symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be >> >> > static? >> >> > >> >> > Signed-off-by: Wei Yongjun >> >> > --- >> >> > drivers/firmware/efi/libstub/tpm.c | 2 +- >> >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> >> > >> >> > diff --git a/drivers/firmware/efi/libstub/tpm.c >> >> > b/drivers/firmware/efi/libstub/tpm.c >> >> > index 9d08cea..caa37a6 100644 >> >> > --- a/drivers/firmware/efi/libstub/tpm.c >> >> > +++ b/drivers/firmware/efi/libstub/tpm.c >> >> > @@ -59,7 +59,7 @@ void >> >> > efi_enable_reset_attack_mitigation(efi_system_table_t >> >> > *sys_table_arg) >> >> > >> >> > #endif >> >> > >> >> > -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg) >> >> > +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t >> >> > *sys_table_arg) >> >> > { >> >> > efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID; >> >> > efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID; >> >> > >> >> >> >> Reviewed-by: Jarkko Sakkinen >> > >> > Applied. >> > >> >> Applied to? > > Mistake, efi maintainers should pick this one up. Sorry (my reviewed tag > still holds). > Thanks. I have queued this up in efi/next -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
On Mon, Apr 16, 2018 at 01:05:24PM +0200, Ard Biesheuvel wrote: > On 22 March 2018 at 15:09, Jarkko Sakkinen > wrote: > > On Thu, 2018-03-22 at 16:06 +0200, Jarkko Sakkinen wrote: > >> On Tue, 2018-03-20 at 14:17 +, Wei Yongjun wrote: > >> > Fixes the following sparse warning: > >> > > >> > drivers/firmware/efi/libstub/tpm.c:62:6: warning: > >> > symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be > >> > static? > >> > > >> > Signed-off-by: Wei Yongjun > >> > --- > >> > drivers/firmware/efi/libstub/tpm.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/firmware/efi/libstub/tpm.c > >> > b/drivers/firmware/efi/libstub/tpm.c > >> > index 9d08cea..caa37a6 100644 > >> > --- a/drivers/firmware/efi/libstub/tpm.c > >> > +++ b/drivers/firmware/efi/libstub/tpm.c > >> > @@ -59,7 +59,7 @@ void > >> > efi_enable_reset_attack_mitigation(efi_system_table_t > >> > *sys_table_arg) > >> > > >> > #endif > >> > > >> > -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg) > >> > +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t > >> > *sys_table_arg) > >> > { > >> > efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID; > >> > efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID; > >> > > >> > >> Reviewed-by: Jarkko Sakkinen > > > > Applied. > > > > Applied to? Mistake, efi maintainers should pick this one up. Sorry (my reviewed tag still holds). /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
On 22 March 2018 at 15:09, Jarkko Sakkinen wrote: > On Thu, 2018-03-22 at 16:06 +0200, Jarkko Sakkinen wrote: >> On Tue, 2018-03-20 at 14:17 +, Wei Yongjun wrote: >> > Fixes the following sparse warning: >> > >> > drivers/firmware/efi/libstub/tpm.c:62:6: warning: >> > symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be >> > static? >> > >> > Signed-off-by: Wei Yongjun >> > --- >> > drivers/firmware/efi/libstub/tpm.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/firmware/efi/libstub/tpm.c >> > b/drivers/firmware/efi/libstub/tpm.c >> > index 9d08cea..caa37a6 100644 >> > --- a/drivers/firmware/efi/libstub/tpm.c >> > +++ b/drivers/firmware/efi/libstub/tpm.c >> > @@ -59,7 +59,7 @@ void >> > efi_enable_reset_attack_mitigation(efi_system_table_t >> > *sys_table_arg) >> > >> > #endif >> > >> > -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg) >> > +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t >> > *sys_table_arg) >> > { >> > efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID; >> > efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID; >> > >> >> Reviewed-by: Jarkko Sakkinen > > Applied. > Applied to? -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
On Thu, 2018-03-22 at 16:06 +0200, Jarkko Sakkinen wrote: > On Tue, 2018-03-20 at 14:17 +, Wei Yongjun wrote: > > Fixes the following sparse warning: > > > > drivers/firmware/efi/libstub/tpm.c:62:6: warning: > > symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be > > static? > > > > Signed-off-by: Wei Yongjun > > --- > > drivers/firmware/efi/libstub/tpm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/firmware/efi/libstub/tpm.c > > b/drivers/firmware/efi/libstub/tpm.c > > index 9d08cea..caa37a6 100644 > > --- a/drivers/firmware/efi/libstub/tpm.c > > +++ b/drivers/firmware/efi/libstub/tpm.c > > @@ -59,7 +59,7 @@ void efi_enable_reset_attack_mitigation(efi_system_table_t > > *sys_table_arg) > > > > #endif > > > > -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg) > > +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t > > *sys_table_arg) > > { > > efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID; > > efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID; > > > > Reviewed-by: Jarkko Sakkinen Applied. /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH -next] efi/libstub/tpm: Make function efi_retrieve_tpm2_eventlog_1_2() static
On Tue, 2018-03-20 at 14:17 +, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/firmware/efi/libstub/tpm.c:62:6: warning: > symbol 'efi_retrieve_tpm2_eventlog_1_2' was not declared. Should it be > static? > > Signed-off-by: Wei Yongjun > --- > drivers/firmware/efi/libstub/tpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/efi/libstub/tpm.c > b/drivers/firmware/efi/libstub/tpm.c > index 9d08cea..caa37a6 100644 > --- a/drivers/firmware/efi/libstub/tpm.c > +++ b/drivers/firmware/efi/libstub/tpm.c > @@ -59,7 +59,7 @@ void efi_enable_reset_attack_mitigation(efi_system_table_t > *sys_table_arg) > > #endif > > -void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg) > +static void efi_retrieve_tpm2_eventlog_1_2(efi_system_table_t *sys_table_arg) > { > efi_guid_t tcg2_guid = EFI_TCG2_PROTOCOL_GUID; > efi_guid_t linux_eventlog_guid = LINUX_EFI_TPM_EVENT_LOG_GUID; > Reviewed-by: Jarkko Sakkinen /Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html