RE: [PATCH v4 0/2] Add EFI capsule pstore backend support

2017-06-27 Thread Zhuo, Qiuxu
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > >> It looks like that my test BIOS on Intel Kabylake board interprets it >> *pointer" and pack the array, so my patch can work on that board. > > Are you running 64-bit firmware on this board? Because the EDK2 side lacks > the 'packed'

Re: [PATCH v4 0/2] Add EFI capsule pstore backend support

2017-06-26 Thread Ard Biesheuvel
On 26 June 2017 at 04:09, Zhuo, Qiuxu wrote: >> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] >> >> Actually, no, The issue I raised the last time around was not addressed >> anywhere, and is not even mentioned in the commit log. >> >> The problem is that there is

RE: [PATCH v4 0/2] Add EFI capsule pstore backend support

2017-06-25 Thread Zhuo, Qiuxu
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Actually, no, The issue I raised the last time around was not addressed > anywhere, and is not even mentioned in the commit log. > > The problem is that there is an ambiguity in the implementation of the > configuration table entries

Re: [PATCH v4 0/2] Add EFI capsule pstore backend support

2017-06-24 Thread Ard Biesheuvel
On 23 June 2017 at 23:03, Ard Biesheuvel wrote: > On 23 June 2017 at 20:42, Kees Cook wrote: >> On Thu, Jun 22, 2017 at 9:34 AM, Qiuxu Zhuo wrote: >>> Change Log v3->v4: >>> - Add comment 'the number of config tables' for

Re: [PATCH v4 0/2] Add EFI capsule pstore backend support

2017-06-23 Thread Ard Biesheuvel
On 23 June 2017 at 20:42, Kees Cook wrote: > On Thu, Jun 22, 2017 at 9:34 AM, Qiuxu Zhuo wrote: >> Change Log v3->v4: >> - Add comment 'the number of config tables' for 'nr_config_table' in efi >> structure >> - Initialize 'efi.nr_config_table' to

Re: [PATCH v4 0/2] Add EFI capsule pstore backend support

2017-06-23 Thread Kees Cook
On Thu, Jun 22, 2017 at 9:34 AM, Qiuxu Zhuo wrote: > Change Log v3->v4: > - Add comment 'the number of config tables' for 'nr_config_table' in efi > structure > - Initialize 'efi.nr_config_table' to 0 in default > - Set 'efi.nr_config_table' to 'efi.systab->nr_tables' in