Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-10 Thread Geert Uytterhoeven
Hi Phillip, On Thu, Dec 10, 2009 at 01:38, Phillip Lougher phil...@lougher.demon.co.uk wrote: Artem Bityutskiy wrote: Did you consider using cryptoapi? UBIFS uses zlib/lzo in cryptoapi - it is a very clean way. Exactly my question, as that's why the Crypto API was extended with support for

Squashfs performance (3.3 vs 4.0 in mainline)

2009-12-10 Thread Simon Kagstrom
Hi! I'm running 2.6.31 on a slow ARM platform and using squashfs 4.0 as shipped with the kernel. It's a Sharp LH79524, so the architecture itself isn't mainlined yet. Squashfs works well, but I've noted a performance regression compared to the out-of-tree squashfs 3.3 which we ran on 2.6.23. The

Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-10 Thread Phillip Lougher
Geert Uytterhoeven wrote: Yes I did consider using the cryptoapi, but this doesn't have support for lzma in mainline. IIRC, Felix Fietkau added support for that for OpenWRT... Yes, but it isn't in mainline, and OpenWRT don't appear to have tried to submit it. IMHO the major problem with

Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-10 Thread Felix Fietkau
On 2009-12-10 10:17 PM, Phillip Lougher wrote: Geert Uytterhoeven wrote: Yes I did consider using the cryptoapi, but this doesn't have support for lzma in mainline. IIRC, Felix Fietkau added support for that for OpenWRT... Yes, but it isn't in mainline, and OpenWRT don't appear to

Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-10 Thread Phillip Lougher
Geert Uytterhoeven wrote: Hi Phillip, On Thu, Dec 10, 2009 at 01:38, Phillip Lougher phil...@lougher.demon.co.uk wrote: Artem Bityutskiy wrote: Did you consider using cryptoapi? UBIFS uses zlib/lzo in cryptoapi - it is a very clean way. Exactly my question, as that's why the Crypto API was

[PATCH V2 0/9] Squashfs: Add support for LZMA compressed filesystems

2009-12-10 Thread Phillip Lougher
Hi, This a respin of my LZMA decompression support patches, taking into account Andrew Morton's comments regarding poorly named globals: Changes: 1. zlib_uncompress() renamed to squashfs_zlib_uncompress() (patch 1) 2. zlib_init() and zlib_free() renamed to squashfs_zlib_init()

[PATCH V2 3/8] Squashfs: add a decompressor framework

2009-12-10 Thread Phillip Lougher
This adds a decompressor framework which allows multiple compression algorithms to be cleanly supported. Also update zlib wrapper and other code to use the new framework. Signed-off-by: Phillip Lougher phil...@lougher.demon.co.uk --- fs/squashfs/Makefile |2 +- fs/squashfs/block.c

[PATCH V2 7/8] Squashfs: select DECOMPRESS_LZMA_NEEDED when including support for lzma

2009-12-10 Thread Phillip Lougher
Signed-off-by: Phillip Lougher phil...@lougher.demon.co.uk --- fs/squashfs/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/squashfs/Kconfig b/fs/squashfs/Kconfig index 0294aa2..7ec5d7e 100644 --- a/fs/squashfs/Kconfig +++ b/fs/squashfs/Kconfig @@ -30,6 +30,7

[PATCH V2 1/8] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-10 Thread Phillip Lougher
Signed-off-by: Phillip Lougher phil...@lougher.demon.co.uk --- fs/squashfs/Makefile |2 +- fs/squashfs/block.c| 74 ++ fs/squashfs/squashfs.h |4 ++ fs/squashfs/zlib_wrapper.c | 109 4 files

[PATCH V2 5/8] Squashfs: add support for LZMA compressed filesystems

2009-12-10 Thread Phillip Lougher
Signed-off-by: Phillip Lougher phil...@lougher.demon.co.uk --- fs/squashfs/Kconfig|5 ++ fs/squashfs/Makefile |1 + fs/squashfs/decompressor.c |4 + fs/squashfs/lzma_wrapper.c | 151 fs/squashfs/squashfs.h |3 + 5