Re: [PATCH 0/7] printk: add pr_level_once, guard print_hex_dump

2010-12-06 Thread Matt Mackall
On Sun, 2010-12-05 at 21:44 -0800, Joe Perches wrote: There are many uses of printk_once(KERN_level. Add pr_level_once macros to avoid printk_once(KERN_level pr_fmt(fmt). Add an #ifdef CONFIG_PRINTK for print_hex_dump and static inline void functions for the #else cases to reduce embedded code

Re: [PATCH 0/7] printk: add pr_level_once, guard print_hex_dump

2010-12-06 Thread Joe Perches
On Mon, 2010-12-06 at 09:37 -0600, Matt Mackall wrote: On Sun, 2010-12-05 at 21:44 -0800, Joe Perches wrote: There are many uses of printk_once(KERN_level. Add pr_level_once macros to avoid printk_once(KERN_level pr_fmt(fmt). Add an #ifdef CONFIG_PRINTK for print_hex_dump and static inline

Re: [PATCH 0/7] printk: add pr_level_once, guard print_hex_dump

2010-12-06 Thread Matt Mackall
On Mon, 2010-12-06 at 10:12 -0800, Joe Perches wrote: On Mon, 2010-12-06 at 09:37 -0600, Matt Mackall wrote: On Sun, 2010-12-05 at 21:44 -0800, Joe Perches wrote: There are many uses of printk_once(KERN_level. Add pr_level_once macros to avoid printk_once(KERN_level pr_fmt(fmt). Add an

Re: [PATCH 0/7] printk: add pr_level_once, guard print_hex_dump

2010-12-06 Thread Joe Perches
On Mon, 2010-12-06 at 12:16 -0600, Matt Mackall wrote: On Mon, 2010-12-06 at 10:12 -0800, Joe Perches wrote: There could be ~500 bytes more saved if hex_dump_to_buffer was compiled out. Can't say I'm excited by this approach. .5k is under my threshold for this level of invasiveness. Mine

[PATCH 0/7] printk: add pr_level_once, guard print_hex_dump

2010-12-05 Thread Joe Perches
There are many uses of printk_once(KERN_level. Add pr_level_once macros to avoid printk_once(KERN_level pr_fmt(fmt). Add an #ifdef CONFIG_PRINTK for print_hex_dump and static inline void functions for the #else cases to reduce embedded code size. Neaten and organize the rest of the code. Joe