Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-10 Thread Phillip Lougher
Geert Uytterhoeven wrote: Hi Phillip, On Thu, Dec 10, 2009 at 01:38, Phillip Lougher wrote: Artem Bityutskiy wrote: Did you consider using cryptoapi? UBIFS uses zlib/lzo in cryptoapi - it is a very clean way. Exactly my question, as that's why the Crypto API was extended with support for pa

Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-10 Thread Felix Fietkau
On 2009-12-10 10:17 PM, Phillip Lougher wrote: > Geert Uytterhoeven wrote: >> >>> Yes I did consider using the cryptoapi, but this doesn't have support for >>> lzma in mainline. >> >> IIRC, Felix Fietkau added support for that for OpenWRT... >> > > Yes, but it isn't in mainline, and OpenWRT don

Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-10 Thread Phillip Lougher
Geert Uytterhoeven wrote: Yes I did consider using the cryptoapi, but this doesn't have support for lzma in mainline. IIRC, Felix Fietkau added support for that for OpenWRT... Yes, but it isn't in mainline, and OpenWRT don't appear to have tried to submit it. IMHO the major problem with t

Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-10 Thread Geert Uytterhoeven
Hi Phillip, On Thu, Dec 10, 2009 at 01:38, Phillip Lougher wrote: > Artem Bityutskiy wrote: >> >> Did you consider using cryptoapi? UBIFS uses zlib/lzo in cryptoapi - it >> is a very clean way. Exactly my question, as that's why the Crypto API was extended with support for partial (de)compressio

Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-09 Thread Phillip Lougher
Artem Bityutskiy wrote: Did you consider using cryptoapi? UBIFS uses zlib/lzo in cryptoapi - it is a very clean way. Yes I did consider using the cryptoapi, but this doesn't have support for lzma in mainline. My aim is add lzma filesystem support to Squashfs using the existing kernel lzma ip

Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-09 Thread Artem Bityutskiy
On Tue, 2009-12-08 at 22:20 +, Phillip Lougher wrote: > Andrew Morton wrote: > > On Mon, 07 Dec 2009 02:25:08 + > > Phillip Lougher wrote: > > > >> + > >> +int zlib_uncompress(struct squashfs_sb_info *msblk, void **buffer, > >> + struct buffer_head **bh, int b, int offset, int length, in

Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-08 Thread Phillip Lougher
Andrew Morton wrote: On Mon, 07 Dec 2009 02:25:08 + Phillip Lougher wrote: + +int zlib_uncompress(struct squashfs_sb_info *msblk, void **buffer, + struct buffer_head **bh, int b, int offset, int length, int srclength, + int pages) This isn't a very good function name. zlib_u

Re: [PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-07 Thread Andrew Morton
On Mon, 07 Dec 2009 02:25:08 + Phillip Lougher wrote: > +++ b/fs/squashfs/zlib_wrapper.c > @@ -0,0 +1,109 @@ > +/* > + * Squashfs - a compressed read only filesystem for Linux > + * > + * Copyright (c) 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 > + * Phillip Lougher > + * > + * This prog

[PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-07 Thread Phillip Lougher
Signed-off-by: Phillip Lougher --- fs/squashfs/Makefile |2 +- fs/squashfs/block.c| 74 ++ fs/squashfs/squashfs.h |4 ++ fs/squashfs/zlib_wrapper.c | 109 4 files changed, 118 insertions(+), 71

[PATCH 1/9] Squashfs: move zlib decompression wrapper code into a separate file

2009-12-07 Thread root
Signed-off-by: Phillip Lougher --- fs/squashfs/Makefile |2 +- fs/squashfs/block.c| 74 ++ fs/squashfs/squashfs.h |4 ++ fs/squashfs/zlib_wrapper.c | 109 4 files changed, 118 insertions(+), 71