Re: [PATCH 1/6] [PWM] Generic PWM API implementation

2008-11-04 Thread David Brownell
On Tuesday 04 November 2008, Mike Frysinger wrote: > On Tue, Nov 4, 2008 at 18:55, David Brownell wrote: > > On Tuesday 04 November 2008, Bill Gatliff wrote: > >> So, what's the next step? How do I advocate for getting > >> this API into mainline? > > > > The number of backing implementations seem

Re: [PATCH 1/6] [PWM] Generic PWM API implementation

2008-11-04 Thread Bill Gatliff
Mike Frysinger wrote: > every Blackfin processor so far has had dedicated PWM hardware in it, > so a backend driver for that arch would show up ... >From who? I don't have that hardware. I'm happy to hear that someone is working on it, though, and I would be happy to help review. > i'm guessing

Re: [PATCH 1/6] [PWM] Generic PWM API implementation

2008-11-04 Thread Bill Gatliff
David Brownell wrote: > > Patches #1 and #2 seem to be in the wrong order ... and > #2 shouldn't give the header's full pathname. I'd have > merged the two, myself. Ok, that's good feedback. > Patch #6 seems to remove LEDS_ATMEL_PWM from Kconfig but > leave the driver around ... and restore the

Re: [PATCH 1/6] [PWM] Generic PWM API implementation

2008-11-04 Thread Mike Frysinger
On Tue, Nov 4, 2008 at 18:55, David Brownell wrote: > On Tuesday 04 November 2008, Bill Gatliff wrote: >> So, what's the next step? How do I advocate for getting >> this API into mainline? > > The number of backing implementations seemed a bit low ... > just one. And that's switching Atmel's dedi

Re: [PATCH 1/6] [PWM] Generic PWM API implementation

2008-11-04 Thread David Brownell
On Tuesday 04 November 2008, Bill Gatliff wrote: > This is literally the only feedback I have received. I was waiting for followup too. I finally get onto this list (for some reason the list management software dropped several previous "please add me" requests) and ... nothing!! Patches #1 and

Re: [PATCH 1/6] [PWM] Generic PWM API implementation

2008-11-04 Thread Mike Frysinger
On Tue, Nov 4, 2008 at 15:16, Bill Gatliff wrote: > Mike Frysinger wrote: >> On Wed, Oct 15, 2008 at 14:14, Bill Gatliff wrote: >>> +int pwm_register(struct pwm_device *pwm) >>> +{ >>> + struct pwm_channel *p; >>> + int wchan; >>> + int ret = 0; >> >> the initialization to 0 here

Re: [PATCH 1/6] [PWM] Generic PWM API implementation

2008-11-04 Thread Bill Gatliff
Mike Frysinger wrote: > On Wed, Oct 15, 2008 at 14:14, Bill Gatliff wrote: >> +int pwm_register(struct pwm_device *pwm) >> +{ >> + struct pwm_channel *p; >> + int wchan; >> + int ret = 0; > > the initialization to 0 here isnt needed This is literally the only feedback I have rec

Re: [PATCH 1/6] [PWM] Generic PWM API implementation

2008-10-17 Thread Mike Frysinger
On Wed, Oct 15, 2008 at 14:14, Bill Gatliff wrote: > +int pwm_register(struct pwm_device *pwm) > +{ > + struct pwm_channel *p; > + int wchan; > + int ret = 0; the initialization to 0 here isnt needed -mike -- To unsubscribe from this list: send the line "unsubscribe linux-embedde