Re: [PATCH 1/6] lib/decompress_*: only include linux/slab.h if STATIC is not defined

2009-08-04 Thread Andrew Morton
On Mon, 3 Aug 2009 16:58:16 +0200 Albin Tonnerre albin.tonne...@free-electrons.com wrote: These includes were added by 079effb6933f34b9b1b67b08bd4fd7fb672d16ef to fix the build when using kmemtrace. However this is not necessary when used to create a compressed kernel, and actually creates

Re: [PATCH 2/6] include/linux/unaligned/{l,b}e_byteshift.h: Fix usage for compressed kernels

2009-08-04 Thread Andrew Morton
On Mon, 3 Aug 2009 16:58:17 +0200 Albin Tonnerre albin.tonne...@free-electrons.com wrote: When unaligned accesses are required for uncompressing a kernel (such as for LZO decompression on ARM in a patch that follows), including linux/kernel.h causes issues as it brings in a lot of things that

Re: [PATCH 3/6] Add support for LZO-compressed kernels

2009-08-04 Thread Andrew Morton
On Mon, 3 Aug 2009 16:58:18 +0200 Albin Tonnerre albin.tonne...@free-electrons.com wrote: This is the first part of the lzo patch Please pass this patch (and all others!) through scritps/checkpatch.pl. checkpatch reports a number of trivial errors which you wouldn't have included had you

Re: New MMC maintainer needed

2009-08-04 Thread David Brownell
On Friday 31 July 2009, Pierre Ossman wrote: Restoring back the system state from MMC after a successful hibernation http://marc.info/?t=12481853473r=1w=2 I don't agree with this approach. The point of the workqueue is so that the kernel can do things in parallel, so this patch is a step

Re: [PATCH 1/6] lib/decompress_*: only include linux/slab.h if STATIC is not defined

2009-08-04 Thread Phillip Lougher
Andrew Morton wrote: On Mon, 3 Aug 2009 16:58:16 +0200 Albin Tonnerre albin.tonne...@free-electrons.com wrote: These includes were added by 079effb6933f34b9b1b67b08bd4fd7fb672d16ef to fix the build when using kmemtrace. However this is not necessary when used to create a compressed kernel,

Re: [PATCH 1/6] lib/decompress_*: only include linux/slab.h if STATIC is not defined

2009-08-04 Thread H. Peter Anvin
On 08/04/2009 05:47 PM, Phillip Lougher wrote: Andrew Morton wrote: On Mon, 3 Aug 2009 16:58:16 +0200 Albin Tonnerre albin.tonne...@free-electrons.com wrote: These includes were added by 079effb6933f34b9b1b67b08bd4fd7fb672d16ef to fix the build when using kmemtrace. However this is not

Re: [PATCH 3/6] Add support for LZO-compressed kernels

2009-08-04 Thread H. Peter Anvin
On 08/04/2009 04:00 PM, Andrew Morton wrote: 0.24 seconds booting speedup sounds pretty thin. Adding a new decompression format will introduce more configuration/build/deployment complexities. How do we justify this? Keep in mind this may be out of a 3-5 second boot budget. -hpa

Re: [PATCH 1/6] lib/decompress_*: only include linux/slab.h if STATIC is not defined

2009-08-04 Thread Phillip Lougher
H. Peter Anvin wrote: On 08/04/2009 05:47 PM, Phillip Lougher wrote: Andrew Morton wrote: On Mon, 3 Aug 2009 16:58:16 +0200 Albin Tonnerre albin.tonne...@free-electrons.com wrote: These includes were added by 079effb6933f34b9b1b67b08bd4fd7fb672d16ef to fix the build when using kmemtrace.

Re: [PATCH 1/6] lib/decompress_*: only include linux/slab.h if STATIC is not defined

2009-08-04 Thread Phillip Lougher
Andrew Morton wrote: On Wed, 05 Aug 2009 01:47:57 +0100 Phillip Lougher phil...@lougher.demon.co.uk wrote: What do you normally do in this situation? I normally fix the rejects ;) But I'd like to confirm that the two patches don't fix the same thing via different means. Lacking a full