Re: [patch 2/4] Configure out file locking features

2008-07-31 Thread Uwe Kleine-König
Hello Thomas, Thomas Petazzoni wrote: Le Wed, 30 Jul 2008 17:27:54 +0300, Adrian Bunk [EMAIL PROTECTED] a écrit : It seems the emails containing the patches never made it to the vger lists, which makes it a bit hard to comment on them. Yes, they didn't make it to the lists, for some

[patch 1/4] Configure out AIO support

2008-07-31 Thread Thomas Petazzoni
This patchs adds the CONFIG_AIO option which allows to remove support for asynchronous I/O operations, that are not necessarly used by applications, particularly on embedded devices. As this is a size-reduction option, it depends on CONFIG_EMBEDDED. It allows to save ~7 kilobytes of kernel

[patch 4/4] Configure out IGMP support

2008-07-31 Thread Thomas Petazzoni
This patchs adds the CONFIG_IGMP option which allows to remove support for the Internet Group Management Protocol, used in multicast. Multicast is not necessarly used by applications, particularly on embedded devices. As this is a size-reduction option, it depends on CONFIG_EMBEDDED. It allows to

[patch 3/4] Configure out ethtool support

2008-07-31 Thread Thomas Petazzoni
This patchs add the CONFIG_ETHTOOL option which allows to remove support for ethtool, not necessarly used on embedded systems. As this is a size-reduction option, it depends on CONFIG_EMBEDDED. It allows to save ~6 kilobytes of kernel code: textdata bss dec hex filename 1258447

Re: [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices

2008-07-31 Thread David Woodhouse
On Thu, 2008-07-31 at 02:40 -0700, David Miller wrote: From: Thomas Petazzoni [EMAIL PROTECTED] Date: Thu, 31 Jul 2008 11:27:03 +0200 Changes since previous post: * Add Matt Mackall's Signed-off-by on all patches * Make bonding and bridging select ethtool in the ethtool-related

Re: [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices

2008-07-31 Thread David Miller
From: David Woodhouse [EMAIL PROTECTED] Date: Thu, 31 Jul 2008 10:51:52 +0100 But there are a lot of people who really don't need these features and really want the option of leaving them out. I'll say it one last time. If you have ipv4 enabled, you need ETHTOOL. -- To unsubscribe from this

Re: [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices

2008-07-31 Thread David Woodhouse
On Thu, 2008-07-31 at 02:55 -0700, David Miller wrote: From: David Woodhouse [EMAIL PROTECTED] Date: Thu, 31 Jul 2008 10:51:52 +0100 But there are a lot of people who really don't need these features and really want the option of leaving them out. I'll say it one last time. If you

Re: [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices

2008-07-31 Thread David Miller
From: David Woodhouse [EMAIL PROTECTED] Date: Thu, 31 Jul 2008 10:59:15 +0100 I have drivers which don't even _have_ ethtool support, and they seem to work fine. But leaving aside the debate on that point, your statement also seemed to be covering the other patches, such as the IGMP one and

Re: [patch 1/4] Configure out AIO support

2008-07-31 Thread Adrian Bunk
On Thu, Jul 31, 2008 at 12:09:29PM +0200, Bernhard Fischer wrote: On Thu, Jul 31, 2008 at 11:27:04AM +0200, Thomas Petazzoni wrote: This patchs adds the CONFIG_AIO option which allows to remove support for asynchronous I/O operations, that are not necessarly used by applications, particularly

Re: [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices

2008-07-31 Thread David Woodhouse
On Thu, 2008-07-31 at 03:02 -0700, David Miller wrote: I explained why I didn't want to apply the IGMP one too. Andrew didn't like my objections, but that doesn't mean I need to defend my position further. You said that it was part of the core BSD socket API and Like TCP and UDP, multicast

Re: [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices

2008-07-31 Thread David Miller
From: David Woodhouse [EMAIL PROTECTED] Date: Thu, 31 Jul 2008 11:15:16 +0100 While I agree with Andrew's observation, I'd also respectfully submit that your argument is more fundamentally bogus than that. TCP and UDP are _not_ universally available. They go away if you set CONFIG_INET=n.

Re: [patch 2/4] Configure out file locking features

2008-07-31 Thread Adrian Bunk
On Thu, Jul 31, 2008 at 06:26:16PM +0200, Thomas Petazzoni wrote: Le Thu, 31 Jul 2008 18:37:57 +0300, Adrian Bunk [EMAIL PROTECTED] a écrit : I'm just not a fan of adding config options for each few kB of code - we have to maintain them and the more complex the configuration becomes the

Re: [patch 2/4] Configure out file locking features

2008-07-31 Thread David Woodhouse
On Thu, 2008-07-31 at 19:49 +0300, Adrian Bunk wrote: On Thu, Jul 31, 2008 at 06:26:16PM +0200, Thomas Petazzoni wrote: Le Thu, 31 Jul 2008 18:37:57 +0300, Adrian Bunk [EMAIL PROTECTED] a écrit : I'm just not a fan of adding config options for each few kB of code - we have to

Re: [patch 0/4] [resend] Add configuration options to disable features not needed on embedded devices

2008-07-31 Thread Tim Bird
David Miller wrote: Some folks might find it instructive to do a google code search or similar on the multicast socket options this things dikes out of the tree. Even simple things like NTP will spew failures with this CONFIG_IGMP thing turned off. And that's just the tip of the iceberg.

Re: [patch 2/4] Configure out file locking features

2008-07-31 Thread Robert Schwebel
On Thu, Jul 31, 2008 at 10:32:20AM -0700, Tim Bird wrote: And for embedded systems with which applications is it 100% safe to disable this option? Sony's digital cameras. We have also several very small automation measurement devices in the field which run a very dedicated more or less

Re: [patch 2/4] Configure out file locking features

2008-07-31 Thread Adrian Bunk
On Thu, Jul 31, 2008 at 10:32:20AM -0700, Tim Bird wrote: Adrian Bunk wrote: And for embedded systems with which applications is it 100% safe to disable this option? Sony's digital cameras. This option *is* disabled in the kernel for (most) Sony digital cameras. Those digital cameras

Re: [patch 2/4] Configure out file locking features

2008-07-31 Thread Adrian Bunk
On Thu, Jul 31, 2008 at 08:12:14PM +0200, Robert Schwebel wrote: On Thu, Jul 31, 2008 at 10:32:20AM -0700, Tim Bird wrote: And for embedded systems with which applications is it 100% safe to disable this option? Sony's digital cameras. We have also several very small automation

Re: [patch 0/4] [resend] Add configuration options to disable features

2008-07-31 Thread Josh Boyer
On Thu, 2008-07-31 at 20:50 +0200, Ulrich Teichert wrote: Hi, I don't know of any embedded products that ship with NTP turned on. Well, I do. To be exact, I've developed parts of it. But it's numbers are only into the thousands, so that makes it insignificant ;-) It's best to assume,

Re: [patch 0/4] [resend] Add configuration options to disable features

2008-07-31 Thread David Woodhouse
On Thu, 2008-07-31 at 15:46 -0400, Josh Boyer wrote: On Thu, 2008-07-31 at 20:50 +0200, Ulrich Teichert wrote: Hi, I don't know of any embedded products that ship with NTP turned on. Well, I do. To be exact, I've developed parts of it. But it's numbers are only into the thousands,

Re: [patch 1/4] Configure out AIO support

2008-07-31 Thread Bernhard Fischer
On Thu, Jul 31, 2008 at 01:12:19PM +0300, Adrian Bunk wrote: On Thu, Jul 31, 2008 at 12:09:29PM +0200, Bernhard Fischer wrote: On Thu, Jul 31, 2008 at 11:27:04AM +0200, Thomas Petazzoni wrote: This patchs adds the CONFIG_AIO option which allows to remove support for asynchronous I/O operations,