Re: Subject: [PATCH 00/16] Squashfs: compressed read-only filesystem

[Phillip Lougher]

Geert Uytterhoeven wrote:

Hi Phillip,

On Fri, 17 Oct 2008, Phillip Lougher wrote:

This is a second attempt at mainlining Squashfs.  The first attempt was way


This is great news!

I ran a quick test of squashfs 4.0 (the CVS version) on UML/ia32 and ppc64, and 
it
seems to work fine!  Great job! Let's hope we'll see it in mainline soon...



Thanks!  I hope it gets into mainline soon too :)


BTW, one minor gripe is that the current mksquashfs doesn't want to run on big
endian yet, as there's no byteswapping support.


Yeah, I know about that.  There's still some work needing to be done on 
the squashfs-tools.  I figured it was important to get the kernel stuff 
submitted and discussed ASAP.


Phillip

--
To unsubscribe from this list: send the line unsubscribe linux-embedded in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Subject: [PATCH 01/16] Squashfs: inode operations

[Phillip Lougher]

Geert Uytterhoeven wrote:


Sparse with endian checking (make C=2 CHECKFLAGS=-D__CHECK_ENDIAN__) complains
aibout these:

| fs/squashfs/inode.c:306:25: warning: cast to restricted __le16
| fs/squashfs/inode.c:324:25: warning: cast to restricted __le16

and it seems to be right, as inode.i_mode is not __le16. I think the 
le16_to_cpu()
should be removed.


Yes, you're right.  Fixed thanks.



BTW, there are also a few sparse warnings about different signednesses, so you
probably want to run sparse yourself, too.


I'll do that.

Phillip
--
To unsubscribe from this list: send the line unsubscribe linux-embedded in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html