Re: [PATCH V2 10/16] Squashfs: cache operations

2008-10-31 Thread Jörn Engel
On Fri, 31 October 2008 04:43:46 +, Phillip Lougher wrote: Simplicity and speed is extremely important. The squashfs_metadata_read() wrapper around the cache is designed to step through the metadata a structure at a time (20 or so bytes), updating the read position in the metadata

Re: [PATCH V2 10/16] Squashfs: cache operations

2008-10-31 Thread Phillip Lougher
Jörn Engel wrote: Only one of your problems seems to be real. Not sure if or how we can solve that one, though. Sorry don't agree. But I'm not going to argue this like a couple of old maids. I'll keep what I currently do unless Andrew Morton or someone else says it's not getting

Re: [PATCH 2/2] phylib: make mdio-gpio work without OF

2008-10-31 Thread Grant Likely
On Fri, Oct 31, 2008 at 10:49 AM, Paulius Zaleckas [EMAIL PROTECTED] wrote: make mdio-gpio work with non OpenFirmware gpio implementation. Looking good, but it has too many #ifdef blocks for my taste. In particular, if the driver is refactored a bit then all the OF stuff can be contained

Re: [PATCH 2/2] phylib: make mdio-gpio work without OF

2008-10-31 Thread Mike Frysinger
On Fri, Oct 31, 2008 at 12:49, Paulius Zaleckas wrote: +#ifndef NO_IRQ +#define NO_IRQ 0 +#endif discussions elsewhere indicate this should die. -if (irq != NO_IRQ) +if (irq) -mike -- To unsubscribe from this list: send the line unsubscribe linux-embedded in the body of a message to [EMAIL