Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

2008-11-05 Thread David Brownell
On Wednesday 05 November 2008, Grant Likely wrote: > >  Maybe the best solution is > > to write separate driver for OF which will be just wrapper for platform > > driver... Just like you suggested. I'd certainly prefer that: packaging all the OF glue in a small bit of OF glue code, which does

Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

2008-11-05 Thread David Brownell
On Wednesday 05 November 2008, Marc Pignat wrote: > This is why I proposed to split the driver in two parts (gpio only mdio > driver + OF platform device). Just treating OF GPIO as any other GPIO. I think that's overall a much cleaner approach too. Keeps OF's hardware abstraction layer out of dri

Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

2008-11-05 Thread Grant Likely
On Wed, Nov 5, 2008 at 1:57 AM, Paulius Zaleckas <[EMAIL PROTECTED]> wrote: > Mike Frysinger wrote: >> On Wed, Nov 5, 2008 at 03:11, David Brownell wrote: >>> On Tuesday 04 November 2008, Mike Frysinger wrote: > If indeed OF functions don't have declarations which are > available on all pla

Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

2008-11-05 Thread Paulius Zaleckas
Paulius Zaleckas wrote: > Mike Frysinger wrote: >> On Wed, Nov 5, 2008 at 03:11, David Brownell wrote: >>> On Tuesday 04 November 2008, Mike Frysinger wrote: > If indeed OF functions don't have declarations which are > available on all platforms, that might be worth fixing > to enable t

Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

2008-11-05 Thread Paulius Zaleckas
Mike Frysinger wrote: > On Wed, Nov 5, 2008 at 03:11, David Brownell wrote: >> On Tuesday 04 November 2008, Mike Frysinger wrote: If indeed OF functions don't have declarations which are available on all platforms, that might be worth fixing to enable this approach to #ifdef eliminat

Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

2008-11-05 Thread Marc Pignat
On Wednesday 05 November 2008, Mike Frysinger wrote: ... > i understand the compiler side just fine. my point is that the > current linux/of_gpio.h only defines the OF structure and related > prototypes when CONFIG_OF_GPIO is defined. so it needs updating > first. This is why I proposed to spli

Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

2008-11-05 Thread Mike Frysinger
On Wed, Nov 5, 2008 at 03:11, David Brownell wrote: > On Tuesday 04 November 2008, Mike Frysinger wrote: >> > If indeed OF functions don't have declarations which are >> > available on all platforms, that might be worth fixing >> > to enable this approach to #ifdef elimination. >> >> OF is open fir

Re: [PATCH] phylib: make mdio-gpio work without OF (v2)

2008-11-05 Thread David Brownell
On Tuesday 04 November 2008, Mike Frysinger wrote: > > If indeed OF functions don't have declarations which are > > available on all platforms, that might be worth fixing > > to enable this approach to #ifdef elimination. > > OF is open firmware right ?  no way there's going to be OF for every > p