Re: [PATCH 03/11] readahead: bump up the default readahead size

2010-02-12 Thread Matt Mackall
On Fri, 2010-02-12 at 21:59 +0800, Wu Fengguang wrote: > On Fri, Feb 12, 2010 at 07:42:49AM +0800, Jamie Lokier wrote: > > Matt Mackall wrote: > > > On Mon, 2010-02-08 at 21:46 +0800, Wu Fengguang wrote: > > > > Chris, > > > > > > > > Firstly inform the linux-embedded maintainers :) > > > > > > >

Re: [PATCH 03/11] readahead: bump up the default readahead size

2010-02-12 Thread Matt Mackall
On Thu, 2010-02-11 at 23:42 +, Jamie Lokier wrote: > Matt Mackall wrote: > > On Mon, 2010-02-08 at 21:46 +0800, Wu Fengguang wrote: > > > Chris, > > > > > > Firstly inform the linux-embedded maintainers :) > > > > > > I think it's a good suggestion to add a config option > > > (CONFIG_READAHE

Re: [PWM PATCH 2/5] Emulates PWM hardware using a high-resolution timer and a GPIO pin

2010-02-12 Thread Bill Gatliff
H Hartley Sweeten wrote: > > FWIW, the gpiolib API will accept any non-zero value to "set" a gpio pin > and a zero value to "clear" the pin. > It makes me sort of cringe to say this, but I'm going to assume that the API is intended to work that way so that I can take advantage of it. But I'd l

Re: [PATCH 03/11] readahead: bump up the default readahead size

2010-02-12 Thread Wu Fengguang
On Fri, Feb 12, 2010 at 07:42:49AM +0800, Jamie Lokier wrote: > Matt Mackall wrote: > > On Mon, 2010-02-08 at 21:46 +0800, Wu Fengguang wrote: > > > Chris, > > > > > > Firstly inform the linux-embedded maintainers :) > > > > > > I think it's a good suggestion to add a config option > > > (CONFIG_

RE: [PWM PATCH 2/5] Emulates PWM hardware using a high-resolution timer and a GPIO pin

2010-02-12 Thread H Hartley Sweeten
Thursday, February 11, 2010 1:35 PM, Bill Gatliff wrote: > Pavel Machek wrote: >>> +static void >>> +gpio_pwm_work (struct work_struct *work) >>> +{ >>> + struct gpio_pwm *gp = container_of(work, struct gpio_pwm, work); >>> + >>> + if (gp->active) >>> + gpio_direction_output(gp->gpio,

Re: [PWM PATCH 2/5] Emulates PWM hardware using a high-resolution timer and a GPIO pin

2010-02-12 Thread Pavel Machek
> > 11.02.2010, ? 23:58, Pavel Machek ???(?): > > > On Thu 2010-02-11 14:35:14, Bill Gatliff wrote: > >> Pavel Machek wrote: > +static void > +gpio_pwm_work (struct work_struct *work) > +{ > +struct gpio_pwm *gp = container_of(work, struct gpio_pwm, work); > +

Re: [PWM PATCH 2/5] Emulates PWM hardware using a high-resolution timer and a GPIO pin

2010-02-12 Thread Geert Uytterhoeven
2010/2/12 Stanislav O. Bezzubtsev : > The second strange thing is "unsigned long :1". I'm not sure but as far > as I can remember the right way to define several-bits field is "int > :1". But I might be mistaken. A bitfield of size 1 should not be signed, as there's no space for a sign bit. Usua